Patch Detail
Show a patch.
GET /api/patches/15739/?format=api
{ "id": 15739, "url": "https://patchwork.libcamera.org/api/patches/15739/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15739/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220427223004.115381-3-Rauch.Christian@gmx.de>", "date": "2022-04-27T22:30:02", "name": "[libcamera-devel,v4,2/4] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e31b9dbd324d50218e82105b64f6aaaa23d22c05", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15739/mbox/", "series": [ { "id": 3080, "url": "https://patchwork.libcamera.org/api/series/3080/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3080", "date": "2022-04-27T22:30:00", "name": "generate and use fixed-sized Span Control types", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3080/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15739/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15739/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05EABC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Apr 2022 22:30:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE5446564C;\n\tThu, 28 Apr 2022 00:30:12 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B84B465644\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Apr 2022 00:30:08 +0200 (CEST)", "from localhost.localdomain ([92.10.251.63]) by mail.gmx.net\n\t(mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1N2V4J-1nreTI2cUZ-013rQD; Thu, 28 Apr 2022 00:30:07 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1651098613;\n\tbh=KhDEhrcooUEg4LlVLFrto+wzWSv9nmQuCaj/02wozVo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xtnMP+u8BKiYZD99YJ8qj2JLGzjGAKUAtoIrnzU2lnEOOuF5hvpmKtGc/RvcOLPgQ\n\t57OJUDCpGuwCYe955BrI+qpF3eSMRGqK57KKtC1ASY9doxiHFRi3HpLc4gtVfC+4wd\n\t9uqJVEoNwhKuvinOM8pKZBDd17louzq0Fe4wxfWPZOvAz9MABY7PpuOPPUgUiRds5/\n\tiAHAIJKCZa4zbTM5Zgd0hT4MwUDTEvmusw6qja3M02jNADOfBdJooJBDoN3Xyq3UOb\n\tTj8Ki4wcUh8U1dG5l/NEk/3qimoXt+Q74aJ5QzNJMbMCTUKCobL+AfbcNPwtvczKvQ\n\tR4ic2GHc0uDmQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1651098607;\n\tbh=KhDEhrcooUEg4LlVLFrto+wzWSv9nmQuCaj/02wozVo=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=iS4hTNw/97Gx2VAulGGCVyeMG5uuhTFrXAfjz0XWmlqkHmbg+6zYL9vC5GydHroku\n\tY9tfVNlRV8+29D4Ndl2bUvf0UnCbE53eQsxEgddsv4rWYno542B6wsU472MZLwMQqq\n\tKhqP/LlAAP7qXI891mUjebRl67nS0nuReaFOYzZ8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"iS4hTNw/\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 27 Apr 2022 23:30:02 +0100", "Message-Id": "<20220427223004.115381-3-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220427223004.115381-1-Rauch.Christian@gmx.de>", "References": "<20220427223004.115381-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:s7t5ewETq+zxYFc9Lw9obsh2KV3N/4STpmndvEVbYO6E2lzqytB\n\tAG2LVDhb9p7kIZDswA4PGT7w5J715MQdM9F60zXh2GJnqcfkJYzdm98+BKweqPr75S9hpRi\n\txu0V6Yj2pBTx1DqPG3kzSKLBOwUmPMPqftTNOExvS5qdZABic+NUFyBjXPbRzQDGJdvkjrE\n\tMEJzfTWdoio6ZmeZRX+Lw==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:3KKdqAPC24k=:Cd9W0vkp0a/ihhTKh6/7nj\n\tjXAFwWtUO0Cj7ETpplwBcLTxAKsEs1ea/+tsPCtPMCe9CFVo+ejp6K1+xKKofmcLSeg9OpIbV\n\tRZF9U+mTZiTDcQ9yO8bbx01JBpnNUqUxhrewSxcGilcYDWQdHJzbNUg7UNHPhSQX6aYqA5rPl\n\t5rKJJymEr/c4O1Hvrs0Lz1tqLuNLjX+Jfjbvih6P+fvixaFoHC+ySxlESa8Fbs+0fR573wOha\n\tQiBy+Vf8ZtZfnBSjpZSIDT0X/CJJofe0sXgSrKhIww36uCYJbZvSOJL5MNedoGDnsogOES622\n\tQMWR2idFrNeC6htBFpWBK+qmUUhxgp0c/UZ5LdgrNrdCZ81DkvuRHtESYQdsYWUYcS3JLmYD7\n\t7hEIiSAA65nrlwBkt72TetvE5+f58yYJPuEY9K7ZI6B0UEUjbVhk4n+ViKiD8vDrfC6WAXrcn\n\tV+vbLUu4hVmdjT5kAlguXEJTk3AePQdkIGO7CUWAy/rMzU1m/PjJ42F4swiyJ4K+a9Xfz9yTe\n\tn7mrhzQUK2YByQrmocM0muicQ71TM4irrlba6CAdkAAYTXhslwLGzwqmx1omqLYUqT7aZNdQt\n\tTgrubncp2FvQ/eze9E+uZ5NYIwfds3sDkgWo5DRNRZcy1/vrcaXPpAkgOrqowcnQb10SMPcgO\n\tx1KZLXJ47uC36XUxiT0oF6kGeniKt3RoV2UGTDrn3O3BY6/Kw8tQC4IRpaL1cy/wZRmJG4SNs\n\tN92C9EvdIKaJsotQL86IhZjiIIb9L4ZCbZoyKygzRYo8Zb/6wV3okfbBbUUxutZFSB5yJ93ga\n\tTxU4kLHhHbZ+IEpvUNnMydl3ZB+Q6Os1c4LFTLul0HTIL21uSXXHbhsGF2TPLk7lQtaRj6ApG\n\tB+i3TC1M6AUK8UI4MBhtsD/ZWDabTKSnR0ZgzriogWNCXqdcBw9CBUTk3AX541SxW/TztvKJO\n\tYSqciYnHYBq5UIBlnFh0DMNHODKHNFTMe8UXdSre7tcQGqbgho0xGqj/iaz+wPJs1NjBBIC5U\n\tnkr3suVV9ow1F1Qecskzn2yc8CDz5heErMay36ilJB7gAww1pBFNGAwlxEfWCKY6fgkUXbUHy\n\tNPPzLcSfalQqHY=", "Subject": "[libcamera-devel] [PATCH v4 2/4] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 2 +-\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 9d4638ae..c3f593a1 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 12ecbce5..47c350ed 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v4", "2/4" ] }