From patchwork Wed Apr 27 22:30:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 15739 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 05EABC3256 for ; Wed, 27 Apr 2022 22:30:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DE5446564C; Thu, 28 Apr 2022 00:30:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1651098613; bh=KhDEhrcooUEg4LlVLFrto+wzWSv9nmQuCaj/02wozVo=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xtnMP+u8BKiYZD99YJ8qj2JLGzjGAKUAtoIrnzU2lnEOOuF5hvpmKtGc/RvcOLPgQ 57OJUDCpGuwCYe955BrI+qpF3eSMRGqK57KKtC1ASY9doxiHFRi3HpLc4gtVfC+4wd 9uqJVEoNwhKuvinOM8pKZBDd17louzq0Fe4wxfWPZOvAz9MABY7PpuOPPUgUiRds5/ iAHAIJKCZa4zbTM5Zgd0hT4MwUDTEvmusw6qja3M02jNADOfBdJooJBDoN3Xyq3UOb Tj8Ki4wcUh8U1dG5l/NEk/3qimoXt+Q74aJ5QzNJMbMCTUKCobL+AfbcNPwtvczKvQ R4ic2GHc0uDmQ== Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B84B465644 for ; Thu, 28 Apr 2022 00:30:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="iS4hTNw/"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1651098607; bh=KhDEhrcooUEg4LlVLFrto+wzWSv9nmQuCaj/02wozVo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=iS4hTNw/97Gx2VAulGGCVyeMG5uuhTFrXAfjz0XWmlqkHmbg+6zYL9vC5GydHroku Y9tfVNlRV8+29D4Ndl2bUvf0UnCbE53eQsxEgddsv4rWYno542B6wsU472MZLwMQqq KhqP/LlAAP7qXI891mUjebRl67nS0nuReaFOYzZ8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.10.251.63]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2V4J-1nreTI2cUZ-013rQD; Thu, 28 Apr 2022 00:30:07 +0200 To: libcamera-devel@lists.libcamera.org Date: Wed, 27 Apr 2022 23:30:02 +0100 Message-Id: <20220427223004.115381-3-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220427223004.115381-1-Rauch.Christian@gmx.de> References: <20220427223004.115381-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:s7t5ewETq+zxYFc9Lw9obsh2KV3N/4STpmndvEVbYO6E2lzqytB AG2LVDhb9p7kIZDswA4PGT7w5J715MQdM9F60zXh2GJnqcfkJYzdm98+BKweqPr75S9hpRi xu0V6Yj2pBTx1DqPG3kzSKLBOwUmPMPqftTNOExvS5qdZABic+NUFyBjXPbRzQDGJdvkjrE MEJzfTWdoio6ZmeZRX+Lw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:3KKdqAPC24k=:Cd9W0vkp0a/ihhTKh6/7nj jXAFwWtUO0Cj7ETpplwBcLTxAKsEs1ea/+tsPCtPMCe9CFVo+ejp6K1+xKKofmcLSeg9OpIbV RZF9U+mTZiTDcQ9yO8bbx01JBpnNUqUxhrewSxcGilcYDWQdHJzbNUg7UNHPhSQX6aYqA5rPl 5rKJJymEr/c4O1Hvrs0Lz1tqLuNLjX+Jfjbvih6P+fvixaFoHC+ySxlESa8Fbs+0fR573wOha QiBy+Vf8ZtZfnBSjpZSIDT0X/CJJofe0sXgSrKhIww36uCYJbZvSOJL5MNedoGDnsogOES622 QMWR2idFrNeC6htBFpWBK+qmUUhxgp0c/UZ5LdgrNrdCZ81DkvuRHtESYQdsYWUYcS3JLmYD7 7hEIiSAA65nrlwBkt72TetvE5+f58yYJPuEY9K7ZI6B0UEUjbVhk4n+ViKiD8vDrfC6WAXrcn V+vbLUu4hVmdjT5kAlguXEJTk3AePQdkIGO7CUWAy/rMzU1m/PjJ42F4swiyJ4K+a9Xfz9yTe n7mrhzQUK2YByQrmocM0muicQ71TM4irrlba6CAdkAAYTXhslwLGzwqmx1omqLYUqT7aZNdQt Tgrubncp2FvQ/eze9E+uZ5NYIwfds3sDkgWo5DRNRZcy1/vrcaXPpAkgOrqowcnQb10SMPcgO x1KZLXJ47uC36XUxiT0oF6kGeniKt3RoV2UGTDrn3O3BY6/Kw8tQC4IRpaL1cy/wZRmJG4SNs N92C9EvdIKaJsotQL86IhZjiIIb9L4ZCbZoyKygzRYo8Zb/6wV3okfbBbUUxutZFSB5yJ93ga TxU4kLHhHbZ+IEpvUNnMydl3ZB+Q6Os1c4LFTLul0HTIL21uSXXHbhsGF2TPLk7lQtaRj6ApG B+i3TC1M6AUK8UI4MBhtsD/ZWDabTKSnR0ZgzriogWNCXqdcBw9CBUTk3AX541SxW/TztvKJO YSqciYnHYBq5UIBlnFh0DMNHODKHNFTMe8UXdSre7tcQGqbgho0xGqj/iaz+wPJs1NjBBIC5U nkr3suVV9ow1F1Qecskzn2yc8CDz5heErMay36ilJB7gAww1pBFNGAwlxEfWCKY6fgkUXbUHy NPPzLcSfalQqHY= Subject: [libcamera-devel] [PATCH v4 2/4] libcamera: controls: Define size of array controls as a shape vector X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This follows the convention in other Tensor APIs. Since all tensors are represented as a Span with a single dimension, values provided in 'size' are interpreted as fixed-size Spans, while an empty array ("[]") will be interpreted as variable-sized Span. Signed-off-by: Christian Rauch Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 2 +- src/libcamera/property_ids.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.34.1 diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 9d4638ae..c3f593a1 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -291,7 +291,7 @@ controls: transformation. The 3x3 matrix is stored in conventional reading order in an array of 9 floating point values. - size: [3x3] + size: [3,3] - ScalerCrop: type: Rectangle diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 12ecbce5..47c350ed 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -497,7 +497,7 @@ controls: - PixelArrayOpticalBlackRectangles: type: Rectangle - size: [n] + size: [] description: | The pixel array region(s) which contain optical black pixels considered valid for calibration purposes. @@ -592,7 +592,7 @@ controls: - PixelArrayActiveAreas: type: Rectangle - size: [n] + size: [] description: | The PixelArrayActiveAreas property defines the (possibly multiple and overlapping) portions of the camera sensor readable pixel matrix