Patch Detail
Show a patch.
GET /api/patches/15606/?format=api
{ "id": 15606, "url": "https://patchwork.libcamera.org/api/patches/15606/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15606/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220401000616.12976-4-Rauch.Christian@gmx.de>", "date": "2022-04-01T00:06:14", "name": "[libcamera-devel,3/5] provide a default fixed-sized Span constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9bb438700b3a56a9ea6f5c289de59a15cd4433bc", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15606/mbox/", "series": [ { "id": 3022, "url": "https://patchwork.libcamera.org/api/series/3022/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3022", "date": "2022-04-01T00:06:11", "name": "generate and use fixed-sized Span Control types", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3022/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15606/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15606/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CDAA8C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 1 Apr 2022 00:06:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 141486563A;\n\tFri, 1 Apr 2022 02:06:48 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C67D165631\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 1 Apr 2022 02:06:45 +0200 (CEST)", "from localhost.localdomain ([92.10.251.63]) by mail.gmx.net\n\t(mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1MsYv3-1ntg461R1f-00u5xv; Fri, 01 Apr 2022 02:06:45 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648771608;\n\tbh=dCN0zXKjOJg6nL++Wc/KnDtiT7JyUC2xTyT5uMG1gLI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=iHhfnAaOJwzNj0d6ZbtFfHsQcg8Uy5PrjyFN6UU51/4Rs9Rq0FrZrIoXBKmQICurQ\n\tXrY+62W93UDFjsOmRaQMe0kf6bVNE0KW/JwhzwmaUQYXKfIdUFP4BWHmiG0W8a3Gg9\n\tf18RW8OVp6Nu+AC5kwh57K/PQM1n3LiZdwOJDmq319SP+MwFGVvT7AYnJh8o+pKPFs\n\tSVC5NRrWwPF4/kxUxuy6ohdkHCKdi76Tqar9JjB5J6mnHDOSzDLg3GP6H2Fe3lDAKT\n\t7ALeZ3QzRfiEJwwZdOUAyjPoEdlY0dOKnhyYrKwf0fpPVxH2lVFGriY0NoswbaewDP\n\tKBZIBHZq7YoRg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1648771605;\n\tbh=dCN0zXKjOJg6nL++Wc/KnDtiT7JyUC2xTyT5uMG1gLI=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=DAa3zj8+c1TwOvNwVtcJgEKcjOfabVlVAHW4fm6nB32V2ocRV5dlswJ0+lYTsm1gJ\n\tXL2JWJpBciYv6fbLMtxhlyGhBEB9PGyBO+ZeBjH+63fFqN6VEUFLJUrWL7smcoLr7a\n\tWGaEOSfQhwxW6BywJcXfzV7RIkUW1M0nEj9bdhGk=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"DAa3zj8+\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 1 Apr 2022 01:06:14 +0100", "Message-Id": "<20220401000616.12976-4-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220401000616.12976-1-Rauch.Christian@gmx.de>", "References": "<20220401000616.12976-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:8vymKkR/9CXoaT9myx7ZxN/SY+9o0MrRLCDj5HASLlLIywf+IXI\n\tj5dJ6slJCLnfVKkii380FwpXZBLSqwsWrxdsILxUMbJoRssbfvOAlmgKpO90OuDEAE07cba\n\tBnNJmg5dtyTVXDxQeRhcSC+JKrkBDQKmAo1ZDseVqiG/ZqVlbw106ASDY996IjBno2Ko13E\n\t4TEvHrBqcEg7bTX3+U55Q==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:WYhstEDN6FI=:6P20zKkOafHyptgAKKnHpS\n\tWM1rguJOqdJ618VXSP8WDKPGCoaVhKdYWNMf9RUnT5sm4xp19njdqjRKrKOaYYBVcCTjadYzr\n\ts6wlgqbklJpJtJBNAO/o6aKlS7C5KTVLeeYADNW9FPiZs0EeeNSeC/uvTpwU+tVsKyuz62O/q\n\tYRR+Ie1U2IenCbZHhhoCes0Wva0KssaDPStSQgAkNVzfSTbqzmKIzeL0oGjeH/91MAU5kpmCa\n\twyTmuGk7H+PfGRxO2ZKuGI3QqNIdsmEOYXVjfJE8RU+1u/xGNDRvj8L+fEc+lu2k1dPgtTEWa\n\tBBpRBkuRsMOPDRz2Amt4iSRIvb5LKje5K4AjESmZes6/71Qs+/9sq1lxE5a3nLXkrMWnytuq7\n\tsIo40Z2lGBmDRsIh7MZtaBVqkjUZ+bniwz9dftf1Pi8JEvCB//IyaknTdh1cvYOxs99S2F43j\n\tCm568yPWWhl4CW99k/trv7wD9cgBazir9kpmPv2jI004HMVomzjD696jHLqWE7Z/RoMPydX2V\n\tLzq85eOWy+PpIEVtYEqOQ+VipD8QfXOfW9y0U0SY4r+Ap24Y0Roq5m9qceDS1W5DDQPozurKU\n\t/CV8Dw7dCSfo0MeRLuX9SGLeH+45Tf5ZFSrdjWlvUAAWDSH2Az/ps7PSB/ieHUbW4lFHdUmwQ\n\tsWLov8TBdMSRdujZul93KuTGbXA/nMSNCWjcQT+KQu8ynrfv3fiznZv29wn8ghxMa26aA5i3/\n\tm20AwGefRyqhsjpoG4YOLuxgiH3YKbfgZcqoAImo0vwALDAhS9HbBiovwzQ0uTGxScihIABuJ\n\t+ZHj403GlVGsPki3lG6IsMLZJOrW9QFcmBniRdy47/O8JBlEYmZLodlyjF/fPRWpWN/MokYgq\n\tbPQI1BuE704eE6KDPb2tT+lKSm9uFSNJZiTKDkyMeuDpBNIgtekFdpuUEEqAJ8mEIWTF/kA4X\n\tC4KkKmUJaPdrCxwqOgfpv567CdTQVlIkEoboYEafdBa9mgB2NpWXFWLe3z58Xe6xGyJiGXywh\n\ttTaNxq6i/FIYrShAajCyFcrc391DMtEVRj/fEjIp0mf614JJsU8yWlfimODHXTv0tx9k5pXeE\n\tNg/lcl5MPH5oSM=", "Subject": "[libcamera-devel] [PATCH 3/5] provide a default fixed-sized Span\n\tconstructor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The new default constructor allows to construct a fixed-sized Span via the\ndefault constructor of its stored data type.\nThis prevents the construction of empty fixed-sized Spans that cannot hold\nany data.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n include/libcamera/base/span.h | 5 +++++\n include/libcamera/controls.h | 2 +-\n test/span.cpp | 2 +-\n 3 files changed, 7 insertions(+), 2 deletions(-)\n\n--\n2.25.1", "diff": "diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\nindex 88d2e3de..7a4806dc 100644\n--- a/include/libcamera/base/span.h\n+++ b/include/libcamera/base/span.h\n@@ -112,6 +112,11 @@ public:\n \t{\n \t}\n\n+\tSpan()\n+\t{\n+\t\tSpan(std::array<value_type, extent>{});\n+\t}\n+\n \texplicit constexpr Span(pointer ptr, [[maybe_unused]] size_type count)\n \t\t: data_(ptr)\n \t{\ndiff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 665bcac1..de8a7770 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -167,7 +167,7 @@ public:\n\n \t\tusing V = typename T::value_type;\n \t\tconst V *value = reinterpret_cast<const V *>(data().data());\n-\t\treturn { value, numElements_ };\n+\t\treturn T{ value, numElements_ };\n \t}\n\n #ifndef __DOXYGEN__\ndiff --git a/test/span.cpp b/test/span.cpp\nindex abf3a5d6..c37e2a66 100644\n--- a/test/span.cpp\n+++ b/test/span.cpp\n@@ -37,7 +37,7 @@ protected:\n \t\t * to generate undefined behaviour.\n \t\t */\n\n-\t\tSpan<int, 0>{};\n+\t\t/* Span<int, 0>{}; */\n \t\t/* Span<int, 4>{}; */\n\n \t\tSpan<int, 4>{ &i[0], 4 };\n", "prefixes": [ "libcamera-devel", "3/5" ] }