From patchwork Fri Apr 1 00:06:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 15606 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CDAA8C0F1B for ; Fri, 1 Apr 2022 00:06:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 141486563A; Fri, 1 Apr 2022 02:06:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1648771608; bh=dCN0zXKjOJg6nL++Wc/KnDtiT7JyUC2xTyT5uMG1gLI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=iHhfnAaOJwzNj0d6ZbtFfHsQcg8Uy5PrjyFN6UU51/4Rs9Rq0FrZrIoXBKmQICurQ XrY+62W93UDFjsOmRaQMe0kf6bVNE0KW/JwhzwmaUQYXKfIdUFP4BWHmiG0W8a3Gg9 f18RW8OVp6Nu+AC5kwh57K/PQM1n3LiZdwOJDmq319SP+MwFGVvT7AYnJh8o+pKPFs SVC5NRrWwPF4/kxUxuy6ohdkHCKdi76Tqar9JjB5J6mnHDOSzDLg3GP6H2Fe3lDAKT 7ALeZ3QzRfiEJwwZdOUAyjPoEdlY0dOKnhyYrKwf0fpPVxH2lVFGriY0NoswbaewDP KBZIBHZq7YoRg== Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C67D165631 for ; Fri, 1 Apr 2022 02:06:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="DAa3zj8+"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1648771605; bh=dCN0zXKjOJg6nL++Wc/KnDtiT7JyUC2xTyT5uMG1gLI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=DAa3zj8+c1TwOvNwVtcJgEKcjOfabVlVAHW4fm6nB32V2ocRV5dlswJ0+lYTsm1gJ XL2JWJpBciYv6fbLMtxhlyGhBEB9PGyBO+ZeBjH+63fFqN6VEUFLJUrWL7smcoLr7a WGaEOSfQhwxW6BywJcXfzV7RIkUW1M0nEj9bdhGk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.10.251.63]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MsYv3-1ntg461R1f-00u5xv; Fri, 01 Apr 2022 02:06:45 +0200 To: libcamera-devel@lists.libcamera.org Date: Fri, 1 Apr 2022 01:06:14 +0100 Message-Id: <20220401000616.12976-4-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220401000616.12976-1-Rauch.Christian@gmx.de> References: <20220401000616.12976-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:8vymKkR/9CXoaT9myx7ZxN/SY+9o0MrRLCDj5HASLlLIywf+IXI j5dJ6slJCLnfVKkii380FwpXZBLSqwsWrxdsILxUMbJoRssbfvOAlmgKpO90OuDEAE07cba BnNJmg5dtyTVXDxQeRhcSC+JKrkBDQKmAo1ZDseVqiG/ZqVlbw106ASDY996IjBno2Ko13E 4TEvHrBqcEg7bTX3+U55Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:WYhstEDN6FI=:6P20zKkOafHyptgAKKnHpS WM1rguJOqdJ618VXSP8WDKPGCoaVhKdYWNMf9RUnT5sm4xp19njdqjRKrKOaYYBVcCTjadYzr s6wlgqbklJpJtJBNAO/o6aKlS7C5KTVLeeYADNW9FPiZs0EeeNSeC/uvTpwU+tVsKyuz62O/q YRR+Ie1U2IenCbZHhhoCes0Wva0KssaDPStSQgAkNVzfSTbqzmKIzeL0oGjeH/91MAU5kpmCa wyTmuGk7H+PfGRxO2ZKuGI3QqNIdsmEOYXVjfJE8RU+1u/xGNDRvj8L+fEc+lu2k1dPgtTEWa BBpRBkuRsMOPDRz2Amt4iSRIvb5LKje5K4AjESmZes6/71Qs+/9sq1lxE5a3nLXkrMWnytuq7 sIo40Z2lGBmDRsIh7MZtaBVqkjUZ+bniwz9dftf1Pi8JEvCB//IyaknTdh1cvYOxs99S2F43j Cm568yPWWhl4CW99k/trv7wD9cgBazir9kpmPv2jI004HMVomzjD696jHLqWE7Z/RoMPydX2V Lzq85eOWy+PpIEVtYEqOQ+VipD8QfXOfW9y0U0SY4r+Ap24Y0Roq5m9qceDS1W5DDQPozurKU /CV8Dw7dCSfo0MeRLuX9SGLeH+45Tf5ZFSrdjWlvUAAWDSH2Az/ps7PSB/ieHUbW4lFHdUmwQ sWLov8TBdMSRdujZul93KuTGbXA/nMSNCWjcQT+KQu8ynrfv3fiznZv29wn8ghxMa26aA5i3/ m20AwGefRyqhsjpoG4YOLuxgiH3YKbfgZcqoAImo0vwALDAhS9HbBiovwzQ0uTGxScihIABuJ +ZHj403GlVGsPki3lG6IsMLZJOrW9QFcmBniRdy47/O8JBlEYmZLodlyjF/fPRWpWN/MokYgq bPQI1BuE704eE6KDPb2tT+lKSm9uFSNJZiTKDkyMeuDpBNIgtekFdpuUEEqAJ8mEIWTF/kA4X C4KkKmUJaPdrCxwqOgfpv567CdTQVlIkEoboYEafdBa9mgB2NpWXFWLe3z58Xe6xGyJiGXywh tTaNxq6i/FIYrShAajCyFcrc391DMtEVRj/fEjIp0mf614JJsU8yWlfimODHXTv0tx9k5pXeE Ng/lcl5MPH5oSM= Subject: [libcamera-devel] [PATCH 3/5] provide a default fixed-sized Span constructor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The new default constructor allows to construct a fixed-sized Span via the default constructor of its stored data type. This prevents the construction of empty fixed-sized Spans that cannot hold any data. Signed-off-by: Christian Rauch --- include/libcamera/base/span.h | 5 +++++ include/libcamera/controls.h | 2 +- test/span.cpp | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h index 88d2e3de..7a4806dc 100644 --- a/include/libcamera/base/span.h +++ b/include/libcamera/base/span.h @@ -112,6 +112,11 @@ public: { } + Span() + { + Span(std::array{}); + } + explicit constexpr Span(pointer ptr, [[maybe_unused]] size_type count) : data_(ptr) { diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h index 665bcac1..de8a7770 100644 --- a/include/libcamera/controls.h +++ b/include/libcamera/controls.h @@ -167,7 +167,7 @@ public: using V = typename T::value_type; const V *value = reinterpret_cast(data().data()); - return { value, numElements_ }; + return T{ value, numElements_ }; } #ifndef __DOXYGEN__ diff --git a/test/span.cpp b/test/span.cpp index abf3a5d6..c37e2a66 100644 --- a/test/span.cpp +++ b/test/span.cpp @@ -37,7 +37,7 @@ protected: * to generate undefined behaviour. */ - Span{}; + /* Span{}; */ /* Span{}; */ Span{ &i[0], 4 };