Patch Detail
Show a patch.
GET /api/patches/15264/?format=api
{ "id": 15264, "url": "https://patchwork.libcamera.org/api/patches/15264/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15264/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220110154226.1004602-1-naush@raspberrypi.com>", "date": "2022-01-10T15:42:26", "name": "[libcamera-devel,v1] pipeline: raspberrypi: Do not mark the Embedded Data stream as external", "commit_ref": "b71cd3358f6bb4f8f8efc7974c9d1acd131788bb", "pull_url": null, "state": "accepted", "archived": false, "hash": "96be3eaacddfba2ff1f302fecdced6ddcdde4d4e", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15264/mbox/", "series": [ { "id": 2886, "url": "https://patchwork.libcamera.org/api/series/2886/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2886", "date": "2022-01-10T15:42:26", "name": "[libcamera-devel,v1] pipeline: raspberrypi: Do not mark the Embedded Data stream as external", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2886/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15264/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15264/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 211D1BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Jan 2022 15:42:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AEDF604F8;\n\tMon, 10 Jan 2022 16:42:31 +0100 (CET)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F00A6021A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jan 2022 16:42:28 +0100 (CET)", "by mail-wm1-x333.google.com with SMTP id\n\tf141-20020a1c1f93000000b003497aec3f86so117219wmf.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jan 2022 07:42:28 -0800 (PST)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:3222:bb03:1840:95be])\n\tby smtp.gmail.com with ESMTPSA id\n\tb2sm7571200wrd.35.2022.01.10.07.42.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 10 Jan 2022 07:42:28 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"p8csNOS5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=nM52PHBNGMvq/I2fAXzdv6QHNu1NzN1278BUFP6Lx6I=;\n\tb=p8csNOS5jJyzgNXd79IKspQDfhjjxQxhSdKieJBFaP9PqoDDMDmvNEy0Bqyk677nie\n\tWZqX7DsSxT5c3k5fbt2Kojk6MgzRTGhvgraoqNguUTc0E0HC/RABRizg0LWYgzp8U9+E\n\tUS3XWsA4iWaESKH8/8soRviCtDHoFNoODDAevJwHzlmQp3EUJCiYL7v8EnAiKi4k2zjX\n\tbsZfSdIEYhW6dAs+UlOE1RVSGLqn7ECrGIVSymrt/UXheXT7pMvYySv3HKlm7AUnQ08g\n\tS8+Vl2ERSt9IiX3VnuVfgDUubV63udtZF8GQxKQyqqz39s7MKBSWaDry7WKlnGhPylZF\n\tTrLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=nM52PHBNGMvq/I2fAXzdv6QHNu1NzN1278BUFP6Lx6I=;\n\tb=KS4TzllPRredzBb2Zg7c/sDfm/QXjUolHpPP20wGFmJkn8Pn8tYeaK6idrqoqAQqF+\n\t4P0B09W7wNUWUbO6nDDmzdPzO6SDR/fxkv3D/yTHUaPBiDASCJdV2iKR7VMQNNHjLt1C\n\t4+3BHKxHSc5TbkG5AZhb0qm5gWJqdKP/mH1vURqkECnu1TQlGVcyqVuN/KdBbIVlQovs\n\tYijGYuhwFjhke6KwXiSQFT6FlsLzu/Uxi4TcKqzfDYXaZQ/YTqBETS4mx2uTsczzWQMK\n\t+cecyyv0+pBJBR1ZHuEuFGTpkaZkSnVDx0p+TbZiFl1XUhe4tSgOz7eEQKedBYIdthB0\n\tKY8g==", "X-Gm-Message-State": "AOAM532EUc9awUxoxz5pBIOn/AFgKZn+ZIISr1Gai1bGps5lRsNA45M0\n\t2HxSgpFXJB3DLJLfwB1DPp6cS8dXTpAd7A==", "X-Google-Smtp-Source": "ABdhPJzw6q5akKkb1ypqyGW7kScgoz74MfXUsmOwb7/1beTHrFtY/kLjq7uVwMOS4HAaFq2mkKPJKw==", "X-Received": "by 2002:a1c:c917:: with SMTP id\n\tf23mr23133005wmb.10.1641829348426; \n\tMon, 10 Jan 2022 07:42:28 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 10 Jan 2022 15:42:26 +0000", "Message-Id": "<20220110154226.1004602-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark the\n\tEmbedded Data stream as external", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Remove the code that marks the Embedded Data stream as external with the Unicam\nImage (RAW) stream. This was needed for legacy reasons when matching image and\nembedded buffers, but is not needed any more.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 168bbcef819c..a0cd501c8250 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -896,15 +896,6 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t\t\t\t\t<< format.toString();\n \t\t\treturn ret;\n \t\t}\n-\n-\t\t/*\n-\t\t * If a RAW/Bayer stream has been requested by the application,\n-\t\t * we must set both Unicam streams as external, even though the\n-\t\t * application may only request RAW frames. This is because we\n-\t\t * match timestamps on both streams to synchronise buffers.\n-\t\t */\n-\t\tif (rawStream)\n-\t\t\tdata->unicam_[Unicam::Embedded].setExternal(true);\n \t}\n \n \t/*\n", "prefixes": [ "libcamera-devel", "v1" ] }