From patchwork Mon Jan 10 15:42:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 15264 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 211D1BE080 for ; Mon, 10 Jan 2022 15:42:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4AEDF604F8; Mon, 10 Jan 2022 16:42:31 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="p8csNOS5"; dkim-atps=neutral Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F00A6021A for ; Mon, 10 Jan 2022 16:42:28 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id f141-20020a1c1f93000000b003497aec3f86so117219wmf.3 for ; Mon, 10 Jan 2022 07:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nM52PHBNGMvq/I2fAXzdv6QHNu1NzN1278BUFP6Lx6I=; b=p8csNOS5jJyzgNXd79IKspQDfhjjxQxhSdKieJBFaP9PqoDDMDmvNEy0Bqyk677nie WZqX7DsSxT5c3k5fbt2Kojk6MgzRTGhvgraoqNguUTc0E0HC/RABRizg0LWYgzp8U9+E US3XWsA4iWaESKH8/8soRviCtDHoFNoODDAevJwHzlmQp3EUJCiYL7v8EnAiKi4k2zjX bsZfSdIEYhW6dAs+UlOE1RVSGLqn7ECrGIVSymrt/UXheXT7pMvYySv3HKlm7AUnQ08g S8+Vl2ERSt9IiX3VnuVfgDUubV63udtZF8GQxKQyqqz39s7MKBSWaDry7WKlnGhPylZF TrLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nM52PHBNGMvq/I2fAXzdv6QHNu1NzN1278BUFP6Lx6I=; b=KS4TzllPRredzBb2Zg7c/sDfm/QXjUolHpPP20wGFmJkn8Pn8tYeaK6idrqoqAQqF+ 4P0B09W7wNUWUbO6nDDmzdPzO6SDR/fxkv3D/yTHUaPBiDASCJdV2iKR7VMQNNHjLt1C 4+3BHKxHSc5TbkG5AZhb0qm5gWJqdKP/mH1vURqkECnu1TQlGVcyqVuN/KdBbIVlQovs YijGYuhwFjhke6KwXiSQFT6FlsLzu/Uxi4TcKqzfDYXaZQ/YTqBETS4mx2uTsczzWQMK +cecyyv0+pBJBR1ZHuEuFGTpkaZkSnVDx0p+TbZiFl1XUhe4tSgOz7eEQKedBYIdthB0 KY8g== X-Gm-Message-State: AOAM532EUc9awUxoxz5pBIOn/AFgKZn+ZIISr1Gai1bGps5lRsNA45M0 2HxSgpFXJB3DLJLfwB1DPp6cS8dXTpAd7A== X-Google-Smtp-Source: ABdhPJzw6q5akKkb1ypqyGW7kScgoz74MfXUsmOwb7/1beTHrFtY/kLjq7uVwMOS4HAaFq2mkKPJKw== X-Received: by 2002:a1c:c917:: with SMTP id f23mr23133005wmb.10.1641829348426; Mon, 10 Jan 2022 07:42:28 -0800 (PST) Received: from naush-laptop.pitowers.org ([2a00:1098:3142:14:3222:bb03:1840:95be]) by smtp.gmail.com with ESMTPSA id b2sm7571200wrd.35.2022.01.10.07.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 07:42:28 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 10 Jan 2022 15:42:26 +0000 Message-Id: <20220110154226.1004602-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1] pipeline: raspberrypi: Do not mark the Embedded Data stream as external X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove the code that marks the Embedded Data stream as external with the Unicam Image (RAW) stream. This was needed for legacy reasons when matching image and embedded buffers, but is not needed any more. Signed-off-by: Naushir Patuck Reviewed-by: David Plowman Tested-by: David Plowman Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 168bbcef819c..a0cd501c8250 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -896,15 +896,6 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config) << format.toString(); return ret; } - - /* - * If a RAW/Bayer stream has been requested by the application, - * we must set both Unicam streams as external, even though the - * application may only request RAW frames. This is because we - * match timestamps on both streams to synchronise buffers. - */ - if (rawStream) - data->unicam_[Unicam::Embedded].setExternal(true); } /*