Patch Detail
Show a patch.
GET /api/patches/14993/?format=api
{ "id": 14993, "url": "https://patchwork.libcamera.org/api/patches/14993/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14993/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211202140317.3118364-6-hanlinchen@chromium.org>", "date": "2021-12-02T14:03:17", "name": "[libcamera-devel,v7,5/5] ipu3: ipa: Allow IPA to apply controls to the lens device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "225f181e93f87772d1079dbd132ceae360a150d8", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14993/mbox/", "series": [ { "id": 2804, "url": "https://patchwork.libcamera.org/api/series/2804/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2804", "date": "2021-12-02T14:03:12", "name": "Introduce Lens class and apply auto focus on ipu3", "version": 7, "mbox": "https://patchwork.libcamera.org/series/2804/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14993/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14993/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 506CFBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Dec 2021 14:03:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A66E60876;\n\tThu, 2 Dec 2021 15:03:37 +0100 (CET)", "from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45FEC605B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Dec 2021 15:03:36 +0100 (CET)", "by mail-pj1-x1036.google.com with SMTP id\n\tp18-20020a17090ad31200b001a78bb52876so2522021pju.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 02 Dec 2021 06:03:36 -0800 (PST)", "from localhost ([2401:fa00:1:10:9029:d68:4045:e723])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tb8sm3407187pfr.213.2021.12.02.06.03.33\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 02 Dec 2021 06:03:34 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Z+4vNwE1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=aQHpsPdta6ziFqfTvCAUcpIaejkMZEdSho4mOQlpNqA=;\n\tb=Z+4vNwE1tpzPQUW1+Ww+3+i7DQd7DeKkovbG2GhuTrXOcUlzPE/azIb7/JFnnWPBMN\n\tDlzwnZ18zC36ZVSH7meZc4QFOp37EK98DOjkBGzIZ4tJbeUnWBQhBdPEOtS30zxuGooc\n\tk3cfDBkH5wOXtLVNzT+J0mxwEXQYeb5DEpvPo=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=aQHpsPdta6ziFqfTvCAUcpIaejkMZEdSho4mOQlpNqA=;\n\tb=dOTaZ4dLISGLMKrFqYQifBL73aXmFk3bBnFwn7gqcp/dv/SNjQxb5tracukaMT5XUm\n\ttl5+2ijzuJUtK2RvoQmo23mwm4Ee/hr2z9lnTDduR/A4Ucr9sNmMKIA+yrWjJrw8fZkU\n\tEcy7kUUleBMnHNJNykzZ2W+BWzkqu4z8VRYrPjuAXCwf9i2SyTTld7xNrmhqk4+qnI3r\n\t2/4R8pO1wBRda3V8DAUepx2GTspcZTZTRN8Vb7CP3ETalsewV8IW9xCIIpy3Jd78u5yZ\n\tz8/yy00Mj4KL1Cm4rvxHOLvQFKJNJiaw16oVxS0aCdXbZ+d7o0f+2kvXXKgyqyMOqqQl\n\ts7iA==", "X-Gm-Message-State": "AOAM530NncpDmT0iYMhbxzYbFAkzmWg3/6/hjOwAcCa1nPdCR7NBgJ4b\n\tWLMbG+gz5Uww3N/Gfq632TOU4wU3LZFxuQ==", "X-Google-Smtp-Source": "ABdhPJy8441E0e4AYx5EzaJgHai/3U4p+AZCXne2aNvRdBmJFMGyErCDDJJhqHIlbVw6WcE07XQHag==", "X-Received": "by 2002:a17:90b:3908:: with SMTP id\n\tob8mr6233468pjb.57.1638453814647; \n\tThu, 02 Dec 2021 06:03:34 -0800 (PST)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Dec 2021 22:03:17 +0800", "Message-Id": "<20211202140317.3118364-6-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.34.1.400.ga245620fadb-goog", "In-Reply-To": "<20211202140317.3118364-1-hanlinchen@chromium.org>", "References": "<20211202140317.3118364-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 5/5] ipu3: ipa: Allow IPA to apply\n\tcontrols to the lens device", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Allow IPA to apply controls to the lens device.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex c65afdb2..d26c8a2e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -24,6 +24,7 @@\n #include <libcamera/stream.h>\n \n #include \"libcamera/internal/camera.h\"\n+#include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/delayed_controls.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n@@ -1238,8 +1239,16 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n {\n \tswitch (action.op) {\n \tcase ipa::ipu3::ActionSetSensorControls: {\n-\t\tconst ControlList &controls = action.sensorControls;\n-\t\tdelayedCtrls_->push(controls);\n+\t\tconst ControlList &sensorControls = action.sensorControls;\n+\t\tdelayedCtrls_->push(sensorControls);\n+\n+\t\tconst ControlList lensControls = action.lensControls;\n+\t\tconst ControlValue &focusValue =\n+\t\t\tlensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n+\n+\t\tCameraLens *lens = cio2_.sensor()->lens();\n+\t\tif (lens && !focusValue.isNone())\n+\t\t\tlens->setFocusPostion(focusValue.get<int32_t>());\n \t\tbreak;\n \t}\n \tcase ipa::ipu3::ActionParamFilled: {\n", "prefixes": [ "libcamera-devel", "v7", "5/5" ] }