Patch Detail
Show a patch.
GET /api/patches/14860/?format=api
{ "id": 14860, "url": "https://patchwork.libcamera.org/api/patches/14860/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14860/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211130033820.18235-6-laurent.pinchart@ideasonboard.com>", "date": "2021-11-30T03:38:03", "name": "[libcamera-devel,v4,05/22] test: Add UniqueFD test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "18dab4dfa2b85ebee53fcab0d4ab5be470a7a73a", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14860/mbox/", "series": [ { "id": 2776, "url": "https://patchwork.libcamera.org/api/series/2776/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2776", "date": "2021-11-30T03:37:58", "name": "libcamera: Introduce UniqueFD", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2776/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14860/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14860/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D1B8C324F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Nov 2021 03:39:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C28FE605C8;\n\tTue, 30 Nov 2021 04:38:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 801C8605BC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 04:38:50 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F5CF11C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Nov 2021 04:38:50 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n7kLiFvk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638243530;\n\tbh=gsMLigkFxA6J8JCH8Vhc7pqq5yQV0AU1tWI3szv0Ox8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=n7kLiFvkazB5Ei/jFRos210hRQp2ui9Fmye3OF3AV++qCyyRZ5UVGgAITeY38mjxq\n\teU1PcYCDvs10v6UEapOTZrjrffVoE5Y2bO8LepRxMU51JiSfP2lV6DQjP/tBuVSFrJ\n\tqdQsXA/jCu9JAzDl+v8RxXVdD4RE2aDpdtrtgGrg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Nov 2021 05:38:03 +0200", "Message-Id": "<20211130033820.18235-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>", "References": "<20211130033820.18235-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 05/22] test: Add UniqueFD test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a unit test to exercise the API of the UniqueFD class.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\n---\nChanges since v3:\n\n- Use override where necessary\n- Make createFd() private\n---\n test/meson.build | 1 +\n test/unique-fd.cpp | 220 +++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 221 insertions(+)\n create mode 100644 test/unique-fd.cpp", "diff": "diff --git a/test/meson.build b/test/meson.build\nindex d0466f17d7b6..42dfbc1f8ee9 100644\n--- a/test/meson.build\n+++ b/test/meson.build\n@@ -53,6 +53,7 @@ internal_tests = [\n ['threads', 'threads.cpp'],\n ['timer', 'timer.cpp'],\n ['timer-thread', 'timer-thread.cpp'],\n+ ['unique-fd', 'unique-fd.cpp'],\n ['utils', 'utils.cpp'],\n ]\n \ndiff --git a/test/unique-fd.cpp b/test/unique-fd.cpp\nnew file mode 100644\nindex 000000000000..eb3b591fec28\n--- /dev/null\n+++ b/test/unique-fd.cpp\n@@ -0,0 +1,220 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2021, Google Inc.\n+ *\n+ * unique-fd.cpp - UniqueFD test\n+ */\n+\n+#include <fcntl.h>\n+#include <iostream>\n+#include <sys/stat.h>\n+#include <sys/types.h>\n+#include <unistd.h>\n+\n+#include <libcamera/base/unique_fd.h>\n+#include <libcamera/base/utils.h>\n+\n+#include \"test.h\"\n+\n+using namespace libcamera;\n+using namespace std;\n+\n+class UniqueFDTest : public Test\n+{\n+protected:\n+\tint init() override\n+\t{\n+\t\treturn createFd();\n+\t}\n+\n+\tint run() override\n+\t{\n+\t\t/* Test creating empty UniqueFD. */\n+\t\tUniqueFD fd;\n+\n+\t\tif (fd.isValid() || fd.get() != -1) {\n+\t\t\tstd::cout << \"Failed fd check (default constructor)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test creating UniqueFD from numerical file descriptor. */\n+\t\tUniqueFD fd2(fd_);\n+\t\tif (!fd2.isValid() || fd2.get() != fd_) {\n+\t\t\tstd::cout << \"Failed fd check (fd constructor)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (fd constructor)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test move constructor. */\n+\t\tUniqueFD fd3(std::move(fd2));\n+\t\tif (!fd3.isValid() || fd3.get() != fd_) {\n+\t\t\tstd::cout << \"Failed fd check (move constructor)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (fd2.isValid() || fd2.get() != -1) {\n+\t\t\tstd::cout << \"Failed moved fd check (move constructor)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (move constructor)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test move assignment operator. */\n+\t\tfd = std::move(fd3);\n+\t\tif (!fd.isValid() || fd.get() != fd_) {\n+\t\t\tstd::cout << \"Failed fd check (move assignment)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (fd3.isValid() || fd3.get() != -1) {\n+\t\t\tstd::cout << \"Failed moved fd check (move assignment)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (move assignment)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test swapping. */\n+\t\tfd2.swap(fd);\n+\t\tif (!fd2.isValid() || fd2.get() != fd_) {\n+\t\t\tstd::cout << \"Failed fd check (swap)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (fd.isValid() || fd.get() != -1) {\n+\t\t\tstd::cout << \"Failed swapped fd check (swap)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (swap)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test release. */\n+\t\tint numFd = fd2.release();\n+\t\tif (fd2.isValid() || fd2.get() != -1) {\n+\t\t\tstd::cout << \"Failed fd check (release)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (numFd != fd_) {\n+\t\t\tstd::cout << \"Failed released fd check (release)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (release)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test reset assignment. */\n+\t\tfd.reset(numFd);\n+\t\tif (!fd.isValid() || fd.get() != fd_) {\n+\t\t\tstd::cout << \"Failed fd check (reset assignment)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (!isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (reset assignment)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test reset destruction. */\n+\t\tfd.reset();\n+\t\tif (fd.isValid() || fd.get() != -1) {\n+\t\t\tstd::cout << \"Failed fd check (reset destruction)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (reset destruction)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t/* Test destruction. */\n+\t\tif (createFd() == TestFail) {\n+\t\t\tstd::cout << \"Failed to recreate test fd\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\t{\n+\t\t\tUniqueFD fd4(fd_);\n+\t\t}\n+\n+\t\tif (isValidFd(fd_)) {\n+\t\t\tstd::cout << \"Failed fd validity (destruction)\"\n+\t\t\t\t << std::endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+\n+\tvoid cleanup() override\n+\t{\n+\t\tif (fd_ > 0)\n+\t\t\tclose(fd_);\n+\t}\n+\n+private:\n+\tint createFd()\n+\t{\n+\t\tfd_ = open(\"/tmp\", O_TMPFILE | O_RDWR, S_IRUSR | S_IWUSR);\n+\t\tif (fd_ < 0)\n+\t\t\treturn TestFail;\n+\n+\t\t/* Cache inode number of temp file. */\n+\t\tstruct stat s;\n+\t\tif (fstat(fd_, &s))\n+\t\t\treturn TestFail;\n+\n+\t\tinodeNr_ = s.st_ino;\n+\n+\t\treturn 0;\n+\t}\n+\n+\tbool isValidFd(int fd)\n+\t{\n+\t\tstruct stat s;\n+\t\tif (fstat(fd, &s))\n+\t\t\treturn false;\n+\n+\t\t/* Check that inode number matches cached temp file. */\n+\t\treturn s.st_ino == inodeNr_;\n+\t}\n+\n+\tint fd_;\n+\tino_t inodeNr_;\n+};\n+\n+TEST_REGISTER(UniqueFDTest)\n", "prefixes": [ "libcamera-devel", "v4", "05/22" ] }