From patchwork Tue Nov 30 03:38:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 14860 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5D1B8C324F for ; Tue, 30 Nov 2021 03:39:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C28FE605C8; Tue, 30 Nov 2021 04:38:59 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="n7kLiFvk"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 801C8605BC for ; Tue, 30 Nov 2021 04:38:50 +0100 (CET) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F5CF11C5 for ; Tue, 30 Nov 2021 04:38:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1638243530; bh=gsMLigkFxA6J8JCH8Vhc7pqq5yQV0AU1tWI3szv0Ox8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=n7kLiFvkazB5Ei/jFRos210hRQp2ui9Fmye3OF3AV++qCyyRZ5UVGgAITeY38mjxq eU1PcYCDvs10v6UEapOTZrjrffVoE5Y2bO8LepRxMU51JiSfP2lV6DQjP/tBuVSFrJ qdQsXA/jCu9JAzDl+v8RxXVdD4RE2aDpdtrtgGrg= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Nov 2021 05:38:03 +0200 Message-Id: <20211130033820.18235-6-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211130033820.18235-1-laurent.pinchart@ideasonboard.com> References: <20211130033820.18235-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 05/22] test: Add UniqueFD test X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a unit test to exercise the API of the UniqueFD class. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Hirokazu Honda --- Changes since v3: - Use override where necessary - Make createFd() private --- test/meson.build | 1 + test/unique-fd.cpp | 220 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 221 insertions(+) create mode 100644 test/unique-fd.cpp diff --git a/test/meson.build b/test/meson.build index d0466f17d7b6..42dfbc1f8ee9 100644 --- a/test/meson.build +++ b/test/meson.build @@ -53,6 +53,7 @@ internal_tests = [ ['threads', 'threads.cpp'], ['timer', 'timer.cpp'], ['timer-thread', 'timer-thread.cpp'], + ['unique-fd', 'unique-fd.cpp'], ['utils', 'utils.cpp'], ] diff --git a/test/unique-fd.cpp b/test/unique-fd.cpp new file mode 100644 index 000000000000..eb3b591fec28 --- /dev/null +++ b/test/unique-fd.cpp @@ -0,0 +1,220 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * Copyright (C) 2021, Google Inc. + * + * unique-fd.cpp - UniqueFD test + */ + +#include +#include +#include +#include +#include + +#include +#include + +#include "test.h" + +using namespace libcamera; +using namespace std; + +class UniqueFDTest : public Test +{ +protected: + int init() override + { + return createFd(); + } + + int run() override + { + /* Test creating empty UniqueFD. */ + UniqueFD fd; + + if (fd.isValid() || fd.get() != -1) { + std::cout << "Failed fd check (default constructor)" + << std::endl; + return TestFail; + } + + /* Test creating UniqueFD from numerical file descriptor. */ + UniqueFD fd2(fd_); + if (!fd2.isValid() || fd2.get() != fd_) { + std::cout << "Failed fd check (fd constructor)" + << std::endl; + return TestFail; + } + + if (!isValidFd(fd_)) { + std::cout << "Failed fd validity (fd constructor)" + << std::endl; + return TestFail; + } + + /* Test move constructor. */ + UniqueFD fd3(std::move(fd2)); + if (!fd3.isValid() || fd3.get() != fd_) { + std::cout << "Failed fd check (move constructor)" + << std::endl; + return TestFail; + } + + if (fd2.isValid() || fd2.get() != -1) { + std::cout << "Failed moved fd check (move constructor)" + << std::endl; + return TestFail; + } + + if (!isValidFd(fd_)) { + std::cout << "Failed fd validity (move constructor)" + << std::endl; + return TestFail; + } + + /* Test move assignment operator. */ + fd = std::move(fd3); + if (!fd.isValid() || fd.get() != fd_) { + std::cout << "Failed fd check (move assignment)" + << std::endl; + return TestFail; + } + + if (fd3.isValid() || fd3.get() != -1) { + std::cout << "Failed moved fd check (move assignment)" + << std::endl; + return TestFail; + } + + if (!isValidFd(fd_)) { + std::cout << "Failed fd validity (move assignment)" + << std::endl; + return TestFail; + } + + /* Test swapping. */ + fd2.swap(fd); + if (!fd2.isValid() || fd2.get() != fd_) { + std::cout << "Failed fd check (swap)" + << std::endl; + return TestFail; + } + + if (fd.isValid() || fd.get() != -1) { + std::cout << "Failed swapped fd check (swap)" + << std::endl; + return TestFail; + } + + if (!isValidFd(fd_)) { + std::cout << "Failed fd validity (swap)" + << std::endl; + return TestFail; + } + + /* Test release. */ + int numFd = fd2.release(); + if (fd2.isValid() || fd2.get() != -1) { + std::cout << "Failed fd check (release)" + << std::endl; + return TestFail; + } + + if (numFd != fd_) { + std::cout << "Failed released fd check (release)" + << std::endl; + return TestFail; + } + + if (!isValidFd(fd_)) { + std::cout << "Failed fd validity (release)" + << std::endl; + return TestFail; + } + + /* Test reset assignment. */ + fd.reset(numFd); + if (!fd.isValid() || fd.get() != fd_) { + std::cout << "Failed fd check (reset assignment)" + << std::endl; + return TestFail; + } + + if (!isValidFd(fd_)) { + std::cout << "Failed fd validity (reset assignment)" + << std::endl; + return TestFail; + } + + /* Test reset destruction. */ + fd.reset(); + if (fd.isValid() || fd.get() != -1) { + std::cout << "Failed fd check (reset destruction)" + << std::endl; + return TestFail; + } + + if (isValidFd(fd_)) { + std::cout << "Failed fd validity (reset destruction)" + << std::endl; + return TestFail; + } + + /* Test destruction. */ + if (createFd() == TestFail) { + std::cout << "Failed to recreate test fd" + << std::endl; + return TestFail; + } + + { + UniqueFD fd4(fd_); + } + + if (isValidFd(fd_)) { + std::cout << "Failed fd validity (destruction)" + << std::endl; + return TestFail; + } + + return TestPass; + } + + void cleanup() override + { + if (fd_ > 0) + close(fd_); + } + +private: + int createFd() + { + fd_ = open("/tmp", O_TMPFILE | O_RDWR, S_IRUSR | S_IWUSR); + if (fd_ < 0) + return TestFail; + + /* Cache inode number of temp file. */ + struct stat s; + if (fstat(fd_, &s)) + return TestFail; + + inodeNr_ = s.st_ino; + + return 0; + } + + bool isValidFd(int fd) + { + struct stat s; + if (fstat(fd, &s)) + return false; + + /* Check that inode number matches cached temp file. */ + return s.st_ino == inodeNr_; + } + + int fd_; + ino_t inodeNr_; +}; + +TEST_REGISTER(UniqueFDTest)