Patch Detail
Show a patch.
GET /api/patches/14546/?format=api
{ "id": 14546, "url": "https://patchwork.libcamera.org/api/patches/14546/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14546/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211111104908.295992-2-hanlinchen@chromium.org>", "date": "2021-11-11T10:49:03", "name": "[libcamera-devel,IPU3-IPA,v3,1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "35283964bcb66bd71089c6b8d35a7c4da5597353", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14546/mbox/", "series": [ { "id": 2711, "url": "https://patchwork.libcamera.org/api/series/2711/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2711", "date": "2021-11-11T10:49:02", "name": "*** Enhance image quality for IPU3 with Intel IPA ***", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2711/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14546/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14546/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A998BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Nov 2021 10:49:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0613B6034E;\n\tThu, 11 Nov 2021 11:49:33 +0100 (CET)", "from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com\n\t[IPv6:2607:f8b0:4864:20::1032])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE9A66032C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 11:49:30 +0100 (CET)", "by mail-pj1-x1032.google.com with SMTP id\n\tj6-20020a17090a588600b001a78a5ce46aso4264517pji.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 02:49:30 -0800 (PST)", "from localhost ([2401:fa00:1:10:3925:da9c:3049:be7a])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tmd6sm2148665pjb.22.2021.11.11.02.49.28\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 11 Nov 2021 02:49:28 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"I0/lVFwx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QzcjOG7A0t3KcNbyAQ/elM2/0txN25oL28rye8sRV2U=;\n\tb=I0/lVFwxP5zPlN59gObLHwOCtE8qYrzEyDV/91BldHzXNwEgNdaMXs2wJzG8WzivEr\n\t4nML0UaQpl1pArshH0bM2O/0ZIks7qRTMyVHxw2D11nZl5FSRMvD/NBpjgmvGafjDX/D\n\tlF2X3IR0uhw4ts1cjriyNhcq/VrezfpWfqES4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QzcjOG7A0t3KcNbyAQ/elM2/0txN25oL28rye8sRV2U=;\n\tb=yM73dMvW1Yc+jI366oIL8aYtMFCPKordqRz2wpo6ksGdXcZ/qWUSggQIEN8HypigwN\n\tJYFuRP03WrljoNw3jAmm6JmZhyTGlI99xZPrkIuO++LOIO7wFaB+Ot5DulqPkil4lHo+\n\tXwEkhCRb/cNM5sDyS63mKf9SaQXlYwpgMRoFgbsGrbEqDdDGKQ/3TrIdlDudnjlKbzhX\n\tM1NJZYIkStl0eQEr0/SpqbppA5Yab0DXDAbIFiZ4CEzi3Ow6Iif1u3+p/6f3gcFqzYY5\n\t2zhSaefBQ0V1mgq9WWbDzBQNiQfnvUJJmIDMID0SMsbUVkstFaTTCCJRp9mOityIBPAt\n\tuqfw==", "X-Gm-Message-State": "AOAM531Ib2pZt2SfMcqIJv2K8AeWvmZeAmRxJ0tXtn0w16VfLUZEqe9o\n\t3TUFdJyrLzJ0IBTth3h6Ji5Nx4IpcOh+dg==", "X-Google-Smtp-Source": "ABdhPJwhWpR472qKJvW1ac+4zKyEql7u2IX7PbI+nFA9tQhSQ6/X5mMQXTebiCca/Q1W7Y06IwXcfA==", "X-Received": "by 2002:a17:90a:ab17:: with SMTP id\n\tm23mr7265141pjq.194.1636627769342; \n\tThu, 11 Nov 2021 02:49:29 -0800 (PST)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Nov 2021 18:49:03 +0800", "Message-Id": "<20211111104908.295992-2-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc1.387.gb447b232ab-goog", "In-Reply-To": "<20211111104908.295992-1-hanlinchen@chromium.org>", "References": "<20211111104908.295992-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [IPU3-IPA PATCH v3 1/6] ipu3: Use\n\tia_aiq_frame_use_preview as default mode for AIQ", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The frame use mode is set according to Android Capture Intent in Intel\nHAL's implememtation. The current default mode ia_aiq_frame_use_still is\nonly used with the single capture request. For preview use case, it has\na hard time converging AE and AF smoothly. Change the default mode to\nia_aiq_frame_use_preview for better user experience.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n aiq/aiq_input_parameters.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\nindex 36e2b07..bc87b31 100644\n--- a/aiq/aiq_input_parameters.cpp\n+++ b/aiq/aiq_input_parameters.cpp\n@@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n {\n \t/*Ae Params */\n \taeInputParams.num_exposures = NUM_EXPOSURES;\n-\taeInputParams.frame_use = ia_aiq_frame_use_still;\n+\taeInputParams.frame_use = ia_aiq_frame_use_preview;\n \taeInputParams.flash_mode = ia_aiq_flash_mode_off;\n \taeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic;\n \taeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative;\n@@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \taeInputParams.manual_convergence_time = -1;\n \n \t/* AWB Params */\n-\tawbParams.frame_use = ia_aiq_frame_use_still;\n+\tawbParams.frame_use = ia_aiq_frame_use_preview;\n \tawbParams.scene_mode = ia_aiq_awb_operation_mode_auto;\n \tawbParams.manual_convergence_time = -1.0;\n \tawbParams.manual_cct_range = nullptr;\n@@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \n \t/* AF Params */\n \tafParams = {\n-\t\tia_aiq_frame_use_still, 0, 1500,\n+\t\tia_aiq_frame_use_preview, 0, 1500,\n \t\tia_aiq_af_operation_mode_auto,\n \t\tia_aiq_af_range_normal,\n \t\tia_aiq_af_metering_mode_auto,\n@@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \t/* GBCE Params */\n \tgbceParams.gbce_level = ia_aiq_gbce_level_bypass;\n \tgbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n-\tgbceParams.frame_use = ia_aiq_frame_use_still;\n+\tgbceParams.frame_use = ia_aiq_frame_use_preview;\n \tgbceParams.ev_shift = 0;\n \n \t/* SA Params */\n-\tsaParams.frame_use = ia_aiq_frame_use_still;\n+\tsaParams.frame_use = ia_aiq_frame_use_preview;\n }\n \n } /* namespace ipa::ipu3::aiq */\n", "prefixes": [ "libcamera-devel", "IPU3-IPA", "v3", "1/6" ] }