From patchwork Thu Nov 11 10:49:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanlin Chen X-Patchwork-Id: 14546 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4A998BDB1C for ; Thu, 11 Nov 2021 10:49:33 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 0613B6034E; Thu, 11 Nov 2021 11:49:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="I0/lVFwx"; dkim-atps=neutral Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EE9A66032C for ; Thu, 11 Nov 2021 11:49:30 +0100 (CET) Received: by mail-pj1-x1032.google.com with SMTP id j6-20020a17090a588600b001a78a5ce46aso4264517pji.0 for ; Thu, 11 Nov 2021 02:49:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QzcjOG7A0t3KcNbyAQ/elM2/0txN25oL28rye8sRV2U=; b=I0/lVFwxP5zPlN59gObLHwOCtE8qYrzEyDV/91BldHzXNwEgNdaMXs2wJzG8WzivEr 4nML0UaQpl1pArshH0bM2O/0ZIks7qRTMyVHxw2D11nZl5FSRMvD/NBpjgmvGafjDX/D lF2X3IR0uhw4ts1cjriyNhcq/VrezfpWfqES4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QzcjOG7A0t3KcNbyAQ/elM2/0txN25oL28rye8sRV2U=; b=yM73dMvW1Yc+jI366oIL8aYtMFCPKordqRz2wpo6ksGdXcZ/qWUSggQIEN8HypigwN JYFuRP03WrljoNw3jAmm6JmZhyTGlI99xZPrkIuO++LOIO7wFaB+Ot5DulqPkil4lHo+ XwEkhCRb/cNM5sDyS63mKf9SaQXlYwpgMRoFgbsGrbEqDdDGKQ/3TrIdlDudnjlKbzhX M1NJZYIkStl0eQEr0/SpqbppA5Yab0DXDAbIFiZ4CEzi3Ow6Iif1u3+p/6f3gcFqzYY5 2zhSaefBQ0V1mgq9WWbDzBQNiQfnvUJJmIDMID0SMsbUVkstFaTTCCJRp9mOityIBPAt uqfw== X-Gm-Message-State: AOAM531Ib2pZt2SfMcqIJv2K8AeWvmZeAmRxJ0tXtn0w16VfLUZEqe9o 3TUFdJyrLzJ0IBTth3h6Ji5Nx4IpcOh+dg== X-Google-Smtp-Source: ABdhPJwhWpR472qKJvW1ac+4zKyEql7u2IX7PbI+nFA9tQhSQ6/X5mMQXTebiCca/Q1W7Y06IwXcfA== X-Received: by 2002:a17:90a:ab17:: with SMTP id m23mr7265141pjq.194.1636627769342; Thu, 11 Nov 2021 02:49:29 -0800 (PST) Received: from localhost ([2401:fa00:1:10:3925:da9c:3049:be7a]) by smtp.gmail.com with UTF8SMTPSA id md6sm2148665pjb.22.2021.11.11.02.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 02:49:28 -0800 (PST) From: Han-Lin Chen To: libcamera-devel@lists.libcamera.org Date: Thu, 11 Nov 2021 18:49:03 +0800 Message-Id: <20211111104908.295992-2-hanlinchen@chromium.org> X-Mailer: git-send-email 2.34.0.rc1.387.gb447b232ab-goog In-Reply-To: <20211111104908.295992-1-hanlinchen@chromium.org> References: <20211111104908.295992-1-hanlinchen@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [IPU3-IPA PATCH v3 1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The frame use mode is set according to Android Capture Intent in Intel HAL's implememtation. The current default mode ia_aiq_frame_use_still is only used with the single capture request. For preview use case, it has a hard time converging AE and AF smoothly. Change the default mode to ia_aiq_frame_use_preview for better user experience. Signed-off-by: Han-Lin Chen Reviewed-by: Umang Jain Reviewed-by: Kieran Bingham --- aiq/aiq_input_parameters.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp index 36e2b07..bc87b31 100644 --- a/aiq/aiq_input_parameters.cpp +++ b/aiq/aiq_input_parameters.cpp @@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults() { /*Ae Params */ aeInputParams.num_exposures = NUM_EXPOSURES; - aeInputParams.frame_use = ia_aiq_frame_use_still; + aeInputParams.frame_use = ia_aiq_frame_use_preview; aeInputParams.flash_mode = ia_aiq_flash_mode_off; aeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic; aeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative; @@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults() aeInputParams.manual_convergence_time = -1; /* AWB Params */ - awbParams.frame_use = ia_aiq_frame_use_still; + awbParams.frame_use = ia_aiq_frame_use_preview; awbParams.scene_mode = ia_aiq_awb_operation_mode_auto; awbParams.manual_convergence_time = -1.0; awbParams.manual_cct_range = nullptr; @@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults() /* AF Params */ afParams = { - ia_aiq_frame_use_still, 0, 1500, + ia_aiq_frame_use_preview, 0, 1500, ia_aiq_af_operation_mode_auto, ia_aiq_af_range_normal, ia_aiq_af_metering_mode_auto, @@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults() /* GBCE Params */ gbceParams.gbce_level = ia_aiq_gbce_level_bypass; gbceParams.tone_map_level = ia_aiq_tone_map_level_default; - gbceParams.frame_use = ia_aiq_frame_use_still; + gbceParams.frame_use = ia_aiq_frame_use_preview; gbceParams.ev_shift = 0; /* SA Params */ - saParams.frame_use = ia_aiq_frame_use_still; + saParams.frame_use = ia_aiq_frame_use_preview; } } /* namespace ipa::ipu3::aiq */