Patch Detail
Show a patch.
GET /api/patches/14350/?format=api
{ "id": 14350, "url": "https://patchwork.libcamera.org/api/patches/14350/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14350/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211026112340.110169-18-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-10-26T11:23:38", "name": "[libcamera-devel,v5,17/19] ipa: ipu3: Implement an empty stop() function", "commit_ref": "f79f7331cdd99839e33cd28512279ad382feda1c", "pull_url": null, "state": "accepted", "archived": false, "hash": "febed5f87651e656784038ad04c743c606ce08f9", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14350/mbox/", "series": [ { "id": 2658, "url": "https://patchwork.libcamera.org/api/series/2658/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2658", "date": "2021-10-26T11:23:21", "name": "Document IPU3 IPA", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2658/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14350/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14350/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EAB62BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Oct 2021 11:24:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A0CE164885;\n\tTue, 26 Oct 2021 13:24:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 237416488F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Oct 2021 13:23:48 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:dce3:eb54:18d7:6f3d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C30823F0;\n\tTue, 26 Oct 2021 13:23:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aIykpiR9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1635247427;\n\tbh=onf/vbo0mNGwxIM/y0dDxOjuPvjc9jWislN3kdAmCq0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aIykpiR9nOck/Or62x2dSYmln4f9gfnf516GZypX3d8qOjghYOIoaXxMFfYYSPQ6l\n\tjSNPTygaktQsAzrzRu93cb4aWZ+WNnTn8JUknl4ZzI3w/4ZJA/kG+c8d81GNmfqg0f\n\ttp0ciCI1R3XEIbQN8PeFmMUJCip71hZPEVrzwSbg=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Oct 2021 13:23:38 +0200", "Message-Id": "<20211026112340.110169-18-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com>", "References": "<20211026112340.110169-1-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 17/19] ipa: ipu3: Implement an empty\n\tstop() function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While the stop() function does not currently perform any action, it forms\npart of the IPA interface and is a public function in the class.\n\nPromote it to a full (but basic) function implementation and begin the\ndocumentation accordingly so that there is an appropriate stub to\nperform stop operations if they come up.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex a10fdd4a..5c51607d 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -135,7 +135,7 @@ public:\n \t\t ControlInfoMap *ipaControls) override;\n \n \tint start() override;\n-\tvoid stop() override {}\n+\tvoid stop() override;\n \n \tint configure(const IPAConfigInfo &configInfo,\n \t\t ControlInfoMap *ipaControls) override;\n@@ -323,6 +323,13 @@ int IPAIPU3::start()\n \treturn 0;\n }\n \n+/**\n+ * \\brief Ensure that all processing has completed\n+ */\n+void IPAIPU3::stop()\n+{\n+}\n+\n /**\n * \\brief Calculate a grid for the AWB statistics\n *\n", "prefixes": [ "libcamera-devel", "v5", "17/19" ] }