[libcamera-devel,v5,17/19] ipa: ipu3: Implement an empty stop() function
diff mbox series

Message ID 20211026112340.110169-18-jeanmichel.hautbois@ideasonboard.com
State Accepted
Commit f79f7331cdd99839e33cd28512279ad382feda1c
Headers show
Series
  • Document IPU3 IPA
Related show

Commit Message

Jean-Michel Hautbois Oct. 26, 2021, 11:23 a.m. UTC
While the stop() function does not currently perform any action, it forms
part of the IPA interface and is a public function in the class.

Promote it to a full (but basic) function implementation and begin the
documentation accordingly so that there is an appropriate stub to
perform stop operations if they come up.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/ipa/ipu3/ipu3.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Patch
diff mbox series

diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
index a10fdd4a..5c51607d 100644
--- a/src/ipa/ipu3/ipu3.cpp
+++ b/src/ipa/ipu3/ipu3.cpp
@@ -135,7 +135,7 @@  public:
 		 ControlInfoMap *ipaControls) override;
 
 	int start() override;
-	void stop() override {}
+	void stop() override;
 
 	int configure(const IPAConfigInfo &configInfo,
 		      ControlInfoMap *ipaControls) override;
@@ -323,6 +323,13 @@  int IPAIPU3::start()
 	return 0;
 }
 
+/**
+ * \brief Ensure that all processing has completed
+ */
+void IPAIPU3::stop()
+{
+}
+
 /**
  * \brief Calculate a grid for the AWB statistics
  *