Patch Detail
Show a patch.
GET /api/patches/14041/?format=api
{ "id": 14041, "url": "https://patchwork.libcamera.org/api/patches/14041/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14041/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211004135207.2936-1-david.plowman@raspberrypi.com>", "date": "2021-10-04T13:52:07", "name": "[libcamera-devel] pipeline: raspberrypi: Create empty control list correctly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "afb15390d72b8cbbe9edc73fd86ba440ecdebb2e", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14041/mbox/", "series": [ { "id": 2599, "url": "https://patchwork.libcamera.org/api/series/2599/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2599", "date": "2021-10-04T13:52:07", "name": "[libcamera-devel] pipeline: raspberrypi: Create empty control list correctly", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2599/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14041/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14041/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D728BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 4 Oct 2021 13:52:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88D0069189;\n\tMon, 4 Oct 2021 15:52:13 +0200 (CEST)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6D846023F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 4 Oct 2021 15:52:11 +0200 (CEST)", "by mail-wm1-x335.google.com with SMTP id v127so13501900wme.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 04 Oct 2021 06:52:11 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:1ce1:9965:4328:89c4])\n\tby smtp.gmail.com with ESMTPSA id\n\tm4sm16336620wrx.81.2021.10.04.06.52.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Oct 2021 06:52:10 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SqevY2rA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=mID5noverTM/AefZdsKJ0ASNTEJFQO0KBoFGnYyDzjw=;\n\tb=SqevY2rAWzv/WbqDQTI5n+s+2hfs0D2ox/k8W+x3MlqGiUZAuF2LL+ajAmzdrCPhi3\n\tYF2gXkthnUe2RJu+nuvn9RAe+/Q/5eDMbwMzBBB5ZD+bqiOeSPO78bkvq3vWXtZFBJ/+\n\tj4tID2AOyMGubUpG3VHpkWamt5RmhxNzmPXIA29XEi6nee90toGprsGYegNLrf3ipA1b\n\t+qlNpvKAv1ZMlAA+nhNg5TZSGL/+IbGx+k5xlXwvLIzgNucSdyTax/1qvTk8o7U68HMi\n\tNMeht1qsSjUXKK8kfhq05A8fV4vD7IFTBfYPqlKp+BFl22h807IhPuECMpdvUVTxhL6d\n\tMvdA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=mID5noverTM/AefZdsKJ0ASNTEJFQO0KBoFGnYyDzjw=;\n\tb=TraNvJ22o+PbvQQvWA6scskA/KBUJ168I9WrrYCC/WkdiThG3OVhxA0gcG7REXVMBZ\n\tsZqInloT6fVQ7GgjuT0voChsGNQVUhjh23xAwuvMd55f2oY027JG+/20Ljht3wbMh66d\n\tVe1Ec1f+Hh0mFdoxFeCLSMMJGa2lyqxCFqYDn5Mrfe4ktCDlj+OiPMcBdtWVW5NBmbU9\n\tPBm/12lfX8SdV+mAlKBwKpOjZBpXCChC1bzS2B2/B78ds0Dqteq7c8DDylfWKhMLge+P\n\tTMmE3xw2GTSQgeCu/+S6g8dx0JR7qhz+tGH15YLHG8WLL4hloagO59+YNdmo//bN/Dke\n\tdv/Q==", "X-Gm-Message-State": "AOAM533xAKZBv4n2jM7DywYNBXQj0J0FByxqFOtqMHpjnoiqygU8RuFF\n\tJauoP+8Oka0YoIeQ2aaqjaLbqQCFPPhpnOxl", "X-Google-Smtp-Source": "ABdhPJxEiTE3msReR+xIiywI0Pe8Qtl8BesFCHQ2ckBZ+E7Mmw1oAZDlBNp9oWHM5MvyjLMlq37bvg==", "X-Received": "by 2002:a1c:7706:: with SMTP id t6mr7241332wmi.134.1633355531092;\n\tMon, 04 Oct 2021 06:52:11 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 4 Oct 2021 14:52:07 +0100", "Message-Id": "<20211004135207.2936-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] pipeline: raspberrypi: Create empty\n\tcontrol list correctly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the start() method is supplied with a NULL list of controls, we\nsend an empty control list to the IPA. When the IPA is running in\nisolated mode the control list goes through the data serializer, for\nwhich it must be marked correctly as a list of \"controls::controls\",\notherwise the IPA process will abort.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 0bdfa727..87836996 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -825,7 +825,8 @@ int PipelineHandlerRPi::start(Camera *camera, const ControlList *controls)\n \n \t/* Start the IPA. */\n \tipa::RPi::StartConfig startConfig;\n-\tdata->ipa_->start(controls ? *controls : ControlList{}, &startConfig);\n+\tControlList emptyControls(controls::controls);\n+\tdata->ipa_->start(controls ? *controls : emptyControls, &startConfig);\n \n \t/* Apply any gain/exposure settings that the IPA may have passed back. */\n \tif (!startConfig.controls.empty())\n", "prefixes": [ "libcamera-devel" ] }