From patchwork Mon Oct 4 13:52:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 14041 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2D728BDC71 for ; Mon, 4 Oct 2021 13:52:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 88D0069189; Mon, 4 Oct 2021 15:52:13 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="SqevY2rA"; dkim-atps=neutral Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B6D846023F for ; Mon, 4 Oct 2021 15:52:11 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id v127so13501900wme.5 for ; Mon, 04 Oct 2021 06:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mID5noverTM/AefZdsKJ0ASNTEJFQO0KBoFGnYyDzjw=; b=SqevY2rAWzv/WbqDQTI5n+s+2hfs0D2ox/k8W+x3MlqGiUZAuF2LL+ajAmzdrCPhi3 YF2gXkthnUe2RJu+nuvn9RAe+/Q/5eDMbwMzBBB5ZD+bqiOeSPO78bkvq3vWXtZFBJ/+ j4tID2AOyMGubUpG3VHpkWamt5RmhxNzmPXIA29XEi6nee90toGprsGYegNLrf3ipA1b +qlNpvKAv1ZMlAA+nhNg5TZSGL/+IbGx+k5xlXwvLIzgNucSdyTax/1qvTk8o7U68HMi NMeht1qsSjUXKK8kfhq05A8fV4vD7IFTBfYPqlKp+BFl22h807IhPuECMpdvUVTxhL6d MvdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mID5noverTM/AefZdsKJ0ASNTEJFQO0KBoFGnYyDzjw=; b=TraNvJ22o+PbvQQvWA6scskA/KBUJ168I9WrrYCC/WkdiThG3OVhxA0gcG7REXVMBZ sZqInloT6fVQ7GgjuT0voChsGNQVUhjh23xAwuvMd55f2oY027JG+/20Ljht3wbMh66d Ve1Ec1f+Hh0mFdoxFeCLSMMJGa2lyqxCFqYDn5Mrfe4ktCDlj+OiPMcBdtWVW5NBmbU9 PBm/12lfX8SdV+mAlKBwKpOjZBpXCChC1bzS2B2/B78ds0Dqteq7c8DDylfWKhMLge+P TMmE3xw2GTSQgeCu/+S6g8dx0JR7qhz+tGH15YLHG8WLL4hloagO59+YNdmo//bN/Dke dv/Q== X-Gm-Message-State: AOAM533xAKZBv4n2jM7DywYNBXQj0J0FByxqFOtqMHpjnoiqygU8RuFF JauoP+8Oka0YoIeQ2aaqjaLbqQCFPPhpnOxl X-Google-Smtp-Source: ABdhPJxEiTE3msReR+xIiywI0Pe8Qtl8BesFCHQ2ckBZ+E7Mmw1oAZDlBNp9oWHM5MvyjLMlq37bvg== X-Received: by 2002:a1c:7706:: with SMTP id t6mr7241332wmi.134.1633355531092; Mon, 04 Oct 2021 06:52:11 -0700 (PDT) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:1ce1:9965:4328:89c4]) by smtp.gmail.com with ESMTPSA id m4sm16336620wrx.81.2021.10.04.06.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 06:52:10 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 4 Oct 2021 14:52:07 +0100 Message-Id: <20211004135207.2936-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] pipeline: raspberrypi: Create empty control list correctly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When the start() method is supplied with a NULL list of controls, we send an empty control list to the IPA. When the IPA is running in isolated mode the control list goes through the data serializer, for which it must be marked correctly as a list of "controls::controls", otherwise the IPA process will abort. Signed-off-by: David Plowman Reviewed-by: Laurent Pinchart Reviewed-by: Paul Elder --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 0bdfa727..87836996 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -825,7 +825,8 @@ int PipelineHandlerRPi::start(Camera *camera, const ControlList *controls) /* Start the IPA. */ ipa::RPi::StartConfig startConfig; - data->ipa_->start(controls ? *controls : ControlList{}, &startConfig); + ControlList emptyControls(controls::controls); + data->ipa_->start(controls ? *controls : emptyControls, &startConfig); /* Apply any gain/exposure settings that the IPA may have passed back. */ if (!startConfig.controls.empty())