Patch Detail
Show a patch.
GET /api/patches/13954/?format=api
{ "id": 13954, "url": "https://patchwork.libcamera.org/api/patches/13954/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13954/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210927183405.64087-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-09-27T18:34:06", "name": "[libcamera-devel] fixup! ipa: ipu3: Rename IspStatsRegion to Accumulator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "16872db1a9d48ef809cdd90e3948dec87644cd4f", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13954/mbox/", "series": [ { "id": 2575, "url": "https://patchwork.libcamera.org/api/series/2575/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2575", "date": "2021-09-27T18:34:06", "name": "[libcamera-devel] fixup! ipa: ipu3: Rename IspStatsRegion to Accumulator", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2575/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13954/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13954/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DB5BBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 27 Sep 2021 18:35:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EC186918B;\n\tMon, 27 Sep 2021 20:35:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28B406012C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 27 Sep 2021 20:35:02 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:4903:bf5e:9282:5164])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A65BCE81;\n\tMon, 27 Sep 2021 20:35:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d8jeuZaT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632767701;\n\tbh=ZVapyCyN8ClKAnoagVobaA9w+FOr7FNsUcqeMDqy3fo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=d8jeuZaT0XM/LB+fyTcMwgUoBSYANdvUx5GJYSTHKvonD0T7e33aDwFWwvLdCwm5W\n\tXVIGZUhNC+GVwY8UtpMJotveEdlNqCyEa2QcNMr7qAYN1sz3SWdY3EtBBSWBr27/gu\n\tw0tDBW/xgOvOQ/RSDOiX0JtkzLlZjN2SNaUTycSI=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 27 Sep 2021 20:34:06 +0200", "Message-Id": "<20210927183405.64087-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210923081625.60276-3-jeanmichel.hautbois@ideasonboard.com>", "References": "<20210923081625.60276-3-jeanmichel.hautbois@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] fixup! ipa: ipu3: Rename IspStatsRegion\n\tto Accumulator", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "JM,\n\nYou may also want this fixup as the max cells in width is 80 ;-).\n\n---\n src/ipa/ipu3/algorithms/awb.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\nindex 06570b60..67cf3a55 100644\n--- a/src/ipa/ipu3/algorithms/awb.cpp\n+++ b/src/ipa/ipu3/algorithms/awb.cpp\n@@ -26,8 +26,8 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n * - Cells are defined in Pixels\n * - Zones are defined in Cells\n *\n- * 81 cells\n- * /───────────── 1296 pixels ───────────\\\n+ * 80 cells\n+ * /───────────── 1280 pixels ───────────\\\n * 16 zones\n * 16\n * ┌────┬────┬────┬────┬────┬─ ──────┬────┐ \\\n@@ -55,7 +55,7 @@ static constexpr uint32_t kMinGreenLevelInZone = 32;\n * └────┴────┴────┴────┴────┴─ ──────┴────┘ /\n *\n * The algorithm works with a fixed number of zones \\a kAwbStatsSizeX x\n- * \\a kAwbStatsSizeY. For example, a frame of 1296x720 is divided into 81x45\n+ * \\a kAwbStatsSizeY. For example, a frame of 1280x720 is divided into 80x45\n * cells of [16x16] pixels. In the case of \\a kAwbStatsSizeX=16 and\n * \\a kAwbStatsSizeY=12 the zones are made of [5x4] cells. The cells are\n * left-aligned and calculated by IPAIPU3::calculateBdsGrid().\n", "prefixes": [ "libcamera-devel" ] }