From patchwork Mon Sep 27 18:34:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 13954 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7DB5BBDC71 for ; Mon, 27 Sep 2021 18:35:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7EC186918B; Mon, 27 Sep 2021 20:35:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="d8jeuZaT"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 28B406012C for ; Mon, 27 Sep 2021 20:35:02 +0200 (CEST) Received: from tatooine.ideasonboard.com (unknown [IPv6:2a01:e0a:169:7140:4903:bf5e:9282:5164]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A65BCE81; Mon, 27 Sep 2021 20:35:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632767701; bh=ZVapyCyN8ClKAnoagVobaA9w+FOr7FNsUcqeMDqy3fo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d8jeuZaT0XM/LB+fyTcMwgUoBSYANdvUx5GJYSTHKvonD0T7e33aDwFWwvLdCwm5W XVIGZUhNC+GVwY8UtpMJotveEdlNqCyEa2QcNMr7qAYN1sz3SWdY3EtBBSWBr27/gu w0tDBW/xgOvOQ/RSDOiX0JtkzLlZjN2SNaUTycSI= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Mon, 27 Sep 2021 20:34:06 +0200 Message-Id: <20210927183405.64087-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210923081625.60276-3-jeanmichel.hautbois@ideasonboard.com> References: <20210923081625.60276-3-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] fixup! ipa: ipu3: Rename IspStatsRegion to Accumulator X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" JM, You may also want this fixup as the max cells in width is 80 ;-). --- src/ipa/ipu3/algorithms/awb.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 06570b60..67cf3a55 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -26,8 +26,8 @@ static constexpr uint32_t kMinGreenLevelInZone = 32; * - Cells are defined in Pixels * - Zones are defined in Cells * - * 81 cells - * /───────────── 1296 pixels ───────────\ + * 80 cells + * /───────────── 1280 pixels ───────────\ * 16 zones * 16 * ┌────┬────┬────┬────┬────┬─ ──────┬────┐ \ @@ -55,7 +55,7 @@ static constexpr uint32_t kMinGreenLevelInZone = 32; * └────┴────┴────┴────┴────┴─ ──────┴────┘ / * * The algorithm works with a fixed number of zones \a kAwbStatsSizeX x - * \a kAwbStatsSizeY. For example, a frame of 1296x720 is divided into 81x45 + * \a kAwbStatsSizeY. For example, a frame of 1280x720 is divided into 80x45 * cells of [16x16] pixels. In the case of \a kAwbStatsSizeX=16 and * \a kAwbStatsSizeY=12 the zones are made of [5x4] cells. The cells are * left-aligned and calculated by IPAIPU3::calculateBdsGrid().