Patch Detail
Show a patch.
GET /api/patches/13528/?format=api
{ "id": 13528, "url": "https://patchwork.libcamera.org/api/patches/13528/?format=api", "web_url": "https://patchwork.libcamera.org/patch/13528/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210827062521.2541170-1-paul.elder@ideasonboard.com>", "date": "2021-08-27T06:25:20", "name": "[libcamera-devel,1/2] v4l2: v4l2_compat_manager: Don't print \"camera not found\" on openat()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9ecb60fefe56d4f4a229e415b0f400827d2db82e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/13528/mbox/", "series": [ { "id": 2403, "url": "https://patchwork.libcamera.org/api/series/2403/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2403", "date": "2021-08-27T06:25:20", "name": "[libcamera-devel,1/2] v4l2: v4l2_compat_manager: Don't print \"camera not found\" on openat()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2403/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/13528/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/13528/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44F9BBD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 Aug 2021 06:25:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BC7768934;\n\tFri, 27 Aug 2021 08:25:36 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A91660288\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 Aug 2021 08:25:34 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5AC95A1;\n\tFri, 27 Aug 2021 08:25:32 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cncI2QZO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630045534;\n\tbh=YKSQ0NKUrmjNT1dOON/tsAd+ZIp8PyLk6iJT24C/XWk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=cncI2QZOGw9xyu8WNpEZIhVe1FJVMq9BYuE7RBe7AJCC/mp7TypGblU1p+WzYBGJs\n\teBTeLmbE5iOgD3DO1d5S9+OCcno2M5hlfKnUJ1HR43Xk2n0VdZvpY4HiTLUZXEgtgd\n\tR7Zd0kllevT13WdjN7IGwu2/GN9cXlCmNLAhmkVs=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 27 Aug 2021 15:25:20 +0900", "Message-Id": "<20210827062521.2541170-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] v4l2: v4l2_compat_manager: Don't\n\tprint \"camera not found\" on openat()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some applications (like Firefox) run open() many times on video device\nnodes. This may lead to user confusion when they see \"INFO V4L2Compat\nv4l2_compat_manager.cpp:146 No camera found for /dev/videoX\" over and\nover again.\n\nLower the log level to debug so that we can still get this information\non debug, and so users won't see it all the time.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/v4l2/v4l2_compat_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\nindex e566125a..690a191f 100644\n--- a/src/v4l2/v4l2_compat_manager.cpp\n+++ b/src/v4l2/v4l2_compat_manager.cpp\n@@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod\n \n \tret = getCameraIndex(fd);\n \tif (ret < 0) {\n-\t\tLOG(V4L2Compat, Info) << \"No camera found for \" << path;\n+\t\tLOG(V4L2Compat, Debug) << \"No camera found for \" << path;\n \t\treturn fd;\n \t}\n \n", "prefixes": [ "libcamera-devel", "1/2" ] }