Message ID | 20210827062521.2541170-1-paul.elder@ideasonboard.com |
---|---|
State | Superseded |
Headers | show |
Series |
|
Related | show |
On 27/08/2021 07:25, Paul Elder wrote: > Some applications (like Firefox) run open() many times on video device > nodes. This may lead to user confusion when they see "INFO V4L2Compat > v4l2_compat_manager.cpp:146 No camera found for /dev/videoX" over and > over again. > > Lower the log level to debug so that we can still get this information > on debug, and so users won't see it all the time. Aha, I have the same change in my local tree! :-) Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/v4l2/v4l2_compat_manager.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp > index e566125a..690a191f 100644 > --- a/src/v4l2/v4l2_compat_manager.cpp > +++ b/src/v4l2/v4l2_compat_manager.cpp > @@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod > > ret = getCameraIndex(fd); > if (ret < 0) { > - LOG(V4L2Compat, Info) << "No camera found for " << path; > + LOG(V4L2Compat, Debug) << "No camera found for " << path; > return fd; > } > >
Hi Paul, Thank you for the patch. On Fri, Aug 27, 2021 at 03:25:20PM +0900, Paul Elder wrote: > Some applications (like Firefox) run open() many times on video device > nodes. This may lead to user confusion when they see "INFO V4L2Compat > v4l2_compat_manager.cpp:146 No camera found for /dev/videoX" over and > over again. > > Lower the log level to debug so that we can still get this information > on debug, and so users won't see it all the time. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/v4l2/v4l2_compat_manager.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp > index e566125a..690a191f 100644 > --- a/src/v4l2/v4l2_compat_manager.cpp > +++ b/src/v4l2/v4l2_compat_manager.cpp > @@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod > > ret = getCameraIndex(fd); > if (ret < 0) { > - LOG(V4L2Compat, Info) << "No camera found for " << path; > + LOG(V4L2Compat, Debug) << "No camera found for " << path; > return fd; > } >
diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp index e566125a..690a191f 100644 --- a/src/v4l2/v4l2_compat_manager.cpp +++ b/src/v4l2/v4l2_compat_manager.cpp @@ -143,7 +143,7 @@ int V4L2CompatManager::openat(int dirfd, const char *path, int oflag, mode_t mod ret = getCameraIndex(fd); if (ret < 0) { - LOG(V4L2Compat, Info) << "No camera found for " << path; + LOG(V4L2Compat, Debug) << "No camera found for " << path; return fd; }
Some applications (like Firefox) run open() many times on video device nodes. This may lead to user confusion when they see "INFO V4L2Compat v4l2_compat_manager.cpp:146 No camera found for /dev/videoX" over and over again. Lower the log level to debug so that we can still get this information on debug, and so users won't see it all the time. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- src/v4l2/v4l2_compat_manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)