Patch Detail
Show a patch.
GET /api/patches/12945/?format=api
{ "id": 12945, "url": "https://patchwork.libcamera.org/api/patches/12945/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12945/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210714130232.63284-1-jeanmichel.hautbois@ideasonboard.com>", "date": "2021-07-14T13:02:32", "name": "[libcamera-devel,v2] ipa: raspberrypi: Remove unused MetadataPtr", "commit_ref": "35e23837fab8e7837254db32e6a76ddbe4453189", "pull_url": null, "state": "accepted", "archived": false, "hash": "dc5fd75312bec3ac89c8a9e6b510b51baf049b60", "submitter": { "id": 75, "url": "https://patchwork.libcamera.org/api/people/75/?format=api", "name": "Jean-Michel Hautbois", "email": "jeanmichel.hautbois@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12945/mbox/", "series": [ { "id": 2231, "url": "https://patchwork.libcamera.org/api/series/2231/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2231", "date": "2021-07-14T13:02:32", "name": "[libcamera-devel,v2] ipa: raspberrypi: Remove unused MetadataPtr", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2231/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12945/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12945/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6609C3225\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jul 2021 13:02:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EA8A68525;\n\tWed, 14 Jul 2021 15:02:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8FD868503\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jul 2021 15:02:42 +0200 (CEST)", "from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e67c:9465:36df:f139])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B02ECC;\n\tWed, 14 Jul 2021 15:02:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"veHFvfUg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1626267762;\n\tbh=IgpbQIUb0cb2ZeMgnvRtZ9ZFvZVg9o53UurvYm2xGNI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=veHFvfUg7hT/Bk/FB5I7Zp9V5kwAbNE/Q1izYlWHRNzKf7+jRj4O52DQoYAHuLkZt\n\trJPSDz1vFoI0StvCpd24OuevibC78tHLy/sY2kLhXGfiSFlo9q8FqPffjvbw7WR2mc\n\tZd2EECDxl1eCp3uBGf5YFqlTq4AYr2ZV8B83f6+w=", "From": "Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 14 Jul 2021 15:02:32 +0200", "Message-Id": "<20210714130232.63284-1-jeanmichel.hautbois@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] ipa: raspberrypi: Remove unused\n\tMetadataPtr", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Metadata class defines a shared_ptr named MetadataPtr. It is not\nused anywhere in the source code, so remove it.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/metadata.hpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp\nindex fd6aac88..51e576cf 100644\n--- a/src/ipa/raspberrypi/controller/metadata.hpp\n+++ b/src/ipa/raspberrypi/controller/metadata.hpp\n@@ -10,7 +10,6 @@\n \n #include <any>\n #include <map>\n-#include <memory>\n #include <mutex>\n #include <string>\n \n@@ -108,6 +107,4 @@ private:\n \tstd::map<std::string, std::any> data_;\n };\n \n-typedef std::shared_ptr<Metadata> MetadataPtr;\n-\n } // namespace RPiController\n", "prefixes": [ "libcamera-devel", "v2" ] }