[libcamera-devel,v2] ipa: raspberrypi: Remove unused MetadataPtr
diff mbox series

Message ID 20210714130232.63284-1-jeanmichel.hautbois@ideasonboard.com
State Accepted
Commit 35e23837fab8e7837254db32e6a76ddbe4453189
Headers show
Series
  • [libcamera-devel,v2] ipa: raspberrypi: Remove unused MetadataPtr
Related show

Commit Message

Jean-Michel Hautbois July 14, 2021, 1:02 p.m. UTC
The Metadata class defines a shared_ptr named MetadataPtr.  It is not
used anywhere in the source code, so remove it.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/raspberrypi/controller/metadata.hpp | 3 ---
 1 file changed, 3 deletions(-)

Comments

Naushir Patuck July 14, 2021, 1:14 p.m. UTC | #1
Hi Jean-Michel,

Thank you for your patch.

On Wed, 14 Jul 2021 at 14:02, Jean-Michel Hautbois <
jeanmichel.hautbois@ideasonboard.com> wrote:

> The Metadata class defines a shared_ptr named MetadataPtr.  It is not
> used anywhere in the source code, so remove it.
>
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Reviewed-by: Naushir Patuck <naush@raspberrypi.com>


> ---
>  src/ipa/raspberrypi/controller/metadata.hpp | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/src/ipa/raspberrypi/controller/metadata.hpp
> b/src/ipa/raspberrypi/controller/metadata.hpp
> index fd6aac88..51e576cf 100644
> --- a/src/ipa/raspberrypi/controller/metadata.hpp
> +++ b/src/ipa/raspberrypi/controller/metadata.hpp
> @@ -10,7 +10,6 @@
>
>  #include <any>
>  #include <map>
> -#include <memory>
>  #include <mutex>
>  #include <string>
>
> @@ -108,6 +107,4 @@ private:
>         std::map<std::string, std::any> data_;
>  };
>
> -typedef std::shared_ptr<Metadata> MetadataPtr;
> -
>  } // namespace RPiController
> --
> 2.30.2
>
>

Patch
diff mbox series

diff --git a/src/ipa/raspberrypi/controller/metadata.hpp b/src/ipa/raspberrypi/controller/metadata.hpp
index fd6aac88..51e576cf 100644
--- a/src/ipa/raspberrypi/controller/metadata.hpp
+++ b/src/ipa/raspberrypi/controller/metadata.hpp
@@ -10,7 +10,6 @@ 
 
 #include <any>
 #include <map>
-#include <memory>
 #include <mutex>
 #include <string>
 
@@ -108,6 +107,4 @@  private:
 	std::map<std::string, std::any> data_;
 };
 
-typedef std::shared_ptr<Metadata> MetadataPtr;
-
 } // namespace RPiController