Patch Detail
Show a patch.
GET /api/patches/1292/?format=api
{ "id": 1292, "url": "https://patchwork.libcamera.org/api/patches/1292/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1292/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190525002229.1160-1-niklas.soderlund@ragnatech.se>", "date": "2019-05-25T00:22:29", "name": "[libcamera-devel] tests: list_formats: Fix argument names and add const", "commit_ref": "9342c606495a2bc5485b69c51f16d5730bb0386c", "pull_url": null, "state": "accepted", "archived": false, "hash": "27f05c17f9b3dce747693b8f4e0b626c0c6d5dde", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1292/mbox/", "series": [ { "id": 327, "url": "https://patchwork.libcamera.org/api/series/327/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=327", "date": "2019-05-25T00:22:29", "name": "[libcamera-devel] tests: list_formats: Fix argument names and add const", "version": 1, "mbox": "https://patchwork.libcamera.org/series/327/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1292/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1292/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC75760E49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 May 2019 02:22:40 +0200 (CEST)", "from bismarck.berto.se (unknown [89.233.230.99])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 2e43fadf-7e83-11e9-8601-0050569116f7;\n\tSat, 25 May 2019 02:22:37 +0200 (CEST)" ], "X-Halon-ID": "2e43fadf-7e83-11e9-8601-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 25 May 2019 02:22:29 +0200", "Message-Id": "<20190525002229.1160-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] tests: list_formats: Fix argument names\n\tand add const", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 25 May 2019 00:22:41 -0000" }, "content": "Argument name differs from definition and implementation, fix it by\nrenaming the definition. While at it make the argument const.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n test/v4l2_subdevice/list_formats.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\nindex 18dd8761a8ab408f..3f0edafcdcd72d6b 100644\n--- a/test/v4l2_subdevice/list_formats.cpp\n+++ b/test/v4l2_subdevice/list_formats.cpp\n@@ -26,15 +26,15 @@ protected:\n \n private:\n \tvoid printFormats(unsigned int pad, unsigned code,\n-\t\t\t std::vector<SizeRange> &formats);\n+\t\t\t const std::vector<SizeRange> &sizes);\n };\n \n void ListFormatsTest::printFormats(unsigned int pad,\n \t\t\t\t unsigned int code,\n-\t\t\t\t std::vector<SizeRange> &sizes)\n+\t\t\t\t const std::vector<SizeRange> &sizes)\n {\n \tcout << \"Enumerate formats on pad \" << pad << endl;\n-\tfor (SizeRange &size : sizes) {\n+\tfor (const SizeRange &size : sizes) {\n \t\tcout << \"\tmbus code: 0x\" << setfill('0') << setw(4)\n \t\t << hex << code << endl;\n \t\tcout << \"\tmin width: \" << dec << size.min.width << endl;\n", "prefixes": [ "libcamera-devel" ] }