| Message ID | 20190525002229.1160-1-niklas.soderlund@ragnatech.se |
|---|---|
| State | Accepted |
| Commit | 9342c606495a2bc5485b69c51f16d5730bb0386c |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas, Thank you for the patch. On Sat, May 25, 2019 at 02:22:29AM +0200, Niklas Söderlund wrote: > Argument name differs from definition and implementation, fix it by > renaming the definition. While at it make the argument const. > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/v4l2_subdevice/list_formats.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp > index 18dd8761a8ab408f..3f0edafcdcd72d6b 100644 > --- a/test/v4l2_subdevice/list_formats.cpp > +++ b/test/v4l2_subdevice/list_formats.cpp > @@ -26,15 +26,15 @@ protected: > > private: > void printFormats(unsigned int pad, unsigned code, > - std::vector<SizeRange> &formats); > + const std::vector<SizeRange> &sizes); > }; > > void ListFormatsTest::printFormats(unsigned int pad, > unsigned int code, > - std::vector<SizeRange> &sizes) > + const std::vector<SizeRange> &sizes) > { > cout << "Enumerate formats on pad " << pad << endl; > - for (SizeRange &size : sizes) { > + for (const SizeRange &size : sizes) { > cout << " mbus code: 0x" << setfill('0') << setw(4) > << hex << code << endl; > cout << " min width: " << dec << size.min.width << endl;
Hi, I have pushed this to master with Laurent's tag, thanks! On 2019-05-25 06:44:42 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Sat, May 25, 2019 at 02:22:29AM +0200, Niklas Söderlund wrote: > > Argument name differs from definition and implementation, fix it by > > renaming the definition. While at it make the argument const. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > test/v4l2_subdevice/list_formats.cpp | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp > > index 18dd8761a8ab408f..3f0edafcdcd72d6b 100644 > > --- a/test/v4l2_subdevice/list_formats.cpp > > +++ b/test/v4l2_subdevice/list_formats.cpp > > @@ -26,15 +26,15 @@ protected: > > > > private: > > void printFormats(unsigned int pad, unsigned code, > > - std::vector<SizeRange> &formats); > > + const std::vector<SizeRange> &sizes); > > }; > > > > void ListFormatsTest::printFormats(unsigned int pad, > > unsigned int code, > > - std::vector<SizeRange> &sizes) > > + const std::vector<SizeRange> &sizes) > > { > > cout << "Enumerate formats on pad " << pad << endl; > > - for (SizeRange &size : sizes) { > > + for (const SizeRange &size : sizes) { > > cout << " mbus code: 0x" << setfill('0') << setw(4) > > << hex << code << endl; > > cout << " min width: " << dec << size.min.width << endl; > > -- > Regards, > > Laurent Pinchart
diff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp index 18dd8761a8ab408f..3f0edafcdcd72d6b 100644 --- a/test/v4l2_subdevice/list_formats.cpp +++ b/test/v4l2_subdevice/list_formats.cpp @@ -26,15 +26,15 @@ protected: private: void printFormats(unsigned int pad, unsigned code, - std::vector<SizeRange> &formats); + const std::vector<SizeRange> &sizes); }; void ListFormatsTest::printFormats(unsigned int pad, unsigned int code, - std::vector<SizeRange> &sizes) + const std::vector<SizeRange> &sizes) { cout << "Enumerate formats on pad " << pad << endl; - for (SizeRange &size : sizes) { + for (const SizeRange &size : sizes) { cout << " mbus code: 0x" << setfill('0') << setw(4) << hex << code << endl; cout << " min width: " << dec << size.min.width << endl;
Argument name differs from definition and implementation, fix it by renaming the definition. While at it make the argument const. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- test/v4l2_subdevice/list_formats.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)