Patch Detail
Show a patch.
GET /api/patches/12689/?format=api
{ "id": 12689, "url": "https://patchwork.libcamera.org/api/patches/12689/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12689/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210622134652.1279260-6-andrey.konovalov@linaro.org>", "date": "2021-06-22T13:46:48", "name": "[libcamera-devel,v5,5/9] qcam: viewfinder_gl: fix wrong comment in bayer_8.frag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "41410987a4c0ebe8d0552ec7911049e02521d638", "submitter": { "id": 25, "url": "https://patchwork.libcamera.org/api/people/25/?format=api", "name": "Andrey Konovalov", "email": "andrey.konovalov@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12689/mbox/", "series": [ { "id": 2168, "url": "https://patchwork.libcamera.org/api/series/2168/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2168", "date": "2021-06-22T13:46:43", "name": "qcam: viewfinder_gl: add RAW8, RAW10P and RAW12P formats", "version": 5, "mbox": "https://patchwork.libcamera.org/series/2168/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12689/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12689/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63D53C321B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Jun 2021 13:47:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B2F260297;\n\tTue, 22 Jun 2021 15:47:19 +0200 (CEST)", "from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD3BA60292\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jun 2021 15:47:17 +0200 (CEST)", "by mail-lj1-x229.google.com with SMTP id r16so30230535ljk.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jun 2021 06:47:17 -0700 (PDT)", "from localhost.localdomain ([85.249.44.185])\n\tby smtp.googlemail.com with ESMTPSA id\n\tb19sm163125ljo.37.2021.06.22.06.47.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Jun 2021 06:47:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"E2mOZorX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=vdQ0X2mdhCu8PAxs8sRLJ2Kgy3COxepLag9X7dpUg3E=;\n\tb=E2mOZorX2EKfw9vw4b77RuqHoOSY0IGoBXjpze/6wLiVa+QxYcLaksYNiUPT6fp6jZ\n\tav8M/6rmK+6jqML7oFxJBXF9VWJ61Avjg9pC1JIzCMtFoG5Nq2tPxYwEjTqqV5sC6es3\n\t2YfsRIA9RE7cWfXc/G4lIhWcSbGdlCvZ0k4XPJ3GZtjwRvtvN0OoOYBqK6aHiE/JjQQ+\n\t0TylGfkmYZBSUfjnECOswQfXRHOry3luZ+N8/7bkXl29ua6VdAw+zqU0ICQV3b/rNIJP\n\t6TE4SsT+hJWIF3HdBTw018dgR171kymOt4c2dl8hhqHZq6SOkHsSJeV0gTK8bgg67NlV\n\tWdHw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=vdQ0X2mdhCu8PAxs8sRLJ2Kgy3COxepLag9X7dpUg3E=;\n\tb=iQo6+mUeHT3fyJU2HQJRo+1fGk26kSrau7R0gbEHhAvLEw/G2yJ4nKXXU6nwASRk1x\n\tfOmvG9zKbBQbQe/YoW3LVHeJFI57m3nlWPtTaKA7JzBgiu35vnWEFw1KqcV6ENTFRCN8\n\tszmRpixrKJ1SAoNadaUntIpDM2NuLV1715QUxwf751ASkzUyT2poyWIpvdulcZsYVS9K\n\tUssrqEr3NzmqdO8KJ2BHXiQxVa+agos52FE8/iEoeE0MZmsiowV9/g6TH1pdqJshb5iu\n\tHBNnZvOQOXdN/xcyrBIBkD54nDL7TwozDHgXVv+QSb8IPqGUtXQXFWe2TrQ0pVKUIPTx\n\tKwsA==", "X-Gm-Message-State": "AOAM5330+msXv0H2Ncy2DxCwVInQEkMsMHG3VTJbE7WRO8mBzUbWgjuG\n\te5IoQedyfU37nk4pCz45iIK/CTaPDIjaVg==", "X-Google-Smtp-Source": "ABdhPJwbMur9MCVoBW8Q8tcErImz7rYXvLdO9Z4T9ml5E6t1NpgM9kJMbnHddBhDyBOUsj1JkaTMQQ==", "X-Received": "by 2002:a2e:bf2a:: with SMTP id c42mr3432718ljr.1.1624369637256; \n\tTue, 22 Jun 2021 06:47:17 -0700 (PDT)", "From": "Andrey Konovalov <andrey.konovalov@linaro.org>", "To": "libcamera-devel@lists.libcamera.org,\n\tlaurent.pinchart@ideasonboard.com", "Date": "Tue, 22 Jun 2021 16:46:48 +0300", "Message-Id": "<20210622134652.1279260-6-andrey.konovalov@linaro.org>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210622134652.1279260-1-andrey.konovalov@linaro.org>", "References": "<20210622134652.1279260-1-andrey.konovalov@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong\n\tcomment in bayer_8.frag", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "morgan@casual-effects.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fetching into value[2] corresponds to E0, and fetching into value[3] - to\nF0. The fetch()-es themselves are correct, but the comments were not.\n\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n---\n src/qcam/assets/shader/bayer_8.frag | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag\nindex 707e76ed..74a6322f 100644\n--- a/src/qcam/assets/shader/bayer_8.frag\n+++ b/src/qcam/assets/shader/bayer_8.frag\n@@ -68,8 +68,8 @@ void main(void) {\n vec4 value = vec4(\n fetch(center.x, yCoord[0]), // ( 0,-2)\n fetch(center.x, yCoord[1]), // ( 0,-1)\n- fetch(xCoord[0], center.y), // (-1, 0)\n- fetch(xCoord[1], center.y)); // (-2, 0)\n+ fetch(xCoord[0], center.y), // (-2, 0)\n+ fetch(xCoord[1], center.y)); // (-1, 0)\n \n vec4 temp = vec4(\n fetch(center.x, yCoord[3]), // ( 0, 2)\n", "prefixes": [ "libcamera-devel", "v5", "5/9" ] }