From patchwork Tue Jun 22 13:46:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 12689 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 63D53C321B for ; Tue, 22 Jun 2021 13:47:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2B2F260297; Tue, 22 Jun 2021 15:47:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="E2mOZorX"; dkim-atps=neutral Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BD3BA60292 for ; Tue, 22 Jun 2021 15:47:17 +0200 (CEST) Received: by mail-lj1-x229.google.com with SMTP id r16so30230535ljk.9 for ; Tue, 22 Jun 2021 06:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vdQ0X2mdhCu8PAxs8sRLJ2Kgy3COxepLag9X7dpUg3E=; b=E2mOZorX2EKfw9vw4b77RuqHoOSY0IGoBXjpze/6wLiVa+QxYcLaksYNiUPT6fp6jZ av8M/6rmK+6jqML7oFxJBXF9VWJ61Avjg9pC1JIzCMtFoG5Nq2tPxYwEjTqqV5sC6es3 2YfsRIA9RE7cWfXc/G4lIhWcSbGdlCvZ0k4XPJ3GZtjwRvtvN0OoOYBqK6aHiE/JjQQ+ 0TylGfkmYZBSUfjnECOswQfXRHOry3luZ+N8/7bkXl29ua6VdAw+zqU0ICQV3b/rNIJP 6TE4SsT+hJWIF3HdBTw018dgR171kymOt4c2dl8hhqHZq6SOkHsSJeV0gTK8bgg67NlV WdHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vdQ0X2mdhCu8PAxs8sRLJ2Kgy3COxepLag9X7dpUg3E=; b=iQo6+mUeHT3fyJU2HQJRo+1fGk26kSrau7R0gbEHhAvLEw/G2yJ4nKXXU6nwASRk1x fOmvG9zKbBQbQe/YoW3LVHeJFI57m3nlWPtTaKA7JzBgiu35vnWEFw1KqcV6ENTFRCN8 szmRpixrKJ1SAoNadaUntIpDM2NuLV1715QUxwf751ASkzUyT2poyWIpvdulcZsYVS9K UssrqEr3NzmqdO8KJ2BHXiQxVa+agos52FE8/iEoeE0MZmsiowV9/g6TH1pdqJshb5iu HBNnZvOQOXdN/xcyrBIBkD54nDL7TwozDHgXVv+QSb8IPqGUtXQXFWe2TrQ0pVKUIPTx KwsA== X-Gm-Message-State: AOAM5330+msXv0H2Ncy2DxCwVInQEkMsMHG3VTJbE7WRO8mBzUbWgjuG e5IoQedyfU37nk4pCz45iIK/CTaPDIjaVg== X-Google-Smtp-Source: ABdhPJwbMur9MCVoBW8Q8tcErImz7rYXvLdO9Z4T9ml5E6t1NpgM9kJMbnHddBhDyBOUsj1JkaTMQQ== X-Received: by 2002:a2e:bf2a:: with SMTP id c42mr3432718ljr.1.1624369637256; Tue, 22 Jun 2021 06:47:17 -0700 (PDT) Received: from localhost.localdomain ([85.249.44.185]) by smtp.googlemail.com with ESMTPSA id b19sm163125ljo.37.2021.06.22.06.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jun 2021 06:47:16 -0700 (PDT) From: Andrey Konovalov To: libcamera-devel@lists.libcamera.org, laurent.pinchart@ideasonboard.com Date: Tue, 22 Jun 2021 16:46:48 +0300 Message-Id: <20210622134652.1279260-6-andrey.konovalov@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210622134652.1279260-1-andrey.konovalov@linaro.org> References: <20210622134652.1279260-1-andrey.konovalov@linaro.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 5/9] qcam: viewfinder_gl: fix wrong comment in bayer_8.frag X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: morgan@casual-effects.com Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Fetching into value[2] corresponds to E0, and fetching into value[3] - to F0. The fetch()-es themselves are correct, but the comments were not. Signed-off-by: Andrey Konovalov Reviewed-by: Paul Elder Reviewed-by: Laurent Pinchart --- src/qcam/assets/shader/bayer_8.frag | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag index 707e76ed..74a6322f 100644 --- a/src/qcam/assets/shader/bayer_8.frag +++ b/src/qcam/assets/shader/bayer_8.frag @@ -68,8 +68,8 @@ void main(void) { vec4 value = vec4( fetch(center.x, yCoord[0]), // ( 0,-2) fetch(center.x, yCoord[1]), // ( 0,-1) - fetch(xCoord[0], center.y), // (-1, 0) - fetch(xCoord[1], center.y)); // (-2, 0) + fetch(xCoord[0], center.y), // (-2, 0) + fetch(xCoord[1], center.y)); // (-1, 0) vec4 temp = vec4( fetch(center.x, yCoord[3]), // ( 0, 2)