Patch Detail
Show a patch.
GET /api/patches/12425/?format=api
{ "id": 12425, "url": "https://patchwork.libcamera.org/api/patches/12425/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12425/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210526114814.650016-1-umang.jain@ideasonboard.com>", "date": "2021-05-26T11:48:14", "name": "[libcamera-devel] ipa: ipu3: Rectify ControlInfoMap matching in IPAConfigInfo", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e043ef45fe3f1cd0fc2995b08cb23745b6ec647a", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12425/mbox/", "series": [ { "id": 2073, "url": "https://patchwork.libcamera.org/api/series/2073/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2073", "date": "2021-05-26T11:48:14", "name": "[libcamera-devel] ipa: ipu3: Rectify ControlInfoMap matching in IPAConfigInfo", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2073/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12425/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12425/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48699BDB80\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 May 2021 11:48:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5186F6891D;\n\tWed, 26 May 2021 13:48:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D40D602AB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 May 2021 13:48:29 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A966332;\n\tWed, 26 May 2021 13:48:27 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n1jkEEjJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1622029708;\n\tbh=CxtxQpsTZu6m1h9/FeQwBr39Sr4B0CL53Pr+xLrhw38=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=n1jkEEjJ44PbaRpHmkOJWHRk8rrRExVAIXHFbxaV/uVnWQo7a56TYRsSgNbq3Oc2S\n\tUMDzvRgg/Q/RarFOR1EwO7/qkbvoTg+HYua5KeJiKP2b8eelrIDmzjptNICUGUXYuG\n\tRw/7gRYjSYUVmiLPzxgByUpwN7US5NHzn3xlCmn0=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 26 May 2021 17:18:14 +0530", "Message-Id": "<20210526114814.650016-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: ipu3: Rectify ControlInfoMap\n\tmatching in IPAConfigInfo", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ControlInfoMap of entityControls member in IPAConfigInfo struct,\nwas not able to correctly match to the ControlInfoMap defined in\ncore.mojom. This resulted in a FATAL breakage when IPU3 IPA is meant to\nrun:\n\n FATAL IPADataSerializer ipa_data_serializer.cpp:437 ControlSerializer\n not provided for serialization of ControlInfoMap\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n include/libcamera/ipa/ipu3.mojom | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex 6b6b431f..32c046ad 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -32,7 +32,7 @@ struct IPU3Action {\n \n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n-\tmap<uint32, ControlInfoMap> entityControls;\n+\tmap<uint32, libcamera.ControlInfoMap> entityControls;\n \tlibcamera.Size bdsOutputSize;\n \tlibcamera.Size iif;\n };\n", "prefixes": [ "libcamera-devel" ] }