From patchwork Wed May 26 11:48:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12425 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 48699BDB80 for ; Wed, 26 May 2021 11:48:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5186F6891D; Wed, 26 May 2021 13:48:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="n1jkEEjJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D40D602AB for ; Wed, 26 May 2021 13:48:29 +0200 (CEST) Received: from perceval.ideasonboard.com (unknown [103.251.226.203]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A966332; Wed, 26 May 2021 13:48:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1622029708; bh=CxtxQpsTZu6m1h9/FeQwBr39Sr4B0CL53Pr+xLrhw38=; h=From:To:Cc:Subject:Date:From; b=n1jkEEjJ44PbaRpHmkOJWHRk8rrRExVAIXHFbxaV/uVnWQo7a56TYRsSgNbq3Oc2S UMDzvRgg/Q/RarFOR1EwO7/qkbvoTg+HYua5KeJiKP2b8eelrIDmzjptNICUGUXYuG Rw/7gRYjSYUVmiLPzxgByUpwN7US5NHzn3xlCmn0= From: Umang Jain To: libcamera-devel@lists.libcamera.org Date: Wed, 26 May 2021 17:18:14 +0530 Message-Id: <20210526114814.650016-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] ipa: ipu3: Rectify ControlInfoMap matching in IPAConfigInfo X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The ControlInfoMap of entityControls member in IPAConfigInfo struct, was not able to correctly match to the ControlInfoMap defined in core.mojom. This resulted in a FATAL breakage when IPU3 IPA is meant to run: FATAL IPADataSerializer ipa_data_serializer.cpp:437 ControlSerializer not provided for serialization of ControlInfoMap Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart --- include/libcamera/ipa/ipu3.mojom | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom index 6b6b431f..32c046ad 100644 --- a/include/libcamera/ipa/ipu3.mojom +++ b/include/libcamera/ipa/ipu3.mojom @@ -32,7 +32,7 @@ struct IPU3Action { struct IPAConfigInfo { libcamera.IPACameraSensorInfo sensorInfo; - map entityControls; + map entityControls; libcamera.Size bdsOutputSize; libcamera.Size iif; };