Patch Detail
Show a patch.
GET /api/patches/12219/?format=api
{ "id": 12219, "url": "https://patchwork.libcamera.org/api/patches/12219/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12219/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<c4b4be65-e615-3077-fee0-bfcdbb3f9f39@ideasonboard.com>", "date": "2021-05-07T05:24:19", "name": "[libcamera-devel] system locations of libcamera headers", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "56f9b682c3185a27c5f1e4a802520e1de7a0ced0", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/12219/mbox/", "series": [ { "id": 2008, "url": "https://patchwork.libcamera.org/api/series/2008/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2008", "date": "2021-05-07T05:24:19", "name": "[libcamera-devel] system locations of libcamera headers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2008/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12219/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12219/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1F21BF831\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 7 May 2021 05:24:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5384968909;\n\tFri, 7 May 2021 07:24:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 145CF602B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 May 2021 07:24:27 +0200 (CEST)", "from localhost.localdomain (unknown [103.251.226.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EE5D2CF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 May 2021 07:24:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uyN9foOh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1620365066;\n\tbh=IprKvr7vIy0cEGPwo7zF9TS2mNI4WbIkstsWPYxBBVQ=;\n\th=To:From:Subject:Date:From;\n\tb=uyN9foOhEzmNZUtUO6t4cZCOE1/BR5poxkvLYMZhm6SRmZT0oDbD8L9xhbiCCnrzt\n\trJ/zDM51tSy5EI1DR2qzHQbvn9ezneW3YMMOX3q3dbK1pRovGNRNGb1x467fbLUCY3\n\tzwsrfkWBwN8A/DGMjouezKhHzt+T/pjMkltI2Epk=", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "From": "Umang Jain <umang.jain@ideasonboard.com>", "Message-ID": "<c4b4be65-e615-3077-fee0-bfcdbb3f9f39@ideasonboard.com>", "Date": "Fri, 7 May 2021 10:54:19 +0530", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0", "MIME-Version": "1.0", "Content-Language": "en-US", "Subject": "[libcamera-devel] system locations of libcamera headers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "multipart/mixed;\n\tboundary=\"===============3240174483482774744==\"", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi all,\n\nIf I compile the master branch with --prefix=/usr\n/meson --prefix=/usr -Dpipelines=uvcvideo,ipu3 build && sudo ninja -C \nbuild install/\n\n\nThe headers turns out to have a directory structure as below:\n\n\n[uajain@localhost libcamera]$ tree /usr/include/libcamera/\n/usr/include/libcamera/\n├── ipa\n│ ├── ipa_controls.h\n│ ├── ipa_interface.h\n│ └── ipa_module_info.h\n└── libcamera\n ├── bound_method.h\n ├── buffer.h\n ├── camera.h\n ├── camera_manager.h\n ├── class.h\n ├── compiler.h\n ├── control_ids.h\n ├── controls.h\n ├── file_descriptor.h\n ├── formats.h\n ├── framebuffer_allocator.h\n ├── geometry.h\n ├── libcamera.h\n ├── logging.h\n ├── object.h\n ├── pixel_format.h\n ├── property_ids.h\n ├── request.h\n ├── signal.h\n ├── span.h\n ├── stream.h\n ├── transform.h\n └── version.h\n\n2 directories, 26 files\n\n\nMy question is, is this how we want public headers to be placed ? For \ne.g. the absolute path of signal.h \nis/usr/include/libcamera/libcamera/signal.h, hence, even the below diff \nwill compile successfully (due to linker find path magic)\n\nlibcamera headers on system locations (for IPAs to use) - It's better to \nkick off some dicussions around how we would structure the header \nlocations. This will also clear some of my ongoing meson cleanup work \n(not all patches, but only a couple).", "diff": "diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp\nindex cd83c684..5f005d1b 100644\n--- a/src/libcamera/object.cpp\n+++ b/src/libcamera/object.cpp\n@@ -9,7 +9,7 @@\n\n #include <algorithm>\n\n-#include <libcamera/signal.h>\n+#include <libcamera/libcamera/signal.h>\n\n\nConsidering the case where we also need to expose some of the internal \n", "prefixes": [ "libcamera-devel" ] }