From patchwork Fri May 7 05:24:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 12219 X-Patchwork-Delegate: umang.jain@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F1F21BF831 for ; Fri, 7 May 2021 05:24:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5384968909; Fri, 7 May 2021 07:24:28 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uyN9foOh"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 145CF602B9 for ; Fri, 7 May 2021 07:24:27 +0200 (CEST) Received: from localhost.localdomain (unknown [103.251.226.24]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EE5D2CF for ; Fri, 7 May 2021 07:24:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1620365066; bh=IprKvr7vIy0cEGPwo7zF9TS2mNI4WbIkstsWPYxBBVQ=; h=To:From:Subject:Date:From; b=uyN9foOhEzmNZUtUO6t4cZCOE1/BR5poxkvLYMZhm6SRmZT0oDbD8L9xhbiCCnrzt rJ/zDM51tSy5EI1DR2qzHQbvn9ezneW3YMMOX3q3dbK1pRovGNRNGb1x467fbLUCY3 zwsrfkWBwN8A/DGMjouezKhHzt+T/pjMkltI2Epk= To: libcamera devel From: Umang Jain Message-ID: Date: Fri, 7 May 2021 10:54:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 Content-Language: en-US Subject: [libcamera-devel] system locations of libcamera headers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, If I compile the master branch with --prefix=/usr /meson --prefix=/usr -Dpipelines=uvcvideo,ipu3 build && sudo ninja -C build install/ The headers turns out to have a directory structure as below: [uajain@localhost libcamera]$ tree /usr/include/libcamera/ /usr/include/libcamera/ ├── ipa │   ├── ipa_controls.h │   ├── ipa_interface.h │   └── ipa_module_info.h └── libcamera     ├── bound_method.h     ├── buffer.h     ├── camera.h     ├── camera_manager.h     ├── class.h     ├── compiler.h     ├── control_ids.h     ├── controls.h     ├── file_descriptor.h     ├── formats.h     ├── framebuffer_allocator.h     ├── geometry.h     ├── libcamera.h     ├── logging.h     ├── object.h     ├── pixel_format.h     ├── property_ids.h     ├── request.h     ├── signal.h     ├── span.h     ├── stream.h     ├── transform.h     └── version.h 2 directories, 26 files My question is, is this how we want public headers to be placed ? For e.g. the absolute path of signal.h is/usr/include/libcamera/libcamera/signal.h, hence, even the below diff will compile successfully (due to linker find path magic) libcamera headers on system locations (for IPAs to use) - It's better to kick off some dicussions around how we would structure the header locations. This will also clear some of my ongoing meson cleanup work (not all patches, but only a couple). diff --git a/src/libcamera/object.cpp b/src/libcamera/object.cpp index cd83c684..5f005d1b 100644 --- a/src/libcamera/object.cpp +++ b/src/libcamera/object.cpp @@ -9,7 +9,7 @@  #include -#include +#include Considering the case where we also need to expose some of the internal