Patch Detail
Show a patch.
GET /api/patches/12136/?format=api
{ "id": 12136, "url": "https://patchwork.libcamera.org/api/patches/12136/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12136/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210430043957.111667-3-umang.jain@ideasonboard.com>", "date": "2021-04-30T04:39:57", "name": "[libcamera-devel,v3,2/2] test: bayer-format: Rectify internal header's #include path", "commit_ref": "332870ea2b5800b12f45c889de5e37c08a0279f5", "pull_url": null, "state": "accepted", "archived": false, "hash": "3cf36049d1077059716ca5e204946b627c0df49b", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12136/mbox/", "series": [ { "id": 1987, "url": "https://patchwork.libcamera.org/api/series/1987/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1987", "date": "2021-04-30T04:39:55", "name": "Rectify inclusion of internal headers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1987/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12136/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12136/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E155BDE47\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Apr 2021 04:40:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D00668914;\n\tFri, 30 Apr 2021 06:40:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5117E602C0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Apr 2021 06:40:13 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.128])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0FE2B1A;\n\tFri, 30 Apr 2021 06:40:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"veedmGlY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1619757612;\n\tbh=zh3XLUZUSI9P8MWwL+f7bV3zeHGz5OEhMGygZ43dK5Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=veedmGlYkMNO/AnoHgrTvPQdBhRW5N+6aBMVOY/ThltgxALMoeykIcCZm8tK4nEVO\n\tKeNceBvGhp88fQjTMa1TKQA/L7eoF12ssGtRnQ0/mN0SM3e9vGOUsfV1kAHKGUXGKW\n\tphYw7yxgyTwpYyQGXFEHZgFG9KYbzmJno62ifmKU=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Apr 2021 10:09:57 +0530", "Message-Id": "<20210430043957.111667-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210430043957.111667-1-umang.jain@ideasonboard.com>", "References": "<20210430043957.111667-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 2/2] test: bayer-format: Rectify\n\tinternal header's #include path", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamera internal headers are not available system-wide. Hence,\ndirective `#include <libcamera/internal/header.h>` is wrong. Fix it\nby using \"\" for the #include directive.\n\nFixes: e09c487b97f8 (\"test: Add unit tests for the BayerFormat class\")\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n test/bayer-format.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp\nindex 047e7db3..e396ee83 100644\n--- a/test/bayer-format.cpp\n+++ b/test/bayer-format.cpp\n@@ -7,9 +7,10 @@\n \n #include <iostream>\n \n-#include <libcamera/internal/bayer_format.h>\n #include <libcamera/transform.h>\n \n+#include \"libcamera/internal/bayer_format.h\"\n+\n #include \"test.h\"\n \n using namespace std;\n", "prefixes": [ "libcamera-devel", "v3", "2/2" ] }