| Message ID | 20210430043957.111667-3-umang.jain@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 332870ea2b5800b12f45c889de5e37c08a0279f5 |
| Headers | show |
| Series |
|
| Related | show |
Hi Umang, On Fri, Apr 30, 2021 at 10:09:57AM +0530, Umang Jain wrote: > libcamera internal headers are not available system-wide. Hence, > directive `#include <libcamera/internal/header.h>` is wrong. Fix it > by using "" for the #include directive. > > Fixes: e09c487b97f8 ("test: Add unit tests for the BayerFormat class") > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Thanks, looks good! Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > test/bayer-format.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp > index 047e7db3..e396ee83 100644 > --- a/test/bayer-format.cpp > +++ b/test/bayer-format.cpp > @@ -7,9 +7,10 @@ > > #include <iostream> > > -#include <libcamera/internal/bayer_format.h> > #include <libcamera/transform.h> > > +#include "libcamera/internal/bayer_format.h" > + > #include "test.h" > > using namespace std; > -- > 2.29.2 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hey Umang, Thank you for the patch. On 30.04.2021 10:09, Umang Jain wrote: >libcamera internal headers are not available system-wide. Hence, >directive `#include <libcamera/internal/header.h>` is wrong. Fix it >by using "" for the #include directive. > >Fixes: e09c487b97f8 ("test: Add unit tests for the BayerFormat class") >Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net> >--- > test/bayer-format.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp >index 047e7db3..e396ee83 100644 >--- a/test/bayer-format.cpp >+++ b/test/bayer-format.cpp >@@ -7,9 +7,10 @@ > > #include <iostream> > >-#include <libcamera/internal/bayer_format.h> > #include <libcamera/transform.h> > >+#include "libcamera/internal/bayer_format.h" >+ This was my fault, thank you for fixing it! > #include "test.h" > > using namespace std; >-- >2.29.2 > >_______________________________________________ >libcamera-devel mailing list >libcamera-devel@lists.libcamera.org >https://lists.libcamera.org/listinfo/libcamera-devel
Sebastian, I've -literally- just pushed this one. I'm sorry for not waiting for your tag! On Wed, May 05, 2021 at 08:07:20AM +0000, Sebastian Fricke wrote: > Hey Umang, > > Thank you for the patch. > > On 30.04.2021 10:09, Umang Jain wrote: > > libcamera internal headers are not available system-wide. Hence, > > directive `#include <libcamera/internal/header.h>` is wrong. Fix it > > by using "" for the #include directive. > > > > Fixes: e09c487b97f8 ("test: Add unit tests for the BayerFormat class") > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > Reviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net> > > --- > > test/bayer-format.cpp | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp > > index 047e7db3..e396ee83 100644 > > --- a/test/bayer-format.cpp > > +++ b/test/bayer-format.cpp > > @@ -7,9 +7,10 @@ > > > > #include <iostream> > > > > -#include <libcamera/internal/bayer_format.h> > > #include <libcamera/transform.h> > > > > +#include "libcamera/internal/bayer_format.h" > > + > > This was my fault, thank you for fixing it! > > > #include "test.h" > > > > using namespace std; > > -- > > 2.29.2 > > > > _______________________________________________ > > libcamera-devel mailing list > > libcamera-devel@lists.libcamera.org > > https://lists.libcamera.org/listinfo/libcamera-devel > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/test/bayer-format.cpp b/test/bayer-format.cpp index 047e7db3..e396ee83 100644 --- a/test/bayer-format.cpp +++ b/test/bayer-format.cpp @@ -7,9 +7,10 @@ #include <iostream> -#include <libcamera/internal/bayer_format.h> #include <libcamera/transform.h> +#include "libcamera/internal/bayer_format.h" + #include "test.h" using namespace std;
libcamera internal headers are not available system-wide. Hence, directive `#include <libcamera/internal/header.h>` is wrong. Fix it by using "" for the #include directive. Fixes: e09c487b97f8 ("test: Add unit tests for the BayerFormat class") Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- test/bayer-format.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)