Patch Detail
Show a patch.
GET /api/patches/11755/?format=api
{ "id": 11755, "url": "https://patchwork.libcamera.org/api/patches/11755/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11755/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210329022604.110201-2-hiroh@chromium.org>", "date": "2021-03-29T02:26:03", "name": "[libcamera-devel,RFC,1/2] libcamera: CameraData: Change queuedRequests_ type to std::dequeue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "28d9bbb40596481f7472950c46f06dad82b0509d", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11755/mbox/", "series": [ { "id": 1857, "url": "https://patchwork.libcamera.org/api/series/1857/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1857", "date": "2021-03-29T02:26:02", "name": "Enable handling a number of capture requests", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1857/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11755/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11755/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D4E8C32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Mar 2021 02:26:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F35776878B;\n\tMon, 29 Mar 2021 04:26:15 +0200 (CEST)", "from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com\n\t[IPv6:2607:f8b0:4864:20::1030])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE000602D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Mar 2021 04:26:14 +0200 (CEST)", "by mail-pj1-x1030.google.com with SMTP id\n\tot17-20020a17090b3b51b0290109c9ac3c34so6980010pjb.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Mar 2021 19:26:14 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:1db7:ae60:9288:b906])\n\tby smtp.gmail.com with ESMTPSA id\n\ta26sm10537879pff.149.2021.03.28.19.26.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 28 Mar 2021 19:26:12 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Z8y8BpUk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OnvULsl0p2IJPoR9+i18brD7WO6K1ll5UjoYcmuDwXs=;\n\tb=Z8y8BpUkKzIv+sqz8CN6uZ9uraAljWdiwmmjE0VEHlLtN82R+ioNSgTBjdWzfMuuyj\n\tgBVjWgtIO+POAiSewL6nk3d49BrHdYpH5mcnV5C4/dFLN6jj+HZ/xz1iUg8f6naJayW2\n\tNolMROJw1EOcfhD5q97bqya61/uRwqX9MOr5E=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OnvULsl0p2IJPoR9+i18brD7WO6K1ll5UjoYcmuDwXs=;\n\tb=UqJsP4gUp+vBJyrrrr6sZjd6Soi81nYIKB7ce+iySiphsNtxwoN3Hd8qkoYz6SAIIv\n\tNvAvzIRsQ2/8A/GryYpjzdMEWwwZlsY1BZLSp0BC39CZlEH6zrwDMQEGXsOG8I84ByzT\n\trY5fv+wq6WqTDPSV1EUN0EzuQICsfKE6ioBPyWoZsuUrmPXt4v9S/JgemrVBxxAxO4fv\n\tfRIcSnj2nwVENhOdIbLCATQ5tL6HBbEth3ODedZqMQhtACdPE8BXk/FvEIIlmpirXuDW\n\twncykhq6jhUuUnRiX/lEZmFzcFJJ3OWYvE+I9jfxb1kNygR3ETyS2VklnKxx+n92Gi/x\n\t7nsQ==", "X-Gm-Message-State": "AOAM533bWFvZboqM5GzO99g1Sy8lR3IH+T/EGr7mshkC7Wd/cNinM6bN\n\t7ZASKbtjp7PpCGGvHsMK8kHzBN7sE+kvhw==", "X-Google-Smtp-Source": "ABdhPJw6Db1qTNYKRDc6Ef9xYYphXR9zHDk9cpZw3C2mdv2FGrMXN1I06k5v+Msyq3ISqbN3ftt6LA==", "X-Received": "by 2002:a17:90a:be09:: with SMTP id\n\ta9mr24098028pjs.219.1616984772724; \n\tSun, 28 Mar 2021 19:26:12 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Mar 2021 11:26:03 +0900", "Message-Id": "<20210329022604.110201-2-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.31.0.291.g576ba9dcdaf-goog", "In-Reply-To": "<20210329022604.110201-1-hiroh@chromium.org>", "References": "<20210329022604.110201-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [RFC PATCH 1/2] libcamera: CameraData: Change\n\tqueuedRequests_ type to std::dequeue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The type of CameraData::queuedRequests_ is std::list. The more\nappropriate type is std::dequeue as the requests is reported as\ncomplete in the order of queuing and are needed to be removed in\nthe first and last ones.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n include/libcamera/internal/pipeline_handler.h | 4 ++--\n src/libcamera/pipeline_handler.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 093b94c6..763da63e 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -7,9 +7,9 @@\n #ifndef __LIBCAMERA_INTERNAL_PIPELINE_HANDLER_H__\n #define __LIBCAMERA_INTERNAL_PIPELINE_HANDLER_H__\n \n-#include <list>\n #include <map>\n #include <memory>\n+#include <queue>\n #include <set>\n #include <string>\n #include <sys/types.h>\n@@ -44,7 +44,7 @@ public:\n \tvirtual ~CameraData() = default;\n \n \tPipelineHandler *pipe_;\n-\tstd::list<Request *> queuedRequests_;\n+\tstd::deque<Request *> queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 0228d7b2..4cb58084 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -72,9 +72,9 @@ LOG_DEFINE_CATEGORY(Pipeline)\n \n /**\n * \\var CameraData::queuedRequests_\n- * \\brief The list of queued and not yet completed request\n+ * \\brief The queue of queued and not yet completed request\n *\n- * The list of queued request is used to track requests queued in order to\n+ * The queue of queued request is used to track requests queued in order to\n * ensure completion of all requests when the pipeline handler is stopped.\n *\n * \\sa PipelineHandler::queueRequest(), PipelineHandler::stop(),\n", "prefixes": [ "libcamera-devel", "RFC", "1/2" ] }