From patchwork Mon Mar 29 02:26:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11755 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8D4E8C32EA for ; Mon, 29 Mar 2021 02:26:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F35776878B; Mon, 29 Mar 2021 04:26:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Z8y8BpUk"; dkim-atps=neutral Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CE000602D7 for ; Mon, 29 Mar 2021 04:26:14 +0200 (CEST) Received: by mail-pj1-x1030.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so6980010pjb.4 for ; Sun, 28 Mar 2021 19:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OnvULsl0p2IJPoR9+i18brD7WO6K1ll5UjoYcmuDwXs=; b=Z8y8BpUkKzIv+sqz8CN6uZ9uraAljWdiwmmjE0VEHlLtN82R+ioNSgTBjdWzfMuuyj gBVjWgtIO+POAiSewL6nk3d49BrHdYpH5mcnV5C4/dFLN6jj+HZ/xz1iUg8f6naJayW2 NolMROJw1EOcfhD5q97bqya61/uRwqX9MOr5E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OnvULsl0p2IJPoR9+i18brD7WO6K1ll5UjoYcmuDwXs=; b=UqJsP4gUp+vBJyrrrr6sZjd6Soi81nYIKB7ce+iySiphsNtxwoN3Hd8qkoYz6SAIIv NvAvzIRsQ2/8A/GryYpjzdMEWwwZlsY1BZLSp0BC39CZlEH6zrwDMQEGXsOG8I84ByzT rY5fv+wq6WqTDPSV1EUN0EzuQICsfKE6ioBPyWoZsuUrmPXt4v9S/JgemrVBxxAxO4fv fRIcSnj2nwVENhOdIbLCATQ5tL6HBbEth3ODedZqMQhtACdPE8BXk/FvEIIlmpirXuDW wncykhq6jhUuUnRiX/lEZmFzcFJJ3OWYvE+I9jfxb1kNygR3ETyS2VklnKxx+n92Gi/x 7nsQ== X-Gm-Message-State: AOAM533bWFvZboqM5GzO99g1Sy8lR3IH+T/EGr7mshkC7Wd/cNinM6bN 7ZASKbtjp7PpCGGvHsMK8kHzBN7sE+kvhw== X-Google-Smtp-Source: ABdhPJw6Db1qTNYKRDc6Ef9xYYphXR9zHDk9cpZw3C2mdv2FGrMXN1I06k5v+Msyq3ISqbN3ftt6LA== X-Received: by 2002:a17:90a:be09:: with SMTP id a9mr24098028pjs.219.1616984772724; Sun, 28 Mar 2021 19:26:12 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:1db7:ae60:9288:b906]) by smtp.gmail.com with ESMTPSA id a26sm10537879pff.149.2021.03.28.19.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 19:26:12 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Mar 2021 11:26:03 +0900 Message-Id: <20210329022604.110201-2-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210329022604.110201-1-hiroh@chromium.org> References: <20210329022604.110201-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 1/2] libcamera: CameraData: Change queuedRequests_ type to std::dequeue X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The type of CameraData::queuedRequests_ is std::list. The more appropriate type is std::dequeue as the requests is reported as complete in the order of queuing and are needed to be removed in the first and last ones. Signed-off-by: Hirokazu Honda Reviewed-by: Sebastian Fricke --- include/libcamera/internal/pipeline_handler.h | 4 ++-- src/libcamera/pipeline_handler.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h index 093b94c6..763da63e 100644 --- a/include/libcamera/internal/pipeline_handler.h +++ b/include/libcamera/internal/pipeline_handler.h @@ -7,9 +7,9 @@ #ifndef __LIBCAMERA_INTERNAL_PIPELINE_HANDLER_H__ #define __LIBCAMERA_INTERNAL_PIPELINE_HANDLER_H__ -#include #include #include +#include #include #include #include @@ -44,7 +44,7 @@ public: virtual ~CameraData() = default; PipelineHandler *pipe_; - std::list queuedRequests_; + std::deque queuedRequests_; ControlInfoMap controlInfo_; ControlList properties_; diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 0228d7b2..4cb58084 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -72,9 +72,9 @@ LOG_DEFINE_CATEGORY(Pipeline) /** * \var CameraData::queuedRequests_ - * \brief The list of queued and not yet completed request + * \brief The queue of queued and not yet completed request * - * The list of queued request is used to track requests queued in order to + * The queue of queued request is used to track requests queued in order to * ensure completion of all requests when the pipeline handler is stopped. * * \sa PipelineHandler::queueRequest(), PipelineHandler::stop(),