Patch Detail
Show a patch.
GET /api/patches/1145/?format=api
{ "id": 1145, "url": "https://patchwork.libcamera.org/api/patches/1145/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1145/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190430183746.28518-6-laurent.pinchart@ideasonboard.com>", "date": "2019-04-30T18:37:46", "name": "[libcamera-devel,5/5] (q)cam: Unify naming of configurations in applications", "commit_ref": "83f8c09c2f67faad5acad6f51db2ddb66a135c0a", "pull_url": null, "state": "accepted", "archived": false, "hash": "0c93b9e302bd8ba172e884bc2b6176f007fc14b6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1145/mbox/", "series": [ { "id": 285, "url": "https://patchwork.libcamera.org/api/series/285/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=285", "date": "2019-04-30T18:37:41", "name": "Miscellaneous cleanups and refactoring", "version": 1, "mbox": "https://patchwork.libcamera.org/series/285/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1145/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1145/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CBED60E5B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Apr 2019 20:38:03 +0200 (CEST)", "from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA3E631D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Apr 2019 20:38:02 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556649482;\n\tbh=HXdED7P6OLWGrfcufof3GYhShjfQq3Q9A8aD1Tmk5Y4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=LNQqXLl7452N9kbBivTIhqGaH2r9v/j+tlQoUeIPBJCrDCuS4NiBJUzBihgzCAUkf\n\tNnmZ65/+brqk5ZhPZQSwf0Sn0VkR3/z33oj25uj5Yhb+6sVxncRtRoRjGouDZcdG3M\n\t5EL3PNAb1xCnHsrqGdcULYXKbLaLIPRMyGAG1LfE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Apr 2019 21:37:46 +0300", "Message-Id": "<20190430183746.28518-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190430183746.28518-1-laurent.pinchart@ideasonboard.com>", "References": "<20190430183746.28518-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 5/5] (q)cam: Unify naming of\n\tconfigurations in applications", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 30 Apr 2019 18:38:03 -0000" }, "content": "Name all instances of CameraConfiguration \"config\", and all instances of\nStreamConfiguration \"cfg\" accross the cam and qcam applications.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 6e92f6a1124d..ee06d751672b 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -105,9 +105,9 @@ int MainWindow::startCapture()\n \t\treturn ret;\n \t}\n \n-\tconst StreamConfiguration &sconf = config_[stream];\n-\tret = viewfinder_->setFormat(sconf.pixelFormat, sconf.size.width,\n-\t\t\t\t sconf.size.height);\n+\tconst StreamConfiguration &cfg = config_[stream];\n+\tret = viewfinder_->setFormat(cfg.pixelFormat, cfg.size.width,\n+\t\t\t\t cfg.size.height);\n \tif (ret < 0) {\n \t\tstd::cout << \"Failed to set viewfinder format\" << std::endl;\n \t\treturn ret;\n", "prefixes": [ "libcamera-devel", "5/5" ] }