From patchwork Tue Apr 30 18:37:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1141 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A65760E5B for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A5FD156A for ; Tue, 30 Apr 2019 20:38:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556649481; bh=fcTmE0PaNB5J5AnfzMDxfHTFr3fR7v/xEJZPk82E/mg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=FXDErKfnInjofbCfESNnyR+MFum90dLtWVbUmR5afVWUOTab7RVzdhnfPF4fbblaQ ujggwvN3Ns0gPbv0FymDSHnS+nbsXTKl+i853E4krAIGiLG3R6KpfhuE5EcBsJIuKH qxl0Ud5GSSpWty+ceQRzqUH/TvNvKRtDxrU2H+to= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Apr 2019 21:37:42 +0300 Message-Id: <20190430183746.28518-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> References: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/5] libcamera: pipeline_handler: Remove duplicated log from uvc and vimc X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 18:38:02 -0000 The uvcvideo and vimc pipeline handlers print the requested resolution in their configureStreams() operation. This duplicates a generic log statement in the Camera::configureStreams() method, remove it. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/pipeline/uvcvideo.cpp | 3 --- src/libcamera/pipeline/vimc.cpp | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp index 2f9b5e0fdc08..fd1d6df177d9 100644 --- a/src/libcamera/pipeline/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo.cpp @@ -109,9 +109,6 @@ int PipelineHandlerUVC::configureStreams(Camera *camera, const StreamConfiguration *cfg = &config[&data->stream_]; int ret; - LOG(UVC, Debug) << "Configure the camera for resolution " - << cfg->width << "x" << cfg->height; - V4L2DeviceFormat format = {}; format.width = cfg->width; format.height = cfg->height; diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp index f70b4d3c6bab..f95140661b2a 100644 --- a/src/libcamera/pipeline/vimc.cpp +++ b/src/libcamera/pipeline/vimc.cpp @@ -109,9 +109,6 @@ int PipelineHandlerVimc::configureStreams(Camera *camera, const StreamConfiguration *cfg = &config[&data->stream_]; int ret; - LOG(VIMC, Debug) << "Configure the camera for resolution " - << cfg->width << "x" << cfg->height; - V4L2DeviceFormat format = {}; format.width = cfg->width; format.height = cfg->height; From patchwork Tue Apr 30 18:37:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1142 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 65663600F9 for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E4ED69A1 for ; Tue, 30 Apr 2019 20:38:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556649482; bh=SakNNJW7IpZytlB+c2vurzHn1mhq5GGEZNIfR9oNLnA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=dH2zE+J82p+xeAQ5wxC21buiFKi54zYqCdG9Rq287fyXq7NC9scaMpoH9ITaYBi7W bdQ0bSAxlqwZPRoWXhLl6jLy4qjrCMDHW6LTOndok6yzZLDlsdplb9Xgp8qlQ3UMi/ ANojgWLSoV/n4uhYOhn0DcVtih/PABv5VQ9WbwXM= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Apr 2019 21:37:43 +0300 Message-Id: <20190430183746.28518-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> References: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/5] libcamera: Use the Size class through libcamera X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 18:38:02 -0000 Several of our structures include width and height fields that model a size while be have a Size class for that purpose. Use the Size class through libcamera, and give it a toString() method like other geometry and format classes. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- include/libcamera/geometry.h | 2 ++ include/libcamera/stream.h | 5 ++- src/cam/main.cpp | 4 +-- src/libcamera/camera.cpp | 2 +- src/libcamera/camera_sensor.cpp | 3 +- src/libcamera/geometry.cpp | 9 ++++++ src/libcamera/include/v4l2_device.h | 4 +-- src/libcamera/include/v4l2_subdevice.h | 3 +- src/libcamera/pipeline/ipu3/ipu3.cpp | 39 ++++++++++-------------- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 ++++------ src/libcamera/pipeline/uvcvideo.cpp | 9 ++---- src/libcamera/pipeline/vimc.cpp | 9 ++---- src/libcamera/stream.cpp | 22 +++++-------- src/libcamera/v4l2_device.cpp | 36 +++++++++------------- src/libcamera/v4l2_subdevice.cpp | 24 ++++++--------- src/qcam/main_window.cpp | 3 +- test/camera/configuration_set.cpp | 7 ++--- test/v4l2_device/formats.cpp | 6 ++-- test/v4l2_subdevice/test_formats.cpp | 11 +++---- 19 files changed, 93 insertions(+), 121 deletions(-) diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h index 3dbbced5c76f..a87d65d3ed79 100644 --- a/include/libcamera/geometry.h +++ b/include/libcamera/geometry.h @@ -40,6 +40,8 @@ struct Size { unsigned int width; unsigned int height; + + const std::string toString() const; }; bool operator==(const Size &lhs, const Size &rhs); diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h index 3caaefc9f8e9..0c986310939b 100644 --- a/include/libcamera/stream.h +++ b/include/libcamera/stream.h @@ -17,9 +17,8 @@ namespace libcamera { class Camera; struct StreamConfiguration { - unsigned int width; - unsigned int height; unsigned int pixelFormat; + Size size; unsigned int bufferCount; @@ -40,7 +39,7 @@ public: protected: explicit StreamUsage(Role role); - StreamUsage(Role role, int width, int height); + StreamUsage(Role role, const Size &size); private: Role role_; diff --git a/src/cam/main.cpp b/src/cam/main.cpp index 46aba728393c..f03c32b385a9 100644 --- a/src/cam/main.cpp +++ b/src/cam/main.cpp @@ -137,10 +137,10 @@ static int prepareCameraConfig(CameraConfiguration *config) it++; if (conf.isSet("width")) - (*config)[stream].width = conf["width"]; + (*config)[stream].size.width = conf["width"]; if (conf.isSet("height")) - (*config)[stream].height = conf["height"]; + (*config)[stream].size.height = conf["height"]; /* TODO: Translate 4CC string to ID. */ if (conf.isSet("pixelformat")) diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index ef9e15be09ec..6b74eb8e3507 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -131,7 +131,7 @@ bool CameraConfiguration::isValid() const for (auto const &it : config_) { const StreamConfiguration &conf = it.second; - if (conf.width == 0 || conf.height == 0 || + if (conf.size.width == 0 || conf.size.height == 0 || conf.pixelFormat == 0 || conf.bufferCount == 0) return false; } diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index 8f2eab562b94..2b9d8fa593c1 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -234,8 +234,7 @@ V4L2SubdeviceFormat CameraSensor::getFormat(const std::vector &mbu return format; } - format.width = bestSize->width; - format.height = bestSize->height; + format.size = *bestSize; return format; } diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp index c8aa05f54b73..97c367bcb454 100644 --- a/src/libcamera/geometry.cpp +++ b/src/libcamera/geometry.cpp @@ -107,6 +107,15 @@ bool operator==(const Rectangle &lhs, const Rectangle &rhs) * \brief The Size height */ +/** + * \brief Assemble and return a string describing the size + * \return A string describing the size + */ +const std::string Size::toString() const +{ + return std::to_string(width) + "x" + std::to_string(height); +} + /** * \brief Compare sizes for equality * \return True if the two sizes are equal, false otherwise diff --git a/src/libcamera/include/v4l2_device.h b/src/libcamera/include/v4l2_device.h index b4b3cd5cfda3..2e7bd1e7f4cc 100644 --- a/src/libcamera/include/v4l2_device.h +++ b/src/libcamera/include/v4l2_device.h @@ -13,6 +13,7 @@ #include +#include #include #include "log.h" @@ -92,9 +93,8 @@ struct V4L2Capability final : v4l2_capability { class V4L2DeviceFormat { public: - uint32_t width; - uint32_t height; uint32_t fourcc; + Size size; struct { uint32_t size; diff --git a/src/libcamera/include/v4l2_subdevice.h b/src/libcamera/include/v4l2_subdevice.h index c7b0b4cb76ea..3e4e5107aebe 100644 --- a/src/libcamera/include/v4l2_subdevice.h +++ b/src/libcamera/include/v4l2_subdevice.h @@ -23,8 +23,7 @@ class MediaDevice; struct V4L2SubdeviceFormat { uint32_t mbus_code; - uint32_t width; - uint32_t height; + Size size; const std::string toString() const; }; diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index fbb37498ca8a..3aa475481cf9 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -262,8 +262,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, * * \todo Clarify ImgU alignment requirements. */ - streamConfig.width = 2560; - streamConfig.height = 1920; + streamConfig.size = { 2560, 1920 }; break; @@ -295,8 +294,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, res.width); unsigned int height = std::min(usage.size().height, res.height); - streamConfig.width = width & ~7; - streamConfig.height = height & ~3; + streamConfig.size = { width & ~7, height & ~3 }; break; } @@ -347,15 +345,15 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera, * \todo: Consider the BDS scaling factor requirements: "the * downscaling factor must be an integer value multiple of 1/32" */ - if (cfg.width % 8 || cfg.height % 4) { + if (cfg.size.width % 8 || cfg.size.height % 4) { LOG(IPU3, Error) << "Invalid stream size: bad alignment"; return -EINVAL; } const Size &resolution = cio2->sensor_->resolution(); - if (cfg.width > resolution.width || - cfg.height > resolution.height) { + if (cfg.size.width > resolution.width || + cfg.size.height > resolution.height) { LOG(IPU3, Error) << "Invalid stream size: larger than sensor resolution"; return -EINVAL; @@ -365,10 +363,10 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera, * Collect the maximum width and height: IPU3 can downscale * only. */ - if (cfg.width > sensorSize.width) - sensorSize.width = cfg.width; - if (cfg.height > sensorSize.height) - sensorSize.height = cfg.height; + if (cfg.size.width > sensorSize.width) + sensorSize.width = cfg.size.width; + if (cfg.size.height > sensorSize.height) + sensorSize.height = cfg.size.height; stream->active_ = true; } @@ -427,8 +425,7 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera, * \todo Revise this when we'll actually use the stat node. */ StreamConfiguration statConfig = {}; - statConfig.width = cio2Format.width; - statConfig.height = cio2Format.height; + statConfig.size = cio2Format.size; ret = imgu->configureOutput(&imgu->stat_, statConfig); if (ret) @@ -932,8 +929,8 @@ int ImgUDevice::configureInput(const Size &size, Rectangle rect = { .x = 0, .y = 0, - .w = inputFormat->width, - .h = inputFormat->height, + .w = inputFormat->size.width, + .h = inputFormat->size.height, }; ret = imgu_->setCrop(PAD_INPUT, &rect); if (ret) @@ -947,9 +944,8 @@ int ImgUDevice::configureInput(const Size &size, << rect.toString(); V4L2SubdeviceFormat imguFormat = {}; - imguFormat.width = size.width; - imguFormat.height = size.height; imguFormat.mbus_code = MEDIA_BUS_FMT_FIXED; + imguFormat.size = size; ret = imgu_->setFormat(PAD_INPUT, &imguFormat); if (ret) @@ -973,9 +969,8 @@ int ImgUDevice::configureOutput(ImgUOutput *output, unsigned int pad = output->pad; V4L2SubdeviceFormat imguFormat = {}; - imguFormat.width = config.width; - imguFormat.height = config.height; imguFormat.mbus_code = MEDIA_BUS_FMT_FIXED; + imguFormat.size = config.size; int ret = imgu_->setFormat(pad, &imguFormat); if (ret) @@ -986,9 +981,8 @@ int ImgUDevice::configureOutput(ImgUOutput *output, return 0; V4L2DeviceFormat outputFormat = {}; - outputFormat.width = config.width; - outputFormat.height = config.height; outputFormat.fourcc = V4L2_PIX_FMT_NV12; + outputFormat.size = config.size; outputFormat.planesCount = 2; ret = dev->setFormat(&outputFormat); @@ -1288,9 +1282,8 @@ int CIO2Device::configure(const Size &size, if (ret) return ret; - outputFormat->width = sensorFormat.width; - outputFormat->height = sensorFormat.height; outputFormat->fourcc = mediaBusToFormat(sensorFormat.mbus_code); + outputFormat->size = sensorFormat.size; outputFormat->planesCount = 1; ret = output_->setFormat(outputFormat); diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 9a63a68b81dd..7acf85155e2d 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -116,10 +116,8 @@ CameraConfiguration PipelineHandlerRkISP1::streamConfiguration(Camera *camera, CameraConfiguration configs; StreamConfiguration config{}; - const Size &resolution = data->sensor_->resolution(); - config.width = resolution.width; - config.height = resolution.height; config.pixelFormat = V4L2_PIX_FMT_NV12; + config.size = data->sensor_->resolution(); config.bufferCount = RKISP1_BUFFER_COUNT; configs[&data->stream_] = config; @@ -137,8 +135,8 @@ int PipelineHandlerRkISP1::configureStreams(Camera *camera, /* Verify the configuration. */ const Size &resolution = sensor->resolution(); - if (cfg.width > resolution.width || - cfg.height > resolution.height) { + if (cfg.size.width > resolution.width || + cfg.size.height > resolution.height) { LOG(RkISP1, Error) << "Invalid stream size: larger than sensor resolution"; return -EINVAL; @@ -193,7 +191,7 @@ int PipelineHandlerRkISP1::configureStreams(Camera *camera, MEDIA_BUS_FMT_SGBRG8_1X8, MEDIA_BUS_FMT_SGRBG8_1X8, MEDIA_BUS_FMT_SRGGB8_1X8 }, - Size(cfg.width, cfg.height)); + cfg.size); LOG(RkISP1, Debug) << "Configuring sensor with " << format.toString(); @@ -216,17 +214,15 @@ int PipelineHandlerRkISP1::configureStreams(Camera *camera, return ret; V4L2DeviceFormat outputFormat = {}; - outputFormat.width = cfg.width; - outputFormat.height = cfg.height; outputFormat.fourcc = cfg.pixelFormat; + outputFormat.size = cfg.size; outputFormat.planesCount = 2; ret = video_->setFormat(&outputFormat); if (ret) return ret; - if (outputFormat.width != cfg.width || - outputFormat.height != cfg.height || + if (outputFormat.size != cfg.size || outputFormat.fourcc != cfg.pixelFormat) { LOG(RkISP1, Error) << "Unable to configure capture in " << cfg.toString(); diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp index fd1d6df177d9..358e247baade 100644 --- a/src/libcamera/pipeline/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo.cpp @@ -92,9 +92,8 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera, CameraConfiguration configs; StreamConfiguration config{}; - config.width = 640; - config.height = 480; config.pixelFormat = V4L2_PIX_FMT_YUYV; + config.size = { 640, 480 }; config.bufferCount = 4; configs[&data->stream_] = config; @@ -110,16 +109,14 @@ int PipelineHandlerUVC::configureStreams(Camera *camera, int ret; V4L2DeviceFormat format = {}; - format.width = cfg->width; - format.height = cfg->height; format.fourcc = cfg->pixelFormat; + format.size = cfg->size; ret = data->video_->setFormat(&format); if (ret) return ret; - if (format.width != cfg->width || - format.height != cfg->height || + if (format.size != cfg->size || format.fourcc != cfg->pixelFormat) return -EINVAL; diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp index f95140661b2a..83fa9cf4033a 100644 --- a/src/libcamera/pipeline/vimc.cpp +++ b/src/libcamera/pipeline/vimc.cpp @@ -92,9 +92,8 @@ PipelineHandlerVimc::streamConfiguration(Camera *camera, CameraConfiguration configs; StreamConfiguration config{}; - config.width = 640; - config.height = 480; config.pixelFormat = V4L2_PIX_FMT_RGB24; + config.size = { 640, 480 }; config.bufferCount = 4; configs[&data->stream_] = config; @@ -110,16 +109,14 @@ int PipelineHandlerVimc::configureStreams(Camera *camera, int ret; V4L2DeviceFormat format = {}; - format.width = cfg->width; - format.height = cfg->height; format.fourcc = cfg->pixelFormat; + format.size = cfg->size; ret = data->video_->setFormat(&format); if (ret) return ret; - if (format.width != cfg->width || - format.height != cfg->height || + if (format.size != cfg->size || format.fourcc != cfg->pixelFormat) return -EINVAL; diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp index aeb479c57b37..4ff296e3a75b 100644 --- a/src/libcamera/stream.cpp +++ b/src/libcamera/stream.cpp @@ -41,13 +41,8 @@ namespace libcamera { */ /** - * \var StreamConfiguration::width - * \brief Stream width in pixels - */ - -/** - * \var StreamConfiguration::height - * \brief Stream height in pixels + * \var StreamConfiguration::size + * \brief Stream size in pixels */ /** @@ -73,8 +68,8 @@ std::string StreamConfiguration::toString() const std::stringstream ss; ss.fill(0); - ss << width << "x" << height << "-0x" << std::hex - << std::setw(8) << pixelFormat; + ss << size.toString() << "-0x" << std::hex << std::setw(8) + << pixelFormat; return ss.str(); } @@ -128,11 +123,10 @@ StreamUsage::StreamUsage(Role role) /** * \brief Create a stream usage with a desired size * \param[in] role Stream role - * \param[in] width The desired width - * \param[in] height The desired height + * \param[in] size The desired size */ -StreamUsage::StreamUsage(Role role, int width, int height) - : role_(role), size_(Size(width, height)) +StreamUsage::StreamUsage(Role role, const Size &size) + : role_(role), size_(size) { } @@ -183,7 +177,7 @@ Stream::VideoRecording::VideoRecording() * \param[in] height The desired viewfinder height */ Stream::Viewfinder::Viewfinder(int width, int height) - : StreamUsage(Role::Viewfinder, width, height) + : StreamUsage(Role::Viewfinder, Size(width, height)) { } diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp index a21944160253..1bbf79673c16 100644 --- a/src/libcamera/v4l2_device.cpp +++ b/src/libcamera/v4l2_device.cpp @@ -195,13 +195,8 @@ LOG_DEFINE_CATEGORY(V4L2) */ /** - * \var V4L2DeviceFormat::width - * \brief The image width in pixels - */ - -/** - * \var V4L2DeviceFormat::height - * \brief The image height in pixels + * \var V4L2DeviceFormat::size + * \brief The image size in pixels */ /** @@ -236,8 +231,7 @@ const std::string V4L2DeviceFormat::toString() const std::stringstream ss; ss.fill(0); - ss << width << "x" << height << "-0x" << std::hex - << std::setw(8) << fourcc; + ss << size.toString() << "-0x" << std::hex << std::setw(8) << fourcc; return ss.str(); } @@ -458,8 +452,8 @@ int V4L2Device::getFormatSingleplane(V4L2DeviceFormat *format) return ret; } - format->width = pix->width; - format->height = pix->height; + format->size.width = pix->width; + format->size.height = pix->height; format->fourcc = pix->pixelformat; format->planesCount = 1; format->planes[0].bpl = pix->bytesperline; @@ -475,8 +469,8 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format) int ret; v4l2Format.type = bufferType_; - pix->width = format->width; - pix->height = format->height; + pix->width = format->size.width; + pix->height = format->size.height; pix->pixelformat = format->fourcc; pix->bytesperline = format->planes[0].bpl; pix->field = V4L2_FIELD_NONE; @@ -492,8 +486,8 @@ int V4L2Device::setFormatSingleplane(V4L2DeviceFormat *format) * Return to caller the format actually applied on the device, * which might differ from the requested one. */ - format->width = pix->width; - format->height = pix->height; + format->size.width = pix->width; + format->size.height = pix->height; format->fourcc = pix->pixelformat; format->planesCount = 1; format->planes[0].bpl = pix->bytesperline; @@ -516,8 +510,8 @@ int V4L2Device::getFormatMultiplane(V4L2DeviceFormat *format) return ret; } - format->width = pix->width; - format->height = pix->height; + format->size.width = pix->width; + format->size.height = pix->height; format->fourcc = pix->pixelformat; format->planesCount = pix->num_planes; @@ -536,8 +530,8 @@ int V4L2Device::setFormatMultiplane(V4L2DeviceFormat *format) int ret; v4l2Format.type = bufferType_; - pix->width = format->width; - pix->height = format->height; + pix->width = format->size.width; + pix->height = format->size.height; pix->pixelformat = format->fourcc; pix->num_planes = format->planesCount; pix->field = V4L2_FIELD_NONE; @@ -558,8 +552,8 @@ int V4L2Device::setFormatMultiplane(V4L2DeviceFormat *format) * Return to caller the format actually applied on the device, * which might differ from the requested one. */ - format->width = pix->width; - format->height = pix->height; + format->size.width = pix->width; + format->size.height = pix->height; format->fourcc = pix->pixelformat; format->planesCount = pix->num_planes; for (unsigned int i = 0; i < format->planesCount; ++i) { diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp index 6fc866a6450b..fceee33156e9 100644 --- a/src/libcamera/v4l2_subdevice.cpp +++ b/src/libcamera/v4l2_subdevice.cpp @@ -65,13 +65,8 @@ LOG_DEFINE_CATEGORY(V4L2Subdev) */ /** - * \var V4L2SubdeviceFormat::width - * \brief The image width in pixels - */ - -/** - * \var V4L2SubdeviceFormat::height - * \brief The image height in pixels + * \var V4L2SubdeviceFormat::size + * \brief The image size in pixels */ /** @@ -83,8 +78,7 @@ const std::string V4L2SubdeviceFormat::toString() const std::stringstream ss; ss.fill(0); - ss << width << "x" << height << "-0x" << std::hex - << std::setw(4) << mbus_code; + ss << size.toString() << "-0x" << std::hex << std::setw(4) << mbus_code; return ss.str(); } @@ -265,8 +259,8 @@ int V4L2Subdevice::getFormat(unsigned int pad, V4L2SubdeviceFormat *format) return ret; } - format->width = subdevFmt.format.width; - format->height = subdevFmt.format.height; + format->size.width = subdevFmt.format.width; + format->size.height = subdevFmt.format.height; format->mbus_code = subdevFmt.format.code; return 0; @@ -288,8 +282,8 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format) struct v4l2_subdev_format subdevFmt = {}; subdevFmt.which = V4L2_SUBDEV_FORMAT_ACTIVE; subdevFmt.pad = pad; - subdevFmt.format.width = format->width; - subdevFmt.format.height = format->height; + subdevFmt.format.width = format->size.width; + subdevFmt.format.height = format->size.height; subdevFmt.format.code = format->mbus_code; int ret = ioctl(fd_, VIDIOC_SUBDEV_S_FMT, &subdevFmt); @@ -301,8 +295,8 @@ int V4L2Subdevice::setFormat(unsigned int pad, V4L2SubdeviceFormat *format) return ret; } - format->width = subdevFmt.format.width; - format->height = subdevFmt.format.height; + format->size.width = subdevFmt.format.width; + format->size.height = subdevFmt.format.height; format->mbus_code = subdevFmt.format.code; return 0; diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp index 4bc044037041..6e92f6a1124d 100644 --- a/src/qcam/main_window.cpp +++ b/src/qcam/main_window.cpp @@ -106,7 +106,8 @@ int MainWindow::startCapture() } const StreamConfiguration &sconf = config_[stream]; - ret = viewfinder_->setFormat(sconf.pixelFormat, sconf.width, sconf.height); + ret = viewfinder_->setFormat(sconf.pixelFormat, sconf.size.width, + sconf.size.height); if (ret < 0) { std::cout << "Failed to set viewfinder format" << std::endl; return ret; diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp index 5ac2a7a908c8..0c932bc1de18 100644 --- a/test/camera/configuration_set.cpp +++ b/test/camera/configuration_set.cpp @@ -64,8 +64,8 @@ protected: * the default configuration of the VIMC camera is known to * work. */ - sconf->width *= 2; - sconf->height *= 2; + sconf->size.width *= 2; + sconf->size.height *= 2; if (camera_->configureStreams(conf)) { cout << "Failed to set modified configuration" << endl; return TestFail; @@ -74,8 +74,7 @@ protected: /* * Test that setting an invalid configuration fails. */ - sconf->width = 0; - sconf->height = 0; + sconf->size = { 0, 0 }; if (!camera_->configureStreams(conf)) { cout << "Invalid configuration incorrectly accepted" << endl; return TestFail; diff --git a/test/v4l2_device/formats.cpp b/test/v4l2_device/formats.cpp index 30b8b5c3f3f5..007e7e9487b5 100644 --- a/test/v4l2_device/formats.cpp +++ b/test/v4l2_device/formats.cpp @@ -31,8 +31,7 @@ int Format::run() return TestFail; } - format.width = UINT_MAX; - format.height = UINT_MAX; + format.size = { UINT_MAX, UINT_MAX }; ret = capture_->setFormat(&format); if (ret) { cerr << "Failed to set format: image resolution is invalid: " @@ -41,7 +40,8 @@ int Format::run() return TestFail; } - if (format.width == UINT_MAX || format.height == UINT_MAX) { + if (format.size.width == UINT_MAX || + format.size.height == UINT_MAX) { cerr << "Failed to update image format = (UINT_MAX x UINT_MAX)" << endl; return TestFail; diff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp index af954459a3d8..e90c2c2426da 100644 --- a/test/v4l2_subdevice/test_formats.cpp +++ b/test/v4l2_subdevice/test_formats.cpp @@ -44,8 +44,7 @@ int FormatHandlingTest::run() /* * Set unrealistic image resolutions and make sure it gets updated. */ - format.width = UINT_MAX; - format.height = UINT_MAX; + format.size = { UINT_MAX, UINT_MAX }; ret = scaler_->setFormat(0, &format); if (ret) { cerr << "Failed to set format: image resolution is wrong, but " @@ -53,13 +52,13 @@ int FormatHandlingTest::run() return TestFail; } - if (format.width == UINT_MAX || format.height == UINT_MAX) { + if (format.size.width == UINT_MAX || + format.size.height == UINT_MAX) { cerr << "Failed to update image format" << endl; return TestFail; } - format.width = 0; - format.height = 0; + format.size = { 0, 0 }; ret = scaler_->setFormat(0, &format); if (ret) { cerr << "Failed to set format: image resolution is wrong, but " @@ -67,7 +66,7 @@ int FormatHandlingTest::run() return TestFail; } - if (format.width == 0 || format.height == 0) { + if (format.size.width == 0 || format.size.height == 0) { cerr << "Failed to update image format" << endl; return TestFail; } From patchwork Tue Apr 30 18:37:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1143 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A2CB660E5B for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CE5931D for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556649482; bh=Vl4wA9p3EhrwJPYSsXEmrxDjsVWt4xcdAm3kiP98Z00=; h=From:To:Subject:Date:In-Reply-To:References:From; b=GhlIkn97IZYaa1zHC57p0486p8DOKwjOVAF7SlMEuBH6bxiyj1tcHsd8YlifGqYRO 8SPPKWk9T3aWg0QYkrBukMnLwzthi1rrXpAXtohSe77ZYud/z1iOaq38LtLimwiEAJ ZbhrrC2RwcC4/NfCOFaNneW4nFHA2a53oqyVTrw8= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Apr 2019 21:37:44 +0300 Message-Id: <20190430183746.28518-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> References: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/5] libcamera: pipeline: Unify naming of configurations in pipeline handlers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 18:38:03 -0000 Name all instances of CameraConfiguration "config", and all instances of StreamConfiguration "cfg" accross all pipeline handlers. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/camera.cpp | 6 ++--- src/libcamera/pipeline/ipu3/ipu3.cpp | 32 ++++++++++++------------ src/libcamera/pipeline/rkisp1/rkisp1.cpp | 14 +++++------ src/libcamera/pipeline/uvcvideo.cpp | 14 +++++------ src/libcamera/pipeline/vimc.cpp | 14 +++++------ src/libcamera/pipeline_handler.cpp | 2 +- 6 files changed, 41 insertions(+), 41 deletions(-) diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index 6b74eb8e3507..cb45bafe3fb1 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -129,10 +129,10 @@ bool CameraConfiguration::isValid() const return false; for (auto const &it : config_) { - const StreamConfiguration &conf = it.second; + const StreamConfiguration &cfg = it.second; - if (conf.size.width == 0 || conf.size.height == 0 || - conf.pixelFormat == 0 || conf.bufferCount == 0) + if (cfg.size.width == 0 || cfg.size.height == 0 || + cfg.pixelFormat == 0 || cfg.bufferCount == 0) return false; } diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 3aa475481cf9..0041662514e1 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -66,7 +66,7 @@ public: int configureInput(const Size &size, V4L2DeviceFormat *inputFormat); int configureOutput(ImgUOutput *output, - const StreamConfiguration &config); + const StreamConfiguration &cfg); int importBuffers(BufferPool *pool); int exportBuffers(ImgUOutput *output, BufferPool *pool); @@ -224,14 +224,14 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, const std::vector &usages) { IPU3CameraData *data = cameraData(camera); - CameraConfiguration cameraConfig = {}; + CameraConfiguration config = {}; std::set streams = { &data->outStream_, &data->vfStream_, }; for (const StreamUsage &usage : usages) { - StreamConfiguration streamConfig = {}; + StreamConfiguration cfg = {}; StreamUsage::Role role = usage.role(); IPU3Stream *stream = nullptr; @@ -262,7 +262,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, * * \todo Clarify ImgU alignment requirements. */ - streamConfig.size = { 2560, 1920 }; + cfg.size = { 2560, 1920 }; break; @@ -294,7 +294,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, res.width); unsigned int height = std::min(usage.size().height, res.height); - streamConfig.size = { width & ~7, height & ~3 }; + cfg.size = { width & ~7, height & ~3 }; break; } @@ -310,13 +310,13 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, streams.erase(stream); - streamConfig.pixelFormat = V4L2_PIX_FMT_NV12; - streamConfig.bufferCount = IPU3_BUFFER_COUNT; + cfg.pixelFormat = V4L2_PIX_FMT_NV12; + cfg.bufferCount = IPU3_BUFFER_COUNT; - cameraConfig[stream] = streamConfig; + config[stream] = cfg; } - return cameraConfig; + return config; } int PipelineHandlerIPU3::configureStreams(Camera *camera, @@ -424,10 +424,10 @@ int PipelineHandlerIPU3::configureStreams(Camera *camera, * Apply the largest available format to the stat node. * \todo Revise this when we'll actually use the stat node. */ - StreamConfiguration statConfig = {}; - statConfig.size = cio2Format.size; + StreamConfiguration statCfg = {}; + statCfg.size = cio2Format.size; - ret = imgu->configureOutput(&imgu->stat_, statConfig); + ret = imgu->configureOutput(&imgu->stat_, statCfg); if (ret) return ret; @@ -959,18 +959,18 @@ int ImgUDevice::configureInput(const Size &size, /** * \brief Configure the ImgU unit \a id video output * \param[in] output The ImgU output device to configure - * \param[in] config The requested configuration + * \param[in] cfg The requested configuration * \return 0 on success or a negative error code otherwise */ int ImgUDevice::configureOutput(ImgUOutput *output, - const StreamConfiguration &config) + const StreamConfiguration &cfg) { V4L2Device *dev = output->dev; unsigned int pad = output->pad; V4L2SubdeviceFormat imguFormat = {}; imguFormat.mbus_code = MEDIA_BUS_FMT_FIXED; - imguFormat.size = config.size; + imguFormat.size = cfg.size; int ret = imgu_->setFormat(pad, &imguFormat); if (ret) @@ -982,7 +982,7 @@ int ImgUDevice::configureOutput(ImgUOutput *output, V4L2DeviceFormat outputFormat = {}; outputFormat.fourcc = V4L2_PIX_FMT_NV12; - outputFormat.size = config.size; + outputFormat.size = cfg.size; outputFormat.planesCount = 2; ret = dev->setFormat(&outputFormat); diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 7acf85155e2d..134d3df4e1eb 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -113,16 +113,16 @@ CameraConfiguration PipelineHandlerRkISP1::streamConfiguration(Camera *camera, const std::vector &usages) { RkISP1CameraData *data = cameraData(camera); - CameraConfiguration configs; - StreamConfiguration config{}; + CameraConfiguration config; + StreamConfiguration cfg{}; - config.pixelFormat = V4L2_PIX_FMT_NV12; - config.size = data->sensor_->resolution(); - config.bufferCount = RKISP1_BUFFER_COUNT; + cfg.pixelFormat = V4L2_PIX_FMT_NV12; + cfg.size = data->sensor_->resolution(); + cfg.bufferCount = RKISP1_BUFFER_COUNT; - configs[&data->stream_] = config; + config[&data->stream_] = cfg; - return configs; + return config; } int PipelineHandlerRkISP1::configureStreams(Camera *camera, diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp index 358e247baade..5d2f1c98fa36 100644 --- a/src/libcamera/pipeline/uvcvideo.cpp +++ b/src/libcamera/pipeline/uvcvideo.cpp @@ -89,16 +89,16 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera, const std::vector &usages) { UVCCameraData *data = cameraData(camera); - CameraConfiguration configs; - StreamConfiguration config{}; + CameraConfiguration config; + StreamConfiguration cfg{}; - config.pixelFormat = V4L2_PIX_FMT_YUYV; - config.size = { 640, 480 }; - config.bufferCount = 4; + cfg.pixelFormat = V4L2_PIX_FMT_YUYV; + cfg.size = { 640, 480 }; + cfg.bufferCount = 4; - configs[&data->stream_] = config; + config[&data->stream_] = cfg; - return configs; + return config; } int PipelineHandlerUVC::configureStreams(Camera *camera, diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp index 83fa9cf4033a..cdf43770a9bf 100644 --- a/src/libcamera/pipeline/vimc.cpp +++ b/src/libcamera/pipeline/vimc.cpp @@ -89,16 +89,16 @@ PipelineHandlerVimc::streamConfiguration(Camera *camera, const std::vector &usages) { VimcCameraData *data = cameraData(camera); - CameraConfiguration configs; - StreamConfiguration config{}; + CameraConfiguration config; + StreamConfiguration cfg{}; - config.pixelFormat = V4L2_PIX_FMT_RGB24; - config.size = { 640, 480 }; - config.bufferCount = 4; + cfg.pixelFormat = V4L2_PIX_FMT_RGB24; + cfg.size = { 640, 480 }; + cfg.bufferCount = 4; - configs[&data->stream_] = config; + config[&data->stream_] = cfg; - return configs; + return config; } int PipelineHandlerVimc::configureStreams(Camera *camera, diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp index 345abca89ab8..4ecd6c49efd8 100644 --- a/src/libcamera/pipeline_handler.cpp +++ b/src/libcamera/pipeline_handler.cpp @@ -175,7 +175,7 @@ PipelineHandler::~PipelineHandler() * \param[in] config The camera configurations to setup * * Configure the specified group of streams for \a camera according to the - * configuration specified in \a configs. The intended caller of this interface + * configuration specified in \a config. The intended caller of this interface * is the Camera class which will receive configuration to apply from the * application. * From patchwork Tue Apr 30 18:37:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1144 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E0A2B600F9 for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B6C356A for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556649482; bh=qmGkiIq/agi/2K+0ttciN0ediLMBmcXbGsbj+He0/Ao=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Hi5ttmt/L9ybWz21PA/q01XuGhEQhxSJlWTh+qN3yOGflclSzL5NNWfB4khc06+cJ EOxXhKXFV48TnXfZSp4RYHXnO4X9biBYa892EE8RzwYx3cxCGFvgBmhTV9RkbUrlOo 7XgirmS6MtWo1MXBYTEDf7IDpiJf6FWjZZt4L84Y= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Apr 2019 21:37:45 +0300 Message-Id: <20190430183746.28518-5-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> References: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 4/5] test: Unify naming of configurations in tests X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 18:38:03 -0000 Name all instances of CameraConfiguration "config", and all instances of StreamConfiguration "cfg" accross all tests. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- test/camera/capture.cpp | 14 +++++++------- test/camera/configuration_default.cpp | 10 +++++----- test/camera/configuration_set.cpp | 20 ++++++++++---------- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index 4e75a75c5b71..0101cc94e665 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -42,12 +42,12 @@ protected: int run() { - CameraConfiguration conf = + CameraConfiguration config = camera_->streamConfiguration({ Stream::VideoRecording() }); - Stream *stream = conf.front(); - StreamConfiguration *sconf = &conf[stream]; + Stream *stream = config.front(); + StreamConfiguration *cfg = &config[stream]; - if (!conf.isValid()) { + if (!config.isValid()) { cout << "Failed to read default configuration" << endl; return TestFail; } @@ -57,7 +57,7 @@ protected: return TestFail; } - if (camera_->configureStreams(conf)) { + if (camera_->configureStreams(config)) { cout << "Failed to set default configuration" << endl; return TestFail; } @@ -110,10 +110,10 @@ protected: while (timer.isRunning()) dispatcher->processEvents(); - if (completeRequestsCount_ <= sconf->bufferCount * 2) { + if (completeRequestsCount_ <= cfg->bufferCount * 2) { cout << "Failed to capture enough frames (got " << completeRequestsCount_ << " expected at least " - << sconf->bufferCount * 2 << ")" << endl; + << cfg->bufferCount * 2 << ")" << endl; return TestFail; } diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp index dd5106689f09..2a10ea507a67 100644 --- a/test/camera/configuration_default.cpp +++ b/test/camera/configuration_default.cpp @@ -18,11 +18,11 @@ class ConfigurationDefault : public CameraTest protected: int run() { - CameraConfiguration conf; + CameraConfiguration config; /* Test asking for configuration for a video stream. */ - conf = camera_->streamConfiguration({ Stream::VideoRecording() }); - if (!conf.isValid()) { + config = camera_->streamConfiguration({ Stream::VideoRecording() }); + if (!config.isValid()) { cout << "Default configuration invalid" << endl; return TestFail; } @@ -31,8 +31,8 @@ protected: * Test that asking for configuration for an empty array of * stream usages returns an empty list of configurations. */ - conf = camera_->streamConfiguration({}); - if (conf.isValid()) { + config = camera_->streamConfiguration({}); + if (config.isValid()) { cout << "Failed to retrieve configuration for empty usage list" << endl; return TestFail; diff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp index 0c932bc1de18..ca41ed689511 100644 --- a/test/camera/configuration_set.cpp +++ b/test/camera/configuration_set.cpp @@ -18,11 +18,11 @@ class ConfigurationSet : public CameraTest protected: int run() { - CameraConfiguration conf = + CameraConfiguration config = camera_->streamConfiguration({ Stream::VideoRecording() }); - StreamConfiguration *sconf = &conf[conf.front()]; + StreamConfiguration *cfg = &config[config.front()]; - if (!conf.isValid()) { + if (!config.isValid()) { cout << "Failed to read default configuration" << endl; return TestFail; } @@ -33,7 +33,7 @@ protected: } /* Test that setting the default configuration works. */ - if (camera_->configureStreams(conf)) { + if (camera_->configureStreams(config)) { cout << "Failed to set default configuration" << endl; return TestFail; } @@ -48,7 +48,7 @@ protected: return TestFail; } - if (!camera_->configureStreams(conf)) { + if (!camera_->configureStreams(config)) { cout << "Setting configuration on a camera not acquired succeeded when it should have failed" << endl; return TestFail; @@ -64,9 +64,9 @@ protected: * the default configuration of the VIMC camera is known to * work. */ - sconf->size.width *= 2; - sconf->size.height *= 2; - if (camera_->configureStreams(conf)) { + cfg->size.width *= 2; + cfg->size.height *= 2; + if (camera_->configureStreams(config)) { cout << "Failed to set modified configuration" << endl; return TestFail; } @@ -74,8 +74,8 @@ protected: /* * Test that setting an invalid configuration fails. */ - sconf->size = { 0, 0 }; - if (!camera_->configureStreams(conf)) { + cfg->size = { 0, 0 }; + if (!camera_->configureStreams(config)) { cout << "Invalid configuration incorrectly accepted" << endl; return TestFail; } From patchwork Tue Apr 30 18:37:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1145 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CBED60E5B for ; Tue, 30 Apr 2019 20:38:03 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CA3E631D for ; Tue, 30 Apr 2019 20:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556649482; bh=HXdED7P6OLWGrfcufof3GYhShjfQq3Q9A8aD1Tmk5Y4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=LNQqXLl7452N9kbBivTIhqGaH2r9v/j+tlQoUeIPBJCrDCuS4NiBJUzBihgzCAUkf NnmZ65/+brqk5ZhPZQSwf0Sn0VkR3/z33oj25uj5Yhb+6sVxncRtRoRjGouDZcdG3M 5EL3PNAb1xCnHsrqGdcULYXKbLaLIPRMyGAG1LfE= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Apr 2019 21:37:46 +0300 Message-Id: <20190430183746.28518-6-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> References: <20190430183746.28518-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/5] (q)cam: Unify naming of configurations in applications X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 18:38:03 -0000 Name all instances of CameraConfiguration "config", and all instances of StreamConfiguration "cfg" accross the cam and qcam applications. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/qcam/main_window.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp index 6e92f6a1124d..ee06d751672b 100644 --- a/src/qcam/main_window.cpp +++ b/src/qcam/main_window.cpp @@ -105,9 +105,9 @@ int MainWindow::startCapture() return ret; } - const StreamConfiguration &sconf = config_[stream]; - ret = viewfinder_->setFormat(sconf.pixelFormat, sconf.size.width, - sconf.size.height); + const StreamConfiguration &cfg = config_[stream]; + ret = viewfinder_->setFormat(cfg.pixelFormat, cfg.size.width, + cfg.size.height); if (ret < 0) { std::cout << "Failed to set viewfinder format" << std::endl; return ret;