Patch Detail
Show a patch.
GET /api/patches/10160/?format=api
{ "id": 10160, "url": "https://patchwork.libcamera.org/api/patches/10160/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10160/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201021103352.10395-1-jacopo@jmondi.org>", "date": "2020-10-21T10:33:52", "name": "[libcamera-devel] libcamera: pipeline: simple: Remove non-implemented methods", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "40de33a0d5275ac763288fb05b562ab4ca6cd56d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/10160/mbox/", "series": [ { "id": 1398, "url": "https://patchwork.libcamera.org/api/series/1398/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1398", "date": "2020-10-21T10:33:52", "name": "[libcamera-devel] libcamera: pipeline: simple: Remove non-implemented methods", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1398/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10160/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10160/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70EDDC3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Oct 2020 10:34:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0075E61D98;\n\tWed, 21 Oct 2020 12:33:59 +0200 (CEST)", "from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D72760353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Oct 2020 12:33:58 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 09293E0004;\n\tWed, 21 Oct 2020 10:33:57 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 21 Oct 2020 12:33:52 +0200", "Message-Id": "<20201021103352.10395-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: simple: Remove\n\tnon-implemented methods", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The initLinks() and createCamera() methods are declared but never\ndefined. Remove them.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 8c00c0ffc121..95a2d0bdfaba 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -145,10 +145,6 @@ private:\n \t\t\tPipelineHandler::cameraData(camera));\n \t}\n \n-\tint initLinks();\n-\n-\tint createCamera(MediaEntity *sensor);\n-\n \tvoid bufferReady(FrameBuffer *buffer);\n \tvoid converterDone(FrameBuffer *input, FrameBuffer *output);\n \n", "prefixes": [ "libcamera-devel" ] }