| Message ID | 20201021103352.10395-1-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Delegated to: | Jacopo Mondi |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, On 21/10/2020 11:33, Jacopo Mondi wrote: > The initLinks() and createCamera() methods are declared but never > defined. Remove them. Well that makes it clear where the simple pipeline handler derived from ;-) > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Indeed, they are not there. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/simple/simple.cpp | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 8c00c0ffc121..95a2d0bdfaba 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -145,10 +145,6 @@ private: > PipelineHandler::cameraData(camera)); > } > > - int initLinks(); > - > - int createCamera(MediaEntity *sensor); > - > void bufferReady(FrameBuffer *buffer); > void converterDone(FrameBuffer *input, FrameBuffer *output); > >
Hi Jacopo, Thanks for your work. On 2020-10-21 12:33:52 +0200, Jacopo Mondi wrote: > The initLinks() and createCamera() methods are declared but never > defined. Remove them. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/pipeline/simple/simple.cpp | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 8c00c0ffc121..95a2d0bdfaba 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -145,10 +145,6 @@ private: > PipelineHandler::cameraData(camera)); > } > > - int initLinks(); > - > - int createCamera(MediaEntity *sensor); > - > void bufferReady(FrameBuffer *buffer); > void converterDone(FrameBuffer *input, FrameBuffer *output); > > -- > 2.28.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Jacopo, Thank you for the patch. On Wed, Oct 21, 2020 at 12:33:52PM +0200, Jacopo Mondi wrote: > The initLinks() and createCamera() methods are declared but never > defined. Remove them. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/simple/simple.cpp | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp > index 8c00c0ffc121..95a2d0bdfaba 100644 > --- a/src/libcamera/pipeline/simple/simple.cpp > +++ b/src/libcamera/pipeline/simple/simple.cpp > @@ -145,10 +145,6 @@ private: > PipelineHandler::cameraData(camera)); > } > > - int initLinks(); > - > - int createCamera(MediaEntity *sensor); > - > void bufferReady(FrameBuffer *buffer); > void converterDone(FrameBuffer *input, FrameBuffer *output); >
diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 8c00c0ffc121..95a2d0bdfaba 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -145,10 +145,6 @@ private: PipelineHandler::cameraData(camera)); } - int initLinks(); - - int createCamera(MediaEntity *sensor); - void bufferReady(FrameBuffer *buffer); void converterDone(FrameBuffer *input, FrameBuffer *output);
The initLinks() and createCamera() methods are declared but never defined. Remove them. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/pipeline/simple/simple.cpp | 4 ---- 1 file changed, 4 deletions(-)