Cover Letter Detail
Show a cover letter.
GET /api/covers/17991/?format=api
{ "id": 17991, "url": "https://patchwork.libcamera.org/api/covers/17991/?format=api", "web_url": "https://patchwork.libcamera.org/cover/17991/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221213093802.704177-1-paul.elder@ideasonboard.com>", "date": "2022-12-13T09:37:59", "name": "[libcamera-devel,0/3] lc-compliance: Fix SimpleCapture test", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/17991/mbox/", "series": [ { "id": 3669, "url": "https://patchwork.libcamera.org/api/series/3669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3669", "date": "2022-12-13T09:37:59", "name": "lc-compliance: Fix SimpleCapture test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/17991/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDE28C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Dec 2022 09:38:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F32F63362;\n\tTue, 13 Dec 2022 10:38:14 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5FD36334D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Dec 2022 10:38:12 +0100 (CET)", "from pyrite.tail37cf.ts.net (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B5204A7;\n\tTue, 13 Dec 2022 10:38:11 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1670924294;\n\tbh=vv0hOqsNMAclIy7/4xQz5kNOt75lrj+0bisSZnrn12c=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=BapAIYUonpWlBJUxP5+i2Y4V9KA7Xlh7WverwuajFpPJZdn+bRQrVlRn5zjkzCizM\n\tu3+0aIHp9DKgWcjnmeo82KQYcdTjeoO3rVEgZ09Q7mrjQrKQHv7cqi3XTk9N3w5xpJ\n\tCZEYwm4xVBJbHBQVWdtOOfAgfWLBeLWQ3pQhhjGV2nTcWz0aGDQM8BRLe73pzqU1vi\n\tqdoW8UMMRWKSv05E8UTDr9jSE9aua3CFFxE7bwtca/pPM7mw6ahypme06GM7oKQ167\n\tScSCUO+xi5mvV2UcOrQ+FwoZ6pDBKloKpW2rwjs7wx8rcKw4bFMrt6eR/Cv2+qRZIb\n\tqkvVSRpnKbnbA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1670924292;\n\tbh=vv0hOqsNMAclIy7/4xQz5kNOt75lrj+0bisSZnrn12c=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=e2Ge8Xl6eC85vJJNVF7NYgKDxrGLussR/Q3h2ECHxkbjliy/+7m2y6alJ9mVmYtRO\n\tfls+MKBj9Wp6THaML99cGkH89QdPX6qBM1MSowyW6rGhy65Pewk6V6wFPdHyHYcqYy\n\t6hE5jLfvBLknzrxf3aHGO1yAhv54KUHNi9RkFjJc=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"e2Ge8Xl6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Dec 2022 18:37:59 +0900", "Message-Id": "<20221213093802.704177-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/3] lc-compliance: Fix SimpleCapture test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This series fixes bug 171 [1] *properly*.\n\nThis issue was that a Request was reused and not queued to the Camera,\nthen the buffers were freed before the Requests were destroyed, causing\nthe Requests to cancel the freed buffers -> segfault.\n\nTechnically this isn't an issue anymore because of \"lc-compliance:\nsimple_capture: Free Requests properly\" [2], but still this fix is more\nproper.\n\nFix this by reusing the Requests only if they will be queued to the\nCamera.\n\nAdditionally, add a note about this issue to the application developer\nguide, and a todo regarding a potential race condition in\nCamera::queueRequest.\n\n[1] https://bugs.libcamera.org/show_bug.cgi?id=171\n[2] https://git.libcamera.org/libcamera/libcamera.git/commit/?id=9a913eb9107483fcea01bd0e82c21e3733a5ddb2\n\nPaul Elder (3):\n lc-compliance: simple_capture: Fix Request reuse\n Documentation: application-developer: Elaborate on request reuse\n libcamera: camera: Add todo for race condition on queueRequest\n\n Documentation/guides/application-developer.rst | 4 ++++\n src/apps/lc-compliance/simple_capture.cpp | 2 +-\n src/libcamera/camera.cpp | 15 +++++++++++++++\n 3 files changed, 20 insertions(+), 1 deletion(-)" }