Patch Detail
Show a patch.
GET /api/1.1/patches/9622/?format=api
{ "id": 9622, "url": "https://patchwork.libcamera.org/api/1.1/patches/9622/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9622/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200915142038.28757-13-paul.elder@ideasonboard.com>", "date": "2020-09-15T14:20:27", "name": "[libcamera-devel,12/23] libcamera: PipelineHandler: Remove IPA from base class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f08cbdaedbd4ccbdc4cf52700f277880b912cf0", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9622/mbox/", "series": [ { "id": 1291, "url": "https://patchwork.libcamera.org/api/1.1/series/1291/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1291", "date": "2020-09-15T14:20:16", "name": "IPA isolation implementation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1291/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9622/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9622/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27282BF01C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 15 Sep 2020 14:21:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E724A62E32;\n\tTue, 15 Sep 2020 16:21:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCF6862E23\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 15 Sep 2020 16:21:20 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C97C14DF;\n\tTue, 15 Sep 2020 16:21:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CYQVTGqo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600179680;\n\tbh=sHQZxUf464cUUxWvh5t0rO7Wh4wGbbpd0kdCkgnFrhk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CYQVTGqocdXXlGIr7ObEIwhwo5WYu5wV9ds0OoU0O+BXCykMnULuMI2KpXSchXXFK\n\t0P0GXkpEPQ38NzlWhEJWj935zhsfW9/IRwz1/eKgpxxZXg6b/9BgNFbvtixiJY4liO\n\tjIWLQmnOn3EuQiA09pYm3skq9R0IEY0bNgFnQVz0=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 15 Sep 2020 23:20:27 +0900", "Message-Id": "<20200915142038.28757-13-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "References": "<20200915142038.28757-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 12/23] libcamera: PipelineHandler: Remove\n\tIPA from base class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since pipline handlers now have their own IPA interface types, it can no\nlonger be defined in the base class, and each pipline handler\nimplementation must declare it and its type themselves. Remove it from\nthe base class.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n include/libcamera/internal/pipeline_handler.h | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex a4e1b529..2018bef0 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -47,7 +47,6 @@ public:\n \tstd::list<Request *> queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n-\tstd::unique_ptr<IPAProxy> ipa_;\n \n private:\n \tCameraData(const CameraData &) = delete;\n", "prefixes": [ "libcamera-devel", "12/23" ] }