Patch Detail
Show a patch.
GET /api/1.1/patches/9169/?format=api
{ "id": 9169, "url": "https://patchwork.libcamera.org/api/1.1/patches/9169/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9169/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200804095850.275499-5-naush@raspberrypi.com>", "date": "2020-08-04T09:58:42", "name": "[libcamera-devel,v6,04/12] libcamera: pipeline: raspberrypi: Increase the number of RAW buffers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ee9c461e2dc5e97b912e958e5d93cfb3f5ad0c38", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9169/mbox/", "series": [ { "id": 1187, "url": "https://patchwork.libcamera.org/api/1.1/series/1187/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1187", "date": "2020-08-04T09:58:38", "name": "Zero-copy RAW stream work", "version": 6, "mbox": "https://patchwork.libcamera.org/series/1187/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9169/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9169/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6245BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 4 Aug 2020 09:59:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DE0360499;\n\tTue, 4 Aug 2020 11:59:02 +0200 (CEST)", "from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D60760495\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 4 Aug 2020 11:59:00 +0200 (CEST)", "by mail-wm1-x343.google.com with SMTP id g8so2103982wmk.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 04 Aug 2020 02:59:00 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm34047234wrh.18.2020.08.04.02.58.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 04 Aug 2020 02:58:59 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CfVIQt+A\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=3+ZXMgg8PooDj2zFEFpjzLpTNquT9wyZ/ayyxCK3lyQ=;\n\tb=CfVIQt+A3cQvlnJq1iUcCiNtLyZ8Z2jM6J7YeiV5D6j4QlQkiN6yIMi2iUcJcE/EwN\n\t7v+cPL621l2SxJwjZuGKpUclrbPh17j+MiyZwyCR89Z1nd7tZW0yGLS8F0wj5I6Qkejr\n\tRw5W7bWscD4BGKJy3+Dt2CDBRb7bhxkukKgJck4ddF3BDnCjaCWAG2mv1WByz3n616Yg\n\tEsFTAXLj0uMxZv33d+nh8PqhL8UqqZ6m9cIgQELQwQ4znElmgd9Dp8fuQdug5GD4BzjX\n\t8SyiDO3PdaoJsgu26rMZ+I9UJ5T3KaQtLVLrm2F36sPkXEkScH4C6CWupkeQsRBcURBt\n\t5Zog==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=3+ZXMgg8PooDj2zFEFpjzLpTNquT9wyZ/ayyxCK3lyQ=;\n\tb=R1263fSlxY6wnqpYMzJxrMsNI4+RU+jZlUx5W5zjwcy+ar/coBNtnlDsoOCVtL4jDy\n\tVD5PIfWv9mrOOQ1feyBEvztL8epTY08jv+GgAqgE+woMLT//cUJSanB+oa8IyF8Gcukm\n\tcPL6tZSuoIgkaE0TnYoNGq0Gm1x2qewPja0JmcGE+RiCw2pNhhQoG6DBYbbezE3vBqfH\n\tG8F22ka8PoqUbUKJ9nW4fSdKGrySMs9LJyhTOph/njZ/oUg0X8kMvaIGQsxYCKa9S1YE\n\tlXBgIidNjh/OuhIyLrlxDerasrDgnUtIgpVhXavJl2a2U6fDD2L/qVhPw2Bvu8dWRgdy\n\tN8qA==", "X-Gm-Message-State": "AOAM5321693ej6MQNxpdQkUxZpGQgK7agwiWrSfBopvbvSr3dYP50pMz\n\tC5gen820oXh4KuBF/iJUmZ9bGRTiNzravg==", "X-Google-Smtp-Source": "ABdhPJwZSX+zijS9rXo7dT6kQUguTM9cKeEGGubqQae9WFbew5EzDcFG+HFo66a0VdZ3SuQJI3/K0A==", "X-Received": "by 2002:a05:600c:2302:: with SMTP id\n\t2mr3431722wmo.151.1596535140040; \n\tTue, 04 Aug 2020 02:59:00 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 4 Aug 2020 10:58:42 +0100", "Message-Id": "<20200804095850.275499-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200804095850.275499-1-naush@raspberrypi.com>", "References": "<20200804095850.275499-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v6 04/12] libcamera: pipeline:\n\traspberrypi: Increase the number of RAW buffers", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Increase the number of expected RAW buffers in the stream configuration\nto 2. This will avoid dropping Unicam frames when exporting RAW streams.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 61925033..a6b87df1 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -378,7 +378,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n \t\t\tsensorFormat = findBestMode(fmts, size);\n \t\t\tpixelFormat = sensorFormat.fourcc.toPixelFormat();\n \t\t\tASSERT(pixelFormat.isValid());\n-\t\t\tbufferCount = 1;\n+\t\t\tbufferCount = 2;\n \t\t\trawCount++;\n \t\t\tbreak;\n \n", "prefixes": [ "libcamera-devel", "v6", "04/12" ] }