From patchwork Tue Aug 4 09:58:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 9169 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B6245BD86F for ; Tue, 4 Aug 2020 09:59:02 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7DE0360499; Tue, 4 Aug 2020 11:59:02 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="CfVIQt+A"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D60760495 for ; Tue, 4 Aug 2020 11:59:00 +0200 (CEST) Received: by mail-wm1-x343.google.com with SMTP id g8so2103982wmk.3 for ; Tue, 04 Aug 2020 02:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3+ZXMgg8PooDj2zFEFpjzLpTNquT9wyZ/ayyxCK3lyQ=; b=CfVIQt+A3cQvlnJq1iUcCiNtLyZ8Z2jM6J7YeiV5D6j4QlQkiN6yIMi2iUcJcE/EwN 7v+cPL621l2SxJwjZuGKpUclrbPh17j+MiyZwyCR89Z1nd7tZW0yGLS8F0wj5I6Qkejr Rw5W7bWscD4BGKJy3+Dt2CDBRb7bhxkukKgJck4ddF3BDnCjaCWAG2mv1WByz3n616Yg EsFTAXLj0uMxZv33d+nh8PqhL8UqqZ6m9cIgQELQwQ4znElmgd9Dp8fuQdug5GD4BzjX 8SyiDO3PdaoJsgu26rMZ+I9UJ5T3KaQtLVLrm2F36sPkXEkScH4C6CWupkeQsRBcURBt 5Zog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3+ZXMgg8PooDj2zFEFpjzLpTNquT9wyZ/ayyxCK3lyQ=; b=R1263fSlxY6wnqpYMzJxrMsNI4+RU+jZlUx5W5zjwcy+ar/coBNtnlDsoOCVtL4jDy VD5PIfWv9mrOOQ1feyBEvztL8epTY08jv+GgAqgE+woMLT//cUJSanB+oa8IyF8Gcukm cPL6tZSuoIgkaE0TnYoNGq0Gm1x2qewPja0JmcGE+RiCw2pNhhQoG6DBYbbezE3vBqfH G8F22ka8PoqUbUKJ9nW4fSdKGrySMs9LJyhTOph/njZ/oUg0X8kMvaIGQsxYCKa9S1YE lXBgIidNjh/OuhIyLrlxDerasrDgnUtIgpVhXavJl2a2U6fDD2L/qVhPw2Bvu8dWRgdy N8qA== X-Gm-Message-State: AOAM5321693ej6MQNxpdQkUxZpGQgK7agwiWrSfBopvbvSr3dYP50pMz C5gen820oXh4KuBF/iJUmZ9bGRTiNzravg== X-Google-Smtp-Source: ABdhPJwZSX+zijS9rXo7dT6kQUguTM9cKeEGGubqQae9WFbew5EzDcFG+HFo66a0VdZ3SuQJI3/K0A== X-Received: by 2002:a05:600c:2302:: with SMTP id 2mr3431722wmo.151.1596535140040; Tue, 04 Aug 2020 02:59:00 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id 32sm34047234wrh.18.2020.08.04.02.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 02:58:59 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 4 Aug 2020 10:58:42 +0100 Message-Id: <20200804095850.275499-5-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200804095850.275499-1-naush@raspberrypi.com> References: <20200804095850.275499-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 04/12] libcamera: pipeline: raspberrypi: Increase the number of RAW buffers X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Increase the number of expected RAW buffers in the stream configuration to 2. This will avoid dropping Unicam frames when exporting RAW streams. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Tested-by: David Plowman --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index 61925033..a6b87df1 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -378,7 +378,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera, sensorFormat = findBestMode(fmts, size); pixelFormat = sensorFormat.fourcc.toPixelFormat(); ASSERT(pixelFormat.isValid()); - bufferCount = 1; + bufferCount = 2; rawCount++; break;