Patch Detail
Show a patch.
GET /api/1.1/patches/8948/?format=api
{ "id": 8948, "url": "https://patchwork.libcamera.org/api/1.1/patches/8948/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8948/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200724072218.943245-5-naush@raspberrypi.com>", "date": "2020-07-24T07:22:12", "name": "[libcamera-devel,v5,04/10] libcamera: pipeline: raspberrypi: Add some debug logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "de544592e7fa6a43a39eef27a7b629daa441a268", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/1.1/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8948/mbox/", "series": [ { "id": 1132, "url": "https://patchwork.libcamera.org/api/1.1/series/1132/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1132", "date": "2020-07-24T07:22:08", "name": "Zero-copy RAW stream work", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1132/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8948/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8948/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DF9EBD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jul 2020 07:22:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F25C5611AA;\n\tFri, 24 Jul 2020 09:22:56 +0200 (CEST)", "from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 758EA61167\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 09:22:52 +0200 (CEST)", "by mail-wm1-x343.google.com with SMTP id g10so7980465wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jul 2020 00:22:52 -0700 (PDT)", "from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t32sm246595wrn.86.2020.07.24.00.22.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 00:22:50 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"s5a2L5xI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=m+9E5jSUrpBHYnUqPVx6koIacuWlze0nry6YJBKiZVk=;\n\tb=s5a2L5xIr4XRWh8fspxjGUTLCKzNEpHS5eH3y82s3kRqiTRko+IaWfavv15tNi8NqG\n\t9t8KP9Oi8973UGtP+/+SAbBmlML40WFKfM1wZ9vUuapNNiRlQPeD2ntT2dGSDE3YTJVC\n\t5ZC88hej8QpFk4jmkDCv30ISVU+cNUH1zK60b2EKmUaV88gPtYKEl74zsU0XaHllAlPW\n\tUgPX1/GkK5KarI1MGqD99luvDAT6mQF1HAcbHCQxjn1d7FlVAjgW70K4ylfnEw4kSlLn\n\t7PiJDGyG+k11w++XfzhB3O5Khk43JcGwz+4BsL/S8aUP6nFcFcnNPjco3C5nR8zLJdcT\n\tuRBg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=m+9E5jSUrpBHYnUqPVx6koIacuWlze0nry6YJBKiZVk=;\n\tb=seoeeQUt0J/11KxUO9GrRljl9jC1HooSBcSvXyXQ10ExOguypFVPvAUE24c5eTiMNq\n\t5RIfewqrDdScxQI8iprdUlAFBmhp5oO8GAMg7ZSspIX9Ip79YLLXVIWiN5wgKT1Mjdpm\n\tswdZRt+pHQjW6AWQw+eVULVZQY3qz0xV1DrFAIi0AJ+JtmzgFM+nvwLc63n5eU+2HjWC\n\tSpLNsSoVpxjPuTK7Q+v7VGiX4ehFjU0ApVgTQOj3CpBc/fOnPU6K1AMQCe1eMhOoC4H1\n\t8cW4hHqFRA/hL32FezMK7JxFAEE5en9QWpZGUDGfuna1wqII7ad2Y6kIjJFIaZpV+uoF\n\tdXxw==", "X-Gm-Message-State": "AOAM5307TSnPfmAFWmd72Eb48dBePbW7ThpIOjDWPBz5OhtiCSe2GlAy\n\t9xiYi4jctbSydYa/3Oy7pEjvh3vGWNt1iA==", "X-Google-Smtp-Source": "ABdhPJyGbxL4Xt092GlUnyJw4s7dUYEz47GuEEF9pO5xfz+O2oYLdBhp1DisQxqqCnZH7sp08TUagQ==", "X-Received": "by 2002:a1c:62d6:: with SMTP id\n\tw205mr6979690wmb.154.1595575371825; \n\tFri, 24 Jul 2020 00:22:51 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jul 2020 08:22:12 +0100", "Message-Id": "<20200724072218.943245-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200724072218.943245-1-naush@raspberrypi.com>", "References": "<20200724072218.943245-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 04/10] libcamera: pipeline:\n\traspberrypi: Add some debug logging", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex d3639ce1..8c7b6341 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1462,7 +1467,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue<FrameBuffer *> &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n", "prefixes": [ "libcamera-devel", "v5", "04/10" ] }