From patchwork Fri Jul 24 07:22:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 8948 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4DF9EBD86F for ; Fri, 24 Jul 2020 07:22:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F25C5611AA; Fri, 24 Jul 2020 09:22:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="s5a2L5xI"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 758EA61167 for ; Fri, 24 Jul 2020 09:22:52 +0200 (CEST) Received: by mail-wm1-x343.google.com with SMTP id g10so7980465wmc.1 for ; Fri, 24 Jul 2020 00:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m+9E5jSUrpBHYnUqPVx6koIacuWlze0nry6YJBKiZVk=; b=s5a2L5xIr4XRWh8fspxjGUTLCKzNEpHS5eH3y82s3kRqiTRko+IaWfavv15tNi8NqG 9t8KP9Oi8973UGtP+/+SAbBmlML40WFKfM1wZ9vUuapNNiRlQPeD2ntT2dGSDE3YTJVC 5ZC88hej8QpFk4jmkDCv30ISVU+cNUH1zK60b2EKmUaV88gPtYKEl74zsU0XaHllAlPW UgPX1/GkK5KarI1MGqD99luvDAT6mQF1HAcbHCQxjn1d7FlVAjgW70K4ylfnEw4kSlLn 7PiJDGyG+k11w++XfzhB3O5Khk43JcGwz+4BsL/S8aUP6nFcFcnNPjco3C5nR8zLJdcT uRBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m+9E5jSUrpBHYnUqPVx6koIacuWlze0nry6YJBKiZVk=; b=seoeeQUt0J/11KxUO9GrRljl9jC1HooSBcSvXyXQ10ExOguypFVPvAUE24c5eTiMNq 5RIfewqrDdScxQI8iprdUlAFBmhp5oO8GAMg7ZSspIX9Ip79YLLXVIWiN5wgKT1Mjdpm swdZRt+pHQjW6AWQw+eVULVZQY3qz0xV1DrFAIi0AJ+JtmzgFM+nvwLc63n5eU+2HjWC SpLNsSoVpxjPuTK7Q+v7VGiX4ehFjU0ApVgTQOj3CpBc/fOnPU6K1AMQCe1eMhOoC4H1 8cW4hHqFRA/hL32FezMK7JxFAEE5en9QWpZGUDGfuna1wqII7ad2Y6kIjJFIaZpV+uoF dXxw== X-Gm-Message-State: AOAM5307TSnPfmAFWmd72Eb48dBePbW7ThpIOjDWPBz5OhtiCSe2GlAy 9xiYi4jctbSydYa/3Oy7pEjvh3vGWNt1iA== X-Google-Smtp-Source: ABdhPJyGbxL4Xt092GlUnyJw4s7dUYEz47GuEEF9pO5xfz+O2oYLdBhp1DisQxqqCnZH7sp08TUagQ== X-Received: by 2002:a1c:62d6:: with SMTP id w205mr6979690wmb.154.1595575371825; Fri, 24 Jul 2020 00:22:51 -0700 (PDT) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id 32sm246595wrn.86.2020.07.24.00.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 00:22:50 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 24 Jul 2020 08:22:12 +0100 Message-Id: <20200724072218.943245-5-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200724072218.943245-1-naush@raspberrypi.com> References: <20200724072218.943245-1-naush@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 04/10] libcamera: pipeline: raspberrypi: Add some debug logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" No functional changes, only added some more trace points. Signed-off-by: Naushir Patuck Reviewed-by: Niklas Söderlund Reviewed-by: Kieran Bingham Tested-by: David Plowman --- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp index d3639ce1..8c7b6341 100644 --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp @@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer) if (state_ == State::Stopped) return; + LOG(RPI, Debug) << "Stream ISP Input buffer complete" + << ", buffer id " << buffer->cookie() + << ", timestamp: " << buffer->metadata().timestamp; + + /* The ISP input buffer gets re-queued into Unicam. */ handleStreamBuffer(buffer, &unicam_[Unicam::Image]); handleState(); } @@ -1462,7 +1467,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t if (b->metadata().timestamp < timestamp) { q.pop(); dev->queueBuffer(b); - LOG(RPI, Error) << "Dropping input frame!"; + LOG(RPI, Warning) << "Dropping input frame!"; } else if (b->metadata().timestamp == timestamp) { /* The calling function will pop the item from the queue. */ return b;