Patch Detail
Show a patch.
GET /api/1.1/patches/8735/?format=api
{ "id": 8735, "url": "https://patchwork.libcamera.org/api/1.1/patches/8735/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8735/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200709132835.112593-21-paul.elder@ideasonboard.com>", "date": "2020-07-09T13:28:32", "name": "[libcamera-devel,v5,20/23] v4l2: v4l2_camera: Fix stream selection for buffer operations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4a74addb7dd462db9d80d4a8c9b12147fda925e6", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8735/mbox/", "series": [ { "id": 1093, "url": "https://patchwork.libcamera.org/api/1.1/series/1093/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1093", "date": "2020-07-09T13:28:12", "name": "Clean up formats in v4l2-compat and pipeline handlers", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1093/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8735/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8735/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54B5BBD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 9 Jul 2020 13:29:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2187B611BA;\n\tThu, 9 Jul 2020 15:29:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEC06611BA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 9 Jul 2020 15:29:39 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33DC256E;\n\tThu, 9 Jul 2020 15:29:36 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M5Ee6Eq3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594301379;\n\tbh=dtc2+Z8g+ODJm3FVyETwxgyoQyMsa22bFPLH4RYBYpE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=M5Ee6Eq3GLeeir6VaQ35CtNvtaJII6lsD2sdKks+Cj+4wv9J+9tqYXGh6ZxD5cWCI\n\tOW82POgkuM7uOX/3/cWdDHUvPGMM45UgeajxuFPRFE0k5Bo/f25xhGxEFBphxZxEe6\n\tOUNLlnKmgpmgztz37nPajO1puaUV5/nDodOVUGSc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 9 Jul 2020 22:28:32 +0900", "Message-Id": "<20200709132835.112593-21-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200709132835.112593-1-paul.elder@ideasonboard.com>", "References": "<20200709132835.112593-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 20/23] v4l2: v4l2_camera: Fix stream\n\tselection for buffer operations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The buffer operations in V4L2Camera were getting the stream from the\nwrong place. Fix it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\n---\nNo change in v5\n\nNew in v4\n---\n src/v4l2/v4l2_camera.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex ffc1230..a923256 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -140,7 +140,7 @@ int V4L2Camera::configure(StreamConfiguration *streamConfigOut,\n \n int V4L2Camera::allocBuffers(unsigned int count)\n {\n-\tStream *stream = *camera_->streams().begin();\n+\tStream *stream = config_->at(0).stream();\n \n \treturn bufferAllocator_->allocate(stream);\n }\n@@ -149,13 +149,13 @@ void V4L2Camera::freeBuffers()\n {\n \tpendingRequests_.clear();\n \n-\tStream *stream = *camera_->streams().begin();\n+\tStream *stream = config_->at(0).stream();\n \tbufferAllocator_->free(stream);\n }\n \n FileDescriptor V4L2Camera::getBufferFd(unsigned int index)\n {\n-\tStream *stream = *camera_->streams().begin();\n+\tStream *stream = config_->at(0).stream();\n \tconst std::vector<std::unique_ptr<FrameBuffer>> &buffers =\n \t\tbufferAllocator_->buffers(stream);\n \n", "prefixes": [ "libcamera-devel", "v5", "20/23" ] }