Patch Detail
Show a patch.
GET /api/1.1/patches/868/?format=api
{ "id": 868, "url": "https://patchwork.libcamera.org/api/1.1/patches/868/?format=api", "web_url": "https://patchwork.libcamera.org/patch/868/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190402171309.6447-13-jacopo@jmondi.org>", "date": "2019-04-02T17:13:08", "name": "[libcamera-devel,v7,12/13] libcamera: ipu3: Limit resolution to 2560x1920", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8374f021ebb3e136fb9b147dd281a910c826041d", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/868/mbox/", "series": [ { "id": 231, "url": "https://patchwork.libcamera.org/api/1.1/series/231/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=231", "date": "2019-04-02T17:12:56", "name": "libcamera: ipu3: Add ImgU support", "version": 7, "mbox": "https://patchwork.libcamera.org/series/231/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/868/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/868/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF3AC610C5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Apr 2019 19:12:39 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 279BEFF807;\n\tTue, 2 Apr 2019 17:12:38 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Apr 2019 19:13:08 +0200", "Message-Id": "<20190402171309.6447-13-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190402171309.6447-1-jacopo@jmondi.org>", "References": "<20190402171309.6447-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 12/13] libcamera: ipu3: Limit\n\tresolution to 2560x1920", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 02 Apr 2019 17:12:40 -0000" }, "content": "As the procedure to configure the intermediate sizes and the alignement\nrequirements of the ImgU device have not been clarified yet, return as\ndefault configuration the (2560x1920) resolution that has been validated\nfor both cameras.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex e4f8f90e2302..838215de1603 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -220,10 +220,17 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n \tstd::map<Stream *, StreamConfiguration> configs;\n \tIPU3CameraData *data = cameraData(camera);\n \tStreamConfiguration *config = &configs[&data->stream_];\n-\tSize *maxSize = &data->.cio2_.maxSize_;\n \n-\tconfig->width = maxSize->width;\n-\tconfig->height = maxSize->height;\n+\t/*\n+\t * FIXME: Soraka: the maximum resolution reported by both sensors\n+\t * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as\n+\t * default configurations but they're not correctly processed by the\n+\t * ImgU. Resolutions up tp 2560x1920 have been validated.\n+\t *\n+\t * \\todo Clarify ImgU alignement requirements.\n+\t */\n+\tconfig->width = 2560;\n+\tconfig->height = 1920;\n \tconfig->pixelFormat = V4L2_PIX_FMT_NV12;\n \tconfig->bufferCount = IPU3_BUFFER_COUNT;\n \n", "prefixes": [ "libcamera-devel", "v7", "12/13" ] }