[libcamera-devel,v7,12/13] libcamera: ipu3: Limit resolution to 2560x1920
diff mbox series

Message ID 20190402171309.6447-13-jacopo@jmondi.org
State Superseded
Headers show
Series
  • libcamera: ipu3: Add ImgU support
Related show

Commit Message

Jacopo Mondi April 2, 2019, 5:13 p.m. UTC 
As the procedure to configure the intermediate sizes and the alignement
requirements of the ImgU device have not been clarified yet, return as
default configuration the (2560x1920) resolution that has been validated
for both cameras.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index e4f8f90e2302..838215de1603 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -220,10 +220,17 @@  PipelineHandlerIPU3::streamConfiguration(Camera *camera,
 	std::map<Stream *, StreamConfiguration> configs;
 	IPU3CameraData *data = cameraData(camera);
 	StreamConfiguration *config = &configs[&data->stream_];
-	Size *maxSize = &data->.cio2_.maxSize_;
 
-	config->width = maxSize->width;
-	config->height = maxSize->height;
+	/*
+	 * FIXME: Soraka: the maximum resolution reported by both sensors
+	 * (2592x1944 for ov5670 and 4224x3136 for ov13858) are returned as
+	 * default configurations but they're not correctly processed by the
+	 * ImgU. Resolutions up tp 2560x1920 have been validated.
+	 *
+	 * \todo Clarify ImgU alignement requirements.
+	 */
+	config->width = 2560;
+	config->height = 1920;
 	config->pixelFormat = V4L2_PIX_FMT_NV12;
 	config->bufferCount = IPU3_BUFFER_COUNT;