Patch Detail
Show a patch.
GET /api/1.1/patches/8464/?format=api
{ "id": 8464, "url": "https://patchwork.libcamera.org/api/1.1/patches/8464/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8464/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200628001532.2685967-8-niklas.soderlund@ragnatech.se>", "date": "2020-06-28T00:15:26", "name": "[libcamera-devel,v2,07/13] libcamera: ipu3: imgu: Mark things that are internal as private", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f7057a74d4ddd3885f5f6cb2ef75ff5898832de0", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8464/mbox/", "series": [ { "id": 1048, "url": "https://patchwork.libcamera.org/api/1.1/series/1048/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1048", "date": "2020-06-28T00:15:19", "name": "libcamera: ipu3: Refactoring of ImgU", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1048/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8464/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8464/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01A39C2E69\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 28 Jun 2020 00:15:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE98260AF9;\n\tSun, 28 Jun 2020 02:15:56 +0200 (CEST)", "from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47AD2609DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Jun 2020 02:15:51 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 71350f88-b8d4-11ea-86ee-0050569116f7;\n\tSun, 28 Jun 2020 02:15:16 +0200 (CEST)" ], "X-Halon-ID": "71350f88-b8d4-11ea-86ee-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 28 Jun 2020 02:15:26 +0200", "Message-Id": "<20200628001532.2685967-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200628001532.2685967-1-niklas.soderlund@ragnatech.se>", "References": "<20200628001532.2685967-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 07/13] libcamera: ipu3: imgu: Mark\n\tthings that are internal as private", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Mark all variables and functions that are only used internally as\nprivate.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/imgu.h | 24 +++++++++++++-----------\n 1 file changed, 13 insertions(+), 11 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex ad5aabf134e2099d..b6b08b4fef2d3a9d 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -24,11 +24,6 @@ struct StreamConfiguration;\n class ImgUDevice\n {\n public:\n-\tstatic constexpr unsigned int PAD_INPUT = 0;\n-\tstatic constexpr unsigned int PAD_OUTPUT = 2;\n-\tstatic constexpr unsigned int PAD_VF = 3;\n-\tstatic constexpr unsigned int PAD_STAT = 4;\n-\n \t/* ImgU output descriptor: group data specific to an ImgU output. */\n \tstruct ImgUOutput {\n \t\tV4L2VideoDevice *dev;\n@@ -64,20 +59,27 @@ public:\n \tint start();\n \tint stop();\n \n-\tint linkSetup(const std::string &source, unsigned int sourcePad,\n-\t\t const std::string &sink, unsigned int sinkPad,\n-\t\t bool enable);\n \tint enableLinks(bool enable);\n \n-\tstd::string name_;\n-\tMediaDevice *media_;\n-\n \tV4L2Subdevice *imgu_;\n \tV4L2VideoDevice *input_;\n \tImgUOutput output_;\n \tImgUOutput viewfinder_;\n \tImgUOutput stat_;\n \t/* \\todo Add param video device for 3A tuning */\n+\n+private:\n+\tstatic constexpr unsigned int PAD_INPUT = 0;\n+\tstatic constexpr unsigned int PAD_OUTPUT = 2;\n+\tstatic constexpr unsigned int PAD_VF = 3;\n+\tstatic constexpr unsigned int PAD_STAT = 4;\n+\n+\tint linkSetup(const std::string &source, unsigned int sourcePad,\n+\t\t const std::string &sink, unsigned int sinkPad,\n+\t\t bool enable);\n+\n+\tstd::string name_;\n+\tMediaDevice *media_;\n };\n \n } /* namespace libcamera */\n", "prefixes": [ "libcamera-devel", "v2", "07/13" ] }