[libcamera-devel,v2,07/13] libcamera: ipu3: imgu: Mark things that are internal as private
diff mbox series

Message ID 20200628001532.2685967-8-niklas.soderlund@ragnatech.se
State Accepted
Headers show
Series
  • libcamera: ipu3: Refactoring of ImgU
Related show

Commit Message

Niklas Söderlund June 28, 2020, 12:15 a.m. UTC 
Mark all variables and functions that are only used internally as
private.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/pipeline/ipu3/imgu.h | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h
index ad5aabf134e2099d..b6b08b4fef2d3a9d 100644
--- a/src/libcamera/pipeline/ipu3/imgu.h
+++ b/src/libcamera/pipeline/ipu3/imgu.h
@@ -24,11 +24,6 @@  struct StreamConfiguration;
 class ImgUDevice
 {
 public:
-	static constexpr unsigned int PAD_INPUT = 0;
-	static constexpr unsigned int PAD_OUTPUT = 2;
-	static constexpr unsigned int PAD_VF = 3;
-	static constexpr unsigned int PAD_STAT = 4;
-
 	/* ImgU output descriptor: group data specific to an ImgU output. */
 	struct ImgUOutput {
 		V4L2VideoDevice *dev;
@@ -64,20 +59,27 @@  public:
 	int start();
 	int stop();
 
-	int linkSetup(const std::string &source, unsigned int sourcePad,
-		      const std::string &sink, unsigned int sinkPad,
-		      bool enable);
 	int enableLinks(bool enable);
 
-	std::string name_;
-	MediaDevice *media_;
-
 	V4L2Subdevice *imgu_;
 	V4L2VideoDevice *input_;
 	ImgUOutput output_;
 	ImgUOutput viewfinder_;
 	ImgUOutput stat_;
 	/* \todo Add param video device for 3A tuning */
+
+private:
+	static constexpr unsigned int PAD_INPUT = 0;
+	static constexpr unsigned int PAD_OUTPUT = 2;
+	static constexpr unsigned int PAD_VF = 3;
+	static constexpr unsigned int PAD_STAT = 4;
+
+	int linkSetup(const std::string &source, unsigned int sourcePad,
+		      const std::string &sink, unsigned int sinkPad,
+		      bool enable);
+
+	std::string name_;
+	MediaDevice *media_;
 };
 
 } /* namespace libcamera */