Patch Detail
Show a patch.
GET /api/1.1/patches/8443/?format=api
{ "id": 8443, "url": "https://patchwork.libcamera.org/api/1.1/patches/8443/?format=api", "web_url": "https://patchwork.libcamera.org/patch/8443/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200627030043.2088585-2-niklas.soderlund@ragnatech.se>", "date": "2020-06-27T03:00:31", "name": "[libcamera-devel,01/13] libcamera: ipu3: Remove unused name_ filed from IPU3Stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0d1676463b2d41c594c840c7662f41b64fc05c28", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/8443/mbox/", "series": [ { "id": 1046, "url": "https://patchwork.libcamera.org/api/1.1/series/1046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1046", "date": "2020-06-27T03:00:30", "name": "libcamera: ipu3: Refactoring of ImgU", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/8443/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/8443/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F35D7C2E66\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 27 Jun 2020 03:00:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D7EA060A16;\n\tSat, 27 Jun 2020 05:00:50 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A31CF609C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Jun 2020 05:00:49 +0200 (CEST)", "from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 53b3a6d1-b822-11ea-86ee-0050569116f7;\n\tSat, 27 Jun 2020 05:00:16 +0200 (CEST)" ], "X-Halon-ID": "53b3a6d1-b822-11ea-86ee-0050569116f7", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 27 Jun 2020 05:00:31 +0200", "Message-Id": "<20200627030043.2088585-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>", "References": "<20200627030043.2088585-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 01/13] libcamera: ipu3: Remove unused\n\tname_ filed from IPU3Stream", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The field is never used, remove it.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 6c43169eb0915965..fba45935741e0e4e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -109,7 +109,6 @@ public:\n \n \tbool active_;\n \tbool raw_;\n-\tstd::string name_;\n \tImgUDevice::ImgUOutput *device_;\n };\n \n@@ -867,11 +866,8 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t */\n \t\tdata->imgu_ = numCameras ? &imgu1_ : &imgu0_;\n \t\tdata->outStream_.device_ = &data->imgu_->output_;\n-\t\tdata->outStream_.name_ = \"output\";\n \t\tdata->vfStream_.device_ = &data->imgu_->viewfinder_;\n-\t\tdata->vfStream_.name_ = \"viewfinder\";\n \t\tdata->rawStream_.raw_ = true;\n-\t\tdata->rawStream_.name_ = \"raw\";\n \n \t\t/*\n \t\t * Connect video devices' 'bufferReady' signals to their\n", "prefixes": [ "libcamera-devel", "01/13" ] }