| Message ID | 20200627030043.2088585-2-niklas.soderlund@ragnatech.se |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas, Thank you for the patch. On Sat, Jun 27, 2020 at 05:00:31AM +0200, Niklas Söderlund wrote: > The field is never used, remove it. > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index 6c43169eb0915965..fba45935741e0e4e 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -109,7 +109,6 @@ public: > > bool active_; > bool raw_; > - std::string name_; > ImgUDevice::ImgUOutput *device_; > }; > > @@ -867,11 +866,8 @@ int PipelineHandlerIPU3::registerCameras() > */ > data->imgu_ = numCameras ? &imgu1_ : &imgu0_; > data->outStream_.device_ = &data->imgu_->output_; > - data->outStream_.name_ = "output"; > data->vfStream_.device_ = &data->imgu_->viewfinder_; > - data->vfStream_.name_ = "viewfinder"; > data->rawStream_.raw_ = true; > - data->rawStream_.name_ = "raw"; > > /* > * Connect video devices' 'bufferReady' signals to their
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 6c43169eb0915965..fba45935741e0e4e 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -109,7 +109,6 @@ public: bool active_; bool raw_; - std::string name_; ImgUDevice::ImgUOutput *device_; }; @@ -867,11 +866,8 @@ int PipelineHandlerIPU3::registerCameras() */ data->imgu_ = numCameras ? &imgu1_ : &imgu0_; data->outStream_.device_ = &data->imgu_->output_; - data->outStream_.name_ = "output"; data->vfStream_.device_ = &data->imgu_->viewfinder_; - data->vfStream_.name_ = "viewfinder"; data->rawStream_.raw_ = true; - data->rawStream_.name_ = "raw"; /* * Connect video devices' 'bufferReady' signals to their
The field is never used, remove it. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ---- 1 file changed, 4 deletions(-)